You are not logged in. Your edit will be placed in a queue until it is peer reviewed.
We welcome edits that make the post easier to understand and more valuable for readers. Because community members review edits, please try to make the post substantially better than how you found it, for example, by fixing grammar or adding additional resources and hyperlinks.
-
Good point. I think the best thing to do at this point might be to revisit the code, clean it up, resolve any errors, and make sure there isn't any undefined behavior. It might be a waste of time to compare the binaries if the code has inherent problems. I'm going to try to refactor some of it and see if the discrepancy still exists. Thanks for the tips and for catching that array out of bounds problem!Hendeca– Hendeca2015-07-03 08:36:56 +00:00Commented Jul 3, 2015 at 8:36
-
@Hendeca: I tried some minimal cleanup on your code. Check your github repo for the pull request.Edgar Bonet– Edgar Bonet2015-07-03 11:05:01 +00:00Commented Jul 3, 2015 at 11:05
-
Thanks very much! Very helpful. We will test this out and keep refactoring from there. Also, this is collaborative and I was unaware that this is an earlier version of the code. I'll edit the question to point to the new version of the code. I will likely just do the same changes you made in your pull request to the newer sketch. If you so desire, feel free to put in another pull request on the new sketch. Sorry about the confusion and thanks again for your help, it's much appreciated!Hendeca– Hendeca2015-07-03 18:34:22 +00:00Commented Jul 3, 2015 at 18:34
-
The original code was contributed to by many different people over a long period of time. I went through and completely refactored and cleaned up the code. It now works and I believe that the array out of bounds problem was likely the culprit. To me it explains most reasonably why it would behave so different between two different compilations on different versions of the Arduino IDE. Accepting this as the correct answer. Thanks!Hendeca– Hendeca2015-07-21 07:28:51 +00:00Commented Jul 21, 2015 at 7:28
Add a comment
|
How to Edit
- Correct minor typos or mistakes
- Clarify meaning without changing it
- Add related resources or links
- Always respect the author’s intent
- Don’t use edits to reply to the author
How to Format
-
create code fences with backticks ` or tildes ~
```
like so
``` -
add language identifier to highlight code
```python
def function(foo):
print(foo)
``` - put returns between paragraphs
- for linebreak add 2 spaces at end
- _italic_ or **bold**
- indent code by 4 spaces
- backtick escapes
`like _so_` - quote by placing > at start of line
- to make links (use https whenever possible)
<https://example.com>[example](https://example.com)<a href="https://example.com">example</a>
How to Tag
A tag is a keyword or label that categorizes your question with other, similar questions. Choose one or more (up to 5) tags that will help answerers to find and interpret your question.
- complete the sentence: my question is about...
- use tags that describe things or concepts that are essential, not incidental to your question
- favor using existing popular tags
- read the descriptions that appear below the tag
If your question is primarily about a topic for which you can't find a tag:
- combine multiple words into single-words with hyphens (e.g. arduino-uno), up to a maximum of 35 characters
- creating new tags is a privilege; if you can't yet create a tag you need, then post this question without it, then ask the community to create it for you
lang-cpp