Revisions to Run encoder code simultaneously with other code in Arduino

Removed from Network Questions by Juraj♦

occurred Dec 6, 2022 at 6:07

Became Hot Network Question

occurred Dec 5, 2022 at 19:10

added 28 characters in body

Source Link

edited Dec 5, 2022 at 16:31

chrisl

16.6k
2
18
27

#include <PID_v1.h> double Setpoint ; double Input; double Output ; volatile unsigned int temp, counterrr = 0; int county=0;

double Kp=0, Ki=2, Kd=0;
PID myPID(&Input, &Output, &Setpoint, Kp, Ki, Kd, DIRECT);

#include <PID_v1.h>
double Setpoint ;  double Input; double Output ;
volatile unsigned int temp, counterrr = 0; 
int county=0; 

double Kp=0, Ki=2, Kd=0;  
PID myPID(&Input, &Output, &Setpoint, Kp, Ki, Kd, DIRECT);


void setup()
{
  
  Serial.begin(9600);   
  Setpoint = 120;
  myPID.SetMode(AUTOMATIC);
  myPID.SetTunings(Kp, Ki, Kd);
  pinMode(2, INPUT_PULLUP); 
  pinMode(3, INPUT_PULLUP); 
  attachInterrupt(0, ai0, RISING);
  attachInterrupt(1, ai1, RISING);  
}
 
void loop()
{
    
}

  void ai0() {
    if(digitalRead(3)==LOW) {
    counterrr++;}
    else{
      counterrr--;}

        county= (counterrr);
  Serial.println(county);
  Input = map(county, 0, 1024, 0, 1200);  // photo senor is set on analog pin 5
  myPID.Compute();
  analogWrite(9,Output); 
  Serial.print(Input);
  }
  void ai1() {
    if(digitalRead(2)==LOW) {
      counterrr--;}
      else{
        counterrr++;
        }

          county= (counterrr);
  Serial.println(county);
  Input = map(county, 0, 1024, 0, 1200);  // photo senor is set on analog pin 5
  myPID.Compute();
  analogWrite(9,Output); 
  Serial.print(Input);
        }

#include <PID_v1.h> double Setpoint ; double Input; double Output ; volatile unsigned int temp, counterrr = 0; int county=0;

double Kp=0, Ki=2, Kd=0;
PID myPID(&Input, &Output, &Setpoint, Kp, Ki, Kd, DIRECT);

void setup()
{
  
  Serial.begin(9600);   
  Setpoint = 120;
  myPID.SetMode(AUTOMATIC);
  myPID.SetTunings(Kp, Ki, Kd);
  pinMode(2, INPUT_PULLUP); 
  pinMode(3, INPUT_PULLUP); 
  attachInterrupt(0, ai0, RISING);
  attachInterrupt(1, ai1, RISING);  
}
 
void loop()
{
    
}

  void ai0() {
    if(digitalRead(3)==LOW) {
    counterrr++;}
    else{
      counterrr--;}

        county= (counterrr);
  Serial.println(county);
  Input = map(county, 0, 1024, 0, 1200);  // photo senor is set on analog pin 5
  myPID.Compute();
  analogWrite(9,Output); 
  Serial.print(Input);
  }
  void ai1() {
    if(digitalRead(2)==LOW) {
      counterrr--;}
      else{
        counterrr++;
        }

          county= (counterrr);
  Serial.println(county);
  Input = map(county, 0, 1024, 0, 1200);  // photo senor is set on analog pin 5
  myPID.Compute();
  analogWrite(9,Output); 
  Serial.print(Input);
        }

#include <PID_v1.h>
double Setpoint ;  double Input; double Output ;
volatile unsigned int temp, counterrr = 0; 
int county=0; 

double Kp=0, Ki=2, Kd=0;  
PID myPID(&Input, &Output, &Setpoint, Kp, Ki, Kd, DIRECT);


void setup()
{
  
  Serial.begin(9600);   
  Setpoint = 120;
  myPID.SetMode(AUTOMATIC);
  myPID.SetTunings(Kp, Ki, Kd);
  pinMode(2, INPUT_PULLUP); 
  pinMode(3, INPUT_PULLUP); 
  attachInterrupt(0, ai0, RISING);
  attachInterrupt(1, ai1, RISING);  
}
 
void loop()
{
    
}

  void ai0() {
    if(digitalRead(3)==LOW) {
    counterrr++;}
    else{
      counterrr--;}

        county= (counterrr);
  Serial.println(county);
  Input = map(county, 0, 1024, 0, 1200);  // photo senor is set on analog pin 5
  myPID.Compute();
  analogWrite(9,Output); 
  Serial.print(Input);
  }
  void ai1() {
    if(digitalRead(2)==LOW) {
      counterrr--;}
      else{
        counterrr++;
        }

          county= (counterrr);
  Serial.println(county);
  Input = map(county, 0, 1024, 0, 1200);  // photo senor is set on analog pin 5
  myPID.Compute();
  analogWrite(9,Output); 
  Serial.print(Input);
        }

added 1380 characters in body

Source Link

edited Dec 5, 2022 at 16:26

Maximus Su

11
3

PID code

#include <PID_v1.h> double Setpoint ; double Input; double Output ; volatile unsigned int temp, counterrr = 0; int county=0;

double Kp=0, Ki=2, Kd=0;
PID myPID(&Input, &Output, &Setpoint, Kp, Ki, Kd, DIRECT);

void setup()
{
  
  Serial.begin(9600);   
  Setpoint = 120;
  myPID.SetMode(AUTOMATIC);
  myPID.SetTunings(Kp, Ki, Kd);
  pinMode(2, INPUT_PULLUP); 
  pinMode(3, INPUT_PULLUP); 
  attachInterrupt(0, ai0, RISING);
  attachInterrupt(1, ai1, RISING);  
}
 
void loop()
{
    
}

  void ai0() {
    if(digitalRead(3)==LOW) {
    counterrr++;}
    else{
      counterrr--;}

        county= (counterrr);
  Serial.println(county);
  Input = map(county, 0, 1024, 0, 1200);  // photo senor is set on analog pin 5
  myPID.Compute();
  analogWrite(9,Output); 
  Serial.print(Input);
  }
  void ai1() {
    if(digitalRead(2)==LOW) {
      counterrr--;}
      else{
        counterrr++;
        }

          county= (counterrr);
  Serial.println(county);
  Input = map(county, 0, 1024, 0, 1200);  // photo senor is set on analog pin 5
  myPID.Compute();
  analogWrite(9,Output); 
  Serial.print(Input);
        }

PID code

#include <PID_v1.h> double Setpoint ; double Input; double Output ; volatile unsigned int temp, counterrr = 0; int county=0;

double Kp=0, Ki=2, Kd=0;
PID myPID(&Input, &Output, &Setpoint, Kp, Ki, Kd, DIRECT);

void setup()
{
  
  Serial.begin(9600);   
  Setpoint = 120;
  myPID.SetMode(AUTOMATIC);
  myPID.SetTunings(Kp, Ki, Kd);
  pinMode(2, INPUT_PULLUP); 
  pinMode(3, INPUT_PULLUP); 
  attachInterrupt(0, ai0, RISING);
  attachInterrupt(1, ai1, RISING);  
}
 
void loop()
{
    
}

  void ai0() {
    if(digitalRead(3)==LOW) {
    counterrr++;}
    else{
      counterrr--;}

        county= (counterrr);
  Serial.println(county);
  Input = map(county, 0, 1024, 0, 1200);  // photo senor is set on analog pin 5
  myPID.Compute();
  analogWrite(9,Output); 
  Serial.print(Input);
  }
  void ai1() {
    if(digitalRead(2)==LOW) {
      counterrr--;}
      else{
        counterrr++;
        }

          county= (counterrr);
  Serial.println(county);
  Input = map(county, 0, 1024, 0, 1200);  // photo senor is set on analog pin 5
  myPID.Compute();
  analogWrite(9,Output); 
  Serial.print(Input);
        }

deleted 17 characters in body

Source Link

edited Dec 5, 2022 at 15:48

Maximus Su

11
3

volatile unsigned int temp, counter = 0; 
int county=0; 
void setup()
{
  
  Serial.begin(9600);   
  pinMode(2, INPUT_PULLUP); 
  pinMode(3, INPUT_PULLUP); 
  attachInterrupt(0, ai0, RISING);
  attachInterrupt(1, ai1, RISING);  
}
 
void loop()
{
  county= (counter);
  if (counter>2000){
county=0;
  }
  temp = counter;
  
  Serial.println(county); // Encoder step counter
  
}

  void ai0() {if(digitalRead(3)==LOW) {counter++;}else{counter--;}}
  void ai1() {if(digitalRead(2)==LOW) {counter--;}else{counter++;}}

Dear all, above arduino code is used for encoder as counter and code is quoted from here, the above simple code works fine. However, if I were to add some code lines below the Serial.println(county);which actually delays execution time, the counter will actually skip steps and mess up the counter which I am very dissapointed.

May I ask how to solve this issue, my thought is can arduino actually run 2 void loop simultaneously so that the counter code can be run simultaneously and not be affected by other code lines which introduces delay time that mess up the counter. Any help will be appreciated :)

volatile unsigned int temp, counter = 0; 
void setup()
{
  
  Serial.begin(9600);   pinMode(2, INPUT_PULLUP); pinMode(3, INPUT_PULLUP); attachInterrupt(0, ai0, RISING);attachInterrupt(1, ai1, RISING);  
}
 
void loop()
{
noInterrupts();
unsigned int county = counter;
interrupts();

  if (counter>2000){county=0;}
  temp = counter;
  
  Serial.println(county); // Encoder step counter
  
}

  void ai0() {if(digitalRead(3)==LOW) {counter++;}else{counter--;}}
  void ai1() {if(digitalRead(2)==LOW) {counter--;}else{counter++;}}

volatile unsigned int temp, counter = 0; 
int county=0; 
void setup()
{
  
  Serial.begin(9600);   
  pinMode(2, INPUT_PULLUP); 
  pinMode(3, INPUT_PULLUP); 
  attachInterrupt(0, ai0, RISING);
  attachInterrupt(1, ai1, RISING);  
}
 
void loop()
{
  county= (counter);
  if (counter>2000){
county=0;
  }
  temp = counter;
  
  Serial.println(county); // Encoder step counter
  
}

  void ai0() {if(digitalRead(3)==LOW) {counter++;}else{counter--;}}
  void ai1() {if(digitalRead(2)==LOW) {counter--;}else{counter++;}}

Dear all, above arduino code is used for encoder as counter and code is quoted from here, the above simple code works fine. However, if I were to add some code lines below the Serial.println(county);which actually delays execution time, the counter will actually skip steps and mess up the counter which I am very dissapointed.

May I ask how to solve this issue, my thought is can arduino actually run 2 void loop simultaneously so that the counter code can be run simultaneously and not be affected by other code lines which introduces delay time that mess up the counter. Any help will be appreciated :)

volatile unsigned int temp, counter = 0; 
void setup()
{
  
  Serial.begin(9600);   pinMode(2, INPUT_PULLUP); pinMode(3, INPUT_PULLUP); attachInterrupt(0, ai0, RISING);attachInterrupt(1, ai1, RISING);  
}
 
void loop()
{
noInterrupts();
unsigned int county = counter;
interrupts();

  if (counter>2000){county=0;}
  temp = counter;
  
  Serial.println(county); // Encoder step counter
  
}

  void ai0() {if(digitalRead(3)==LOW) {counter++;}else{counter--;}}
  void ai1() {if(digitalRead(2)==LOW) {counter--;}else{counter++;}}

volatile unsigned int temp, counter = 0; 
int county=0; 
void setup()
{
  
  Serial.begin(9600);   
  pinMode(2, INPUT_PULLUP); 
  pinMode(3, INPUT_PULLUP); 
  attachInterrupt(0, ai0, RISING);
  attachInterrupt(1, ai1, RISING);  
}
 
void loop()
{
  county= (counter);
  if (counter>2000){
county=0;
  }
  temp = counter;
  
  Serial.println(county); // Encoder step counter
  
}

  void ai0() {if(digitalRead(3)==LOW) {counter++;}else{counter--;}}
  void ai1() {if(digitalRead(2)==LOW) {counter--;}else{counter++;}}

Dear all, above arduino code is used for encoder as counter and code is quoted from here, the above simple code works fine. However, if I were to add some code lines below the Serial.println(county);which actually delays execution time, the counter will actually skip steps and mess up the counter which I am very dissapointed.

May I ask how to solve this issue, my thought is can arduino actually run 2 void loop simultaneously so that the counter code can be run simultaneously and not be affected by other code lines which introduces delay time that mess up the counter. Any help will be appreciated :)

volatile unsigned int temp, counter = 0; 
void setup()
{
  
  Serial.begin(9600);   pinMode(2, INPUT_PULLUP); pinMode(3, INPUT_PULLUP); attachInterrupt(0, ai0, RISING);attachInterrupt(1, ai1, RISING);  
}
 
void loop()
{
noInterrupts();
unsigned int county = counter;
interrupts();

  if (counter>2000){county=0;}
  
  Serial.println(county); // Encoder step counter
  
}

  void ai0() {if(digitalRead(3)==LOW) {counter++;}else{counter--;}}
  void ai1() {if(digitalRead(2)==LOW) {counter--;}else{counter++;}}

deleted 20 characters in body

Source Link

edited Dec 5, 2022 at 15:37

Maximus Su

11
3

Loading

deleted 117 characters in body

Source Link

edited Dec 5, 2022 at 15:36

Maximus Su

11
3

Loading

added 807 characters in body

Source Link

edited Dec 5, 2022 at 11:09

Maximus Su

11
3

Loading

Source Link

asked Dec 5, 2022 at 10:04

Maximus Su

11
3

Loading

Stack Exchange Network

Return to Question