Skip to main content
Code Review

Return to Question

Added what seems to be suitable tags
Link
edit approved Jul 14, 2013 at 23:17
Xotic750
edit approved Jul 14, 2013 at 23:17
Xotic750
  • 635
  • 6
  • 15
Fixed some grammar and put the output into a blockquote
Source Link
edit approved Jul 9, 2013 at 21:40
Jamal
edit approved Jul 9, 2013 at 21:40
Jamal
  • 35.2k
  • 13
  • 134
  • 238

I started learning JavaScript a week ago, and iI made a sorting function on my own. It does work, but iI need reviews and how to write a better one.

<body>
<ul id="list">
    <li>Art</li>
    <li>Mobile</li>
    <li>Education</li>
    <li>Games</li>
    <li>Magazines</li>
    <li>Sports</li>
</ul>

var list = document.getElementById("list");
var myList = list.getElementsByTagName("li");
var a = [];
for (var i = 0; i < myList.length; i++) {
    a[i] = myList[i].innerHTML;
}
a.sort();
for (var i = 0; i < myList.length; i++) {
    myList[i].innerHTML = a[i];
}

Output:

  • Art
  • Education
  • Games
  • Magazines
  • Mobile
  • Sports
  • Art
  • Education
  • Games
  • Magazines
  • Mobile
  • Sports

I started learning JavaScript a week ago and i made a sorting function on my own. It does work but i need reviews and how to write a better one.

<body>
<ul id="list">
    <li>Art</li>
    <li>Mobile</li>
    <li>Education</li>
    <li>Games</li>
    <li>Magazines</li>
    <li>Sports</li>
</ul>

var list = document.getElementById("list");
var myList = list.getElementsByTagName("li");
var a = [];
for (var i = 0; i < myList.length; i++) {
    a[i] = myList[i].innerHTML;
}
a.sort();
for (var i = 0; i < myList.length; i++) {
    myList[i].innerHTML = a[i];
}

Output:

  • Art
  • Education
  • Games
  • Magazines
  • Mobile
  • Sports

I started learning JavaScript a week ago, and I made a sorting function on my own. It does work, but I need reviews and how to write a better one.

<body>
<ul id="list">
    <li>Art</li>
    <li>Mobile</li>
    <li>Education</li>
    <li>Games</li>
    <li>Magazines</li>
    <li>Sports</li>
</ul>

var list = document.getElementById("list");
var myList = list.getElementsByTagName("li");
var a = [];
for (var i = 0; i < myList.length; i++) {
    a[i] = myList[i].innerHTML;
}
a.sort();
for (var i = 0; i < myList.length; i++) {
    myList[i].innerHTML = a[i];
}

Output:

  • Art
  • Education
  • Games
  • Magazines
  • Mobile
  • Sports
Source Link
onefourth
onefourth
  • 41
  • 1
  • 3

My first javascript sorting

I started learning JavaScript a week ago and i made a sorting function on my own. It does work but i need reviews and how to write a better one.

<body>
<ul id="list">
    <li>Art</li>
    <li>Mobile</li>
    <li>Education</li>
    <li>Games</li>
    <li>Magazines</li>
    <li>Sports</li>
</ul>

var list = document.getElementById("list");
var myList = list.getElementsByTagName("li");
var a = [];
for (var i = 0; i < myList.length; i++) {
    a[i] = myList[i].innerHTML;
}
a.sort();
for (var i = 0; i < myList.length; i++) {
    myList[i].innerHTML = a[i];
}

Output:

  • Art
  • Education
  • Games
  • Magazines
  • Mobile
  • Sports