Some notes:
url_replace( '/news' ): Each language has its formatting rules. In Ruby almost nobody puts thoseinserts spaces after and before parens.hash = args.last.kind_of?(Hash) && args.last: I'd strongly discourage this kind of positional arguments, the method signature is severely impaired. Use an options hash instead (note that Ruby 2.0 finally provides keyword arguments).query.delete(k.to_s). If you check my other answers you'll see I tend to favour functional programming, so I'd rewrite this using expressions instead of statements. Code is much more clean when they say what things are instead of how you change their value.- Uses of
args.firstin the middle of the code: Strive for declarative code, give names to things before you use them when it's not clear what they are. - I'd admitaccept only strings as keys for the query string, or, if Activesupport is at hand, I'd call
stringify_keysorHash[h.map { |k, v| [k.to_s, v] }]at some point. This way I'd avoid mixing symbols and strings.
I'd write:
require 'uri'
require 'cgi'
def url_replace(url, options = {})
uri = URI.parse(URI.encode(url))
hquery = CGI::parse(uri.query)
components = Hash[uri.component.map { |key| [key, uri.send(key)] }]
new_hquery = hquery.merge(options[:merge_query] || {}).select { |k, v| v }
new_query = URI.encode_www_form(new_hquery)
new_components = {path: options[:path] || uri.path, query: new_query}
new_uri = URI::Generic.build(components.merge(new_components))
URI.decode(new_uri.to_s)
end
puts url_replace('/news?a=b&c=d', path: '/bar', merge_query: {"c" => nil})
#=> /bar?a=b