Skip to main content
Code Review

Return to Question

improved formatting
Source Link
palacsint
palacsint
  • 30.4k
  • 9
  • 82
  • 157
  1. remove line with "package";package;
  2. change lines with "import" import (delete the importimport keyword, whitespaces, semicolon at the end) and add stripped packages with the Factory'sFactory's method addImport(line)addImport(line);
  3. change "Preloadable"Preloadable to "Generated"Generated
  4. copy other lines without changes with the SourceWriter'sSourceWriter's method sw.println(line)sw.println(line)

The one more notice is that I can't use SourceWriterSourceWriter method sw.println(line)sw.println(line) before Factrory factory.addImport(line)Factrory factory.addImport(line);

My most worries are about calling line.contains("pattern")line.contains("pattern") in whilewhile-loooploop. As I know "pattern""pattern" will be compiled to Java regex Pattern.classPattern.class. I'm aware it's not good to compile the same PatternPattern over and over till the loop ends, but don't know how to do this better. Also I doubt about this line (to strip "import"import lines)

line = line.substring(index + 6, line.lastIndexOf(";")).trim();

line = line.substring(index + 6, line.lastIndexOf(";")).trim();
  1. remove line with "package";
  2. change lines with "import" (delete the import keyword, whitespaces, semicolon at the end) and add stripped packages with the Factory's method addImport(line);
  3. change "Preloadable" to "Generated"
  4. copy other lines without changes with the SourceWriter's method sw.println(line)

The one more notice is that I can't use SourceWriter method sw.println(line) before Factrory factory.addImport(line);

My most worries are about calling line.contains("pattern") in while-looop. As I know "pattern" will be compiled to Java regex Pattern.class. I'm aware it's not good to compile the same Pattern over and over till the loop ends, but don't know how to do this better. Also I doubt about this line (to strip "import" lines)

line = line.substring(index + 6, line.lastIndexOf(";")).trim();

  1. remove line with package;
  2. change lines with import (delete the import keyword, whitespaces, semicolon at the end) and add stripped packages with the Factory's method addImport(line);
  3. change Preloadable to Generated
  4. copy other lines without changes with the SourceWriter's method sw.println(line)

The one more notice is that I can't use SourceWriter method sw.println(line) before Factrory factory.addImport(line);

My most worries are about calling line.contains("pattern") in while-loop. As I know "pattern" will be compiled to Java regex Pattern.class. I'm aware it's not good to compile the same Pattern over and over till the loop ends, but don't know how to do this better. Also I doubt about this line (to strip import lines)

line = line.substring(index + 6, line.lastIndexOf(";")).trim();
Tweeted twitter.com/#!/StackCodeReview/status/91440352065634304
added 19 characters in body
Source Link
trupanka
trupanka
  • 183
  • 5

I have a bunch of simple interfaces like this one (pretty enough formed, but not guarantee)

I have a bunch of simple interfaces like this one (pretty enough formed)

I have a bunch of simple interfaces like this one (pretty enough formed, but not guarantee)

Source Link
trupanka
trupanka
  • 183
  • 5

Parse Java source code

I have a bunch of simple interfaces like this one (pretty enough formed)

package com.example.sources;

import com.google.gwt.resources.client.ClientBundle;
import com.google.gwt.resources.client.ImageResource;
import com.google.gwt.resources.client.ImageResource.ImageOptions;
import com.google.gwt.resources.client.ImageResource.RepeatStyle;

import com.example.sources.MainSceneResource;
import com.example.sources.Preloadable;

public interface MainSceneResources extends ClientBundle, Preloadable {

    @Source("com/example/sources/css/mainscene.css")
    public MainSceneResource mainSceneCss();

    @Source("com/example/sources/img/panorama.jpg")
    @ImageOptions(repeatStyle = RepeatStyle.None)
    public ImageResource mainSceneBackground();

}

I need to:

  1. remove line with "package";
  2. change lines with "import" (delete the import keyword, whitespaces, semicolon at the end) and add stripped packages with the Factory's method addImport(line);
  3. change "Preloadable" to "Generated"
  4. copy other lines without changes with the SourceWriter's method sw.println(line)

Currently my code is like:

BufferedReader reader = new BufferedReader(new InputStreamReader(ris));

String line = null;
try {
    while ((line = reader.readLine()) != null) {
        if (line.contains("package") || line.isEmpty()) {
            continue;
            }
        int index = line.indexOf("import");
        if (index != -1) {
            line = line.substring(index + 6, line.lastIndexOf(";")).trim();
            factory.addImport(line);
            continue;
        }
        if (line.contains("Preloadable")) {
            line = line.replace("Preloadable", "Generated");
        }
        sw.println(line);
    }
} catch (IOException e) {
    throw new UnableToCompleteException();
}

The one more notice is that I can't use SourceWriter method sw.println(line) before Factrory factory.addImport(line);

My most worries are about calling line.contains("pattern") in while-looop. As I know "pattern" will be compiled to Java regex Pattern.class. I'm aware it's not good to compile the same Pattern over and over till the loop ends, but don't know how to do this better. Also I doubt about this line (to strip "import" lines)

line = line.substring(index + 6, line.lastIndexOf(";")).trim();

Is there a better way to do this?