Skip to main content
Code Review

Return to Answer

added 66 characters in body
Source Link
user1703394
user1703394
  • 237
  • 1
  • 7

I think you should probably add a few destructors (think RAIIRAII) so both the open socket and the listening sockets always get properly closed.

Oh, and while Jerry's comments are pretty good, ignore the one about using

this->

Its not 'noise', its actually a good practice according to several coding guidelines I've worked with. Your compiler doesn't need it, but it does make your code more readable to other project members.

I think you should probably add a few destructors (think RAII) so both the open socket and the listening sockets always get properly closed.

Oh, and while Jerry's comments are pretty good, ignore the one about using

this->

Its not 'noise', its actually a good practice according to several coding guidelines I've worked with. Your compiler doesn't need it, but it does make your code more readable to other project members.

I think you should probably add a few destructors (think RAII) so both the open socket and the listening sockets always get properly closed.

Oh, and while Jerry's comments are pretty good, ignore the one about using

this->

Its not 'noise', its actually a good practice according to several coding guidelines I've worked with. Your compiler doesn't need it, but it does make your code more readable to other project members.

Source Link
user1703394
user1703394
  • 237
  • 1
  • 7

I think you should probably add a few destructors (think RAII) so both the open socket and the listening sockets always get properly closed.

Oh, and while Jerry's comments are pretty good, ignore the one about using

this->

Its not 'noise', its actually a good practice according to several coding guidelines I've worked with. Your compiler doesn't need it, but it does make your code more readable to other project members.