Revisions to Application for converting markdown to PDF

Tweeted twitter.com/#!/StackCodeReview/status/541071353341034496

occurred Dec 6, 2014 at 3:27

Rollback to Revision 4

Source Link

edited Nov 30, 2014 at 5:59

145.7k
22
191
481

Edit

Thank you for your suggestions. I have updated the code to reflect most suggestions I got. The latest code (at the time of writing).

The messy main method now looks like this:

/* Main logic */
read_markdown(ib, number_of_sources, file, in);
render_markdown(ib, ob);
write_html_to_tmp_file(tmp_html_file_path, tmp_html_file_protocol_path, ob, verbose, stylesheet_file_path);
generate_pdf(tmp_html_file_protocol_path, output_pdf_file_path);

/* Cleanup */
unlink(tmp_html_file_path);
return EXIT_SUCCESS;

I would say it's a great improvement.

Edit

Thank you for your suggestions. I have updated the code to reflect most suggestions I got. The latest code (at the time of writing).

The messy main method now looks like this:

/* Main logic */
read_markdown(ib, number_of_sources, file, in);
render_markdown(ib, ob);
write_html_to_tmp_file(tmp_html_file_path, tmp_html_file_protocol_path, ob, verbose, stylesheet_file_path);
generate_pdf(tmp_html_file_protocol_path, output_pdf_file_path);

/* Cleanup */
unlink(tmp_html_file_path);
return EXIT_SUCCESS;

I would say it's a great improvement.

Add information about the solution

Source Link

edited Nov 30, 2014 at 5:58

Fredrik Wallgren

223
1
6

Edit

Thank you for your suggestions. I have updated the code to reflect most suggestions I got. The latest code (at the time of writing).

The messy main method now looks like this:

/* Main logic */
read_markdown(ib, number_of_sources, file, in);
render_markdown(ib, ob);
write_html_to_tmp_file(tmp_html_file_path, tmp_html_file_protocol_path, ob, verbose, stylesheet_file_path);
generate_pdf(tmp_html_file_protocol_path, output_pdf_file_path);

/* Cleanup */
unlink(tmp_html_file_path);
return EXIT_SUCCESS;

I would say it's a great improvement.

Edit

Thank you for your suggestions. I have updated the code to reflect most suggestions I got. The latest code (at the time of writing).

The messy main method now looks like this:

/* Main logic */
read_markdown(ib, number_of_sources, file, in);
render_markdown(ib, ob);
write_html_to_tmp_file(tmp_html_file_path, tmp_html_file_protocol_path, ob, verbose, stylesheet_file_path);
generate_pdf(tmp_html_file_protocol_path, output_pdf_file_path);

/* Cleanup */
unlink(tmp_html_file_path);
return EXIT_SUCCESS;

I would say it's a great improvement.

edited tags

Link

edited Nov 30, 2014 at 2:58

syb0rg

21.9k
10
113
193

deleted 122 characters in body

Source Link

edited Nov 30, 2014 at 2:13

Jamal

35.2k
13
134
238

Loading

Added code to the post, instead of just linking to it.

Source Link

edited Nov 29, 2014 at 23:48

Fredrik Wallgren

223
1
6

Loading

Source Link

asked Nov 29, 2014 at 23:40

Fredrik Wallgren

223
1
6

Loading

Stack Exchange Network

Return to Question

Edit

Edit

Edit

Edit