Return to Answer

• How to close a Java Swing application from the code
• This answer also helpful

• How to close a Java Swing application from the code
• This answer also helpful

“// …” comments at end of code block after } - good or bad?

“// …” comments at end of code block after } - good or bad?

8. The disableButtonBool parameter of the toggleButton does nothing with the state of the button. I'd remove this parameter.

    public final boolean toggleButton(final JButton buttonDisable, boolean disableButtonBool) {
        buttonDisable.setEnabled(!buttonDisable.isEnabled()); // Swap button
                                                              // state
        if (disableButtonBool) {
            disableButtonBool = false;
        } else {
            disableButtonBool = true;
        }
        return disableButtonBool;// return Bool
    }// //End ToggleButton method
   

9. I'd create a ToggleButton class which would be a subclass of JButton for the toggle() method:

    public class ToggleButton extends JButton {
        private static final long serialVersionUID = 1L;
   
        public ToggleButton(String text) {
            super(text);
        }
   
        public boolean toggle() {
            final boolean newState = !isEnabled();
            setEnabled(newState);
            return newState;
        }
    }
   

It increases cohesion.

11. I'm not too familiar with Swing, but I think there should be a better way to stop the application than calling System.exit():

    quitButton.addActionListener(new ActionListener() {
        @Override
        public void actionPerformed(final ActionEvent event) {
            System.exit(0);
        }
    });
    

How to close a Java Swing application from the code

8. The disableButtonBool parameter of the toggleButton does nothing with the state of the button. I'd remove this parameter.

    public final boolean toggleButton(final JButton buttonDisable, boolean disableButtonBool) {
        buttonDisable.setEnabled(!buttonDisable.isEnabled()); // Swap button
                                                              // state
        if (disableButtonBool) {
            disableButtonBool = false;
        } else {
            disableButtonBool = true;
        }
        return disableButtonBool;// return Bool
    }// //End ToggleButton method
   

9. I'd move the toggle method a ToggleButton class (which would be a subclass of JButton):

    public class ToggleButton extends JButton {
        private static final long serialVersionUID = 1L;
   
        public ToggleButton(String text) {
            super(text);
        }
   
        public boolean toggle() {
            final boolean newState = !isEnabled();
            setEnabled(newState);
            return newState;
        }
    }
   

Then I'd use this class in the MoreSwing class:

    private final ToggleButton nextButton = new ToggleButton("Next");
    private final ToggleButton prevButton = new ToggleButton("Previous");

The toggle method belongs here, it manipulates the state of the button. (It increases cohesion.)

12. I'm not too familiar with Swing, but I think there should be a better way to stop the application than calling System.exit():

    quitButton.addActionListener(new ActionListener() {
        @Override
        public void actionPerformed(final ActionEvent event) {
            System.exit(0);
        }
    });
    

• How to close a Java Swing application from the code
• This answer also helpful

13. I'd use JAXB for the XML processing.