Skip to main content
Rollback to Revision 4
Source Link
Jamal
  • 35.2k
  • 13
  • 134
  • 238

Thanks for the detailed replies, will take some time to read up, absorb and apply changes:

Implementing suggested code changes 1:

structs are now classes & made friends, no change to main, but getting errors:

enter image description here

I want to know why friends is not working, ....but, also wondering if using class get functions to retrieve private class data might not be simpler/tidier?

Maybe I'm doing it wrong, but:

virtual ~List() {
    while (begins->next != begins) {
        begins->prev = begins->next;
        begins->next = begins->next->next;
        delete begins->prev;
    }
    delete begins;
}

Will begins->next ever == begins ? ..at any rate it throws an access violation error when reading location.

Maybe you meant something like?

virtual ~List() {
        while (begins->next != ends) {
            begins->prev = begins->next;
            begins->next = begins->next->next;
            delete begins->prev;
       }
 delete begins;
 delete ends;
}

Thanks for the detailed replies, will take some time to read up, absorb and apply changes:

Implementing suggested code changes 1:

structs are now classes & made friends, no change to main, but getting errors:

enter image description here

I want to know why friends is not working, ....but, also wondering if using class get functions to retrieve private class data might not be simpler/tidier?

Maybe I'm doing it wrong, but:

virtual ~List() {
    while (begins->next != begins) {
        begins->prev = begins->next;
        begins->next = begins->next->next;
        delete begins->prev;
    }
    delete begins;
}

Will begins->next ever == begins ? ..at any rate it throws an access violation error when reading location.

Maybe you meant something like?

virtual ~List() {
        while (begins->next != ends) {
            begins->prev = begins->next;
            begins->next = begins->next->next;
            delete begins->prev;
       }
 delete begins;
 delete ends;
}
clarify answer
Source Link
tuk
  • 153
  • 1
  • 7

Thanks for the detailed replies, will take some time to read up, absorb and apply changes:

Implementing suggested code changes 1:

structs are now classes & made friends, no change to main, but getting errors:

enter image description here

I want to know why friends is not working, ....but, also wondering if using class get functions to retrieve private class data might not be simpler/tidier?

Maybe I'm doing it wrong, but:

virtual ~List() {
    while (begins->next != begins) {
        begins->prev = begins->next;
        begins->next = begins->next->next;
        delete begins->prev;
    }
    delete begins;
}

Will begins->next ever == begins ? ..at any rate it throws an access violation error when reading location.

Maybe you meant something like?

virtual ~List() {
        while (begins->next != ends) {
            begins->prev = begins->next;
            begins->next = begins->next->next;
            delete begins->prev;
       }
 delete begins;
 delete ends;
}

Thanks for the detailed replies, will take some time to read up, absorb and apply changes:

Implementing suggested code changes 1:

structs are now classes & made friends, no change to main, but getting errors:

enter image description here

I want to know why friends is not working, ....but, also wondering if using class get functions to retrieve private class data might not be simpler/tidier?

Maybe I'm doing it wrong, but:

virtual ~List() {
    while (begins->next != begins) {
        begins->prev = begins->next;
        begins->next = begins->next->next;
        delete begins->prev;
    }
    delete begins;
}

Will begins->next ever == begins ? ..at any rate it throws an access violation error when reading location.

Maybe you meant something like?

virtual ~List() {
        while (begins->next != ends) {
            begins->prev = begins->next;
            begins->next = begins->next->next;
            delete begins->prev;
       }
 delete begins;
 delete ends;
}
edited tags
Link
200_success
  • 145.7k
  • 22
  • 191
  • 481
added 8 characters in body
Source Link
Jamal
  • 35.2k
  • 13
  • 134
  • 238
Loading
copy edit, improve formatting
Source Link
Snowbody
  • 8.7k
  • 25
  • 50
Loading
Source Link
tuk
  • 153
  • 1
  • 7
Loading