Revisions to vba tag wiki - Code Review Stack Exchange

removed not-needed Hungarian notation from Hello World sample, made procedure explicitly public

Source Link

edited Aug 24, 2018 at 20:57

75.6k
18
195
469

Public Sub HelloWorld()
  Dim strMessagemessage As String
  strMessagemessage = "Hello World"
  MsgBox strMessagemessage
  Debug.Print "I just made a message box that says """ & strMessagemessage & """!"
End Sub

Sub HelloWorld()
  Dim strMessage As String
  strMessage = "Hello World"
  MsgBox strMessage
  Debug.Print "I just made a message box that says """ & strMessage & """!"
End Sub

Public Sub HelloWorld()
  Dim message As String
  message = "Hello World"
  MsgBox message
  Debug.Print "I just made a message box that says """ & message & """!"
End Sub

added 1206 characters in body; added 8 characters in body; deleted 2 characters in body

Source Link

edited Jul 6, 2018 at 17:30

Mathieu Guindon

75.6k
18
195
469

"not responding" isn't broken code

If you're reviewing a VBA question, please don't downvote and/or vote to close VBA questions on the basis of "broken code" or "not working as intended" when the OP mentions the host application going unresponsive. Most VBA hosts run VBA code on the main/UI thread, so it's perfectly normal that a long-running VBA macro makes the host application's main window caption say "(not responding)". In that state, the VBA code is running, and the host application is no longer handling Windows messages; clicking on the main window causes the screen to "white-out", which an inexperienced VBA coder may easily misinterpret as "Excel freezing", when in reality Excel is just busy running the OP's code. Responsiveness resumes when the code completes.

If you're asking a VBA question, please avoid wording this unresponsive state in such a way that could be interpreted as a bug in your code: avoid terms like "freezes" or "crashes" in your post (crashing code is off-topic) - if Excel is just not reaponding and your code eventually completes, your question is perfectly on-topic and probably just needs performance tuning... And you're on the right site for this.