Skip to main content
17 events
when toggle format what by license comment
Apr 13, 2017 at 12:41 history edited CommunityBot
replaced http://codereview.stackexchange.com/ with https://codereview.stackexchange.com/
Mar 20, 2017 at 10:29 history edited CommunityBot
replaced http://meta.stackexchange.com/ with https://meta.stackexchange.com/
Apr 23, 2014 at 13:45 history edited CommunityBot
Fixup of bad MSO links to MSE links migration
Apr 23, 2014 at 8:53 history edited CommunityBot
Migration of MSO links to MSE links
Dec 20, 2013 at 1:40 comment added 200_success I've added guidelines to the tag wiki.
Dec 19, 2013 at 18:51 comment added Daniel @Cruncher To me it's too opinion based when you pose a question like: Should I do A or B? This automatically biases the reader into thinking A vs B, and not even considering C. If you simply showed us what you did (choosing A for example), you may get suggestions to do B or C or D etc. Upvotes would help you to determine which suggestion is more universally liked (obviously you still choose your favorite). By suggesting opinions you expect you're limiting the usefulness of a code review question before it's even submitted and increasing the chance of a "holy war".
Dec 19, 2013 at 13:56 comment added Cruncher @SimonAndréForsberg Okay. But now you see the problem. When you say "this is too opinion-based" and "this is just opinion-based enough" you create a slippery slope. The line seems difficult to accurately define. Sure you can show extreme cases like you did where it's obvious. But there are cases on the line. Which is what brought up this discussion to begin with. To digress: I think this question should have gone through the community queues rather than a moderator taking action to close it.
Dec 19, 2013 at 13:51 comment added Simon Forsberg @Cruncher Absolutely. One of the foundations about performing a Code Review is that it is supposed to be opinion based. However, there are some holy wars in programming which is simply too much based on opinion, where there is no consensus about "what is right, what is wrong".
Dec 19, 2013 at 13:47 comment added Cruncher @SimonAndréForsberg This site is opinion-based though. To quote Jeff Atwood: "In other words, general broad-spectrum subjective feedback about blocks of code you've written."
Dec 18, 2013 at 22:24 comment added Simon Forsberg @Cruncher Probably because it isn't clear enough what our policy is regarding this. I was skeptical to the question at first, but I wanted to wait and see. Unfortunately, I think many questions similar to your original question will end up in "conventions holy wars". It's just too much opinion based sometimes.
Dec 18, 2013 at 21:54 comment added Cruncher @SimonAndréForsberg Well, to be fair, it took a moderator to raise attention that it was off-topic. The community seemed to be favourable of it until then.
Dec 18, 2013 at 18:45 comment added Simon Forsberg @DanielCook I believe that most people who are here knows what the site is for (thankfully), but of course, every now and then someone comes along which has one idea about what the site is about and then learns about the truth the hard way.
Dec 18, 2013 at 18:39 comment added Daniel I've been thinking about specifically asking a question about "which is better" or "A vs B" questions for a while. I feel like most of them are off topic, but they also tend to lure in a lot of site traffic, answers, and lots of upvotes. If upvotes + answers = on topic then I may be wrong. But maybe most people who use the site don't know what it's for?
Dec 18, 2013 at 17:33 comment added Mathieu Guindon As Jeff Atwood quoted: "Does this code make my ass look fat?" is what CR is all about :)
Dec 18, 2013 at 17:16 comment added Simon Forsberg @Cruncher Yes, that's my opinion. I think you should keep it (more or less) in the form: "This is my code, this if-statement feels ugly to me, can I do this better?", and not in the form "This is my code, but I was thinking about doing this instead, which one is better?". However, this is just my opinion.
Dec 18, 2013 at 17:04 comment added Cruncher To be clear, is it your opinion that if I posted the actual bit of code, rather than fake variable names and a commented out block then it would be on-topic?
Dec 18, 2013 at 16:25 history answered Simon Forsberg CC BY-SA 3.0