Skip to main content
Commonmark migration
Source Link

This question is intended to be the counterpart of Checklist for how to write a good Code Review question.

###Getting started with Code Review:

Getting started with Code Review:

New users often seem to have problems to understand, what exactly is expected from a CR-Answer. Many come from Stack Overflow, others maybe from Software Engineering.

These sites favor a different kind of answer than Code Review. I'd suggest providing a guideline or even checklist for new users on how we like our answers best ;)

Some of the most common "mistakes" that new users make:

  1. SO-ish flavoring: alternative code (mostly without explanation)
  2. Software Engineering flavoring: much much explanation, but missing relation to the code at hand.
  3. Trying to go over every Issue in code and then resign over the sheer amount. --> no answer posted
  4. Only "reviewing" the algorithm and not the style (probably also coming from SO), and not posting an answer, because no optimization can be found :(

There already has been a question on what makes a good answer. There was only one answer to that. The problem I have with that answer is, that it only states what a good answer has and not how to write an answer so it becomes good ;)

This question is intended to be the counterpart of Checklist for how to write a good Code Review question.

###Getting started with Code Review:

New users often seem to have problems to understand, what exactly is expected from a CR-Answer. Many come from Stack Overflow, others maybe from Software Engineering.

These sites favor a different kind of answer than Code Review. I'd suggest providing a guideline or even checklist for new users on how we like our answers best ;)

Some of the most common "mistakes" that new users make:

  1. SO-ish flavoring: alternative code (mostly without explanation)
  2. Software Engineering flavoring: much much explanation, but missing relation to the code at hand.
  3. Trying to go over every Issue in code and then resign over the sheer amount. --> no answer posted
  4. Only "reviewing" the algorithm and not the style (probably also coming from SO), and not posting an answer, because no optimization can be found :(

There already has been a question on what makes a good answer. There was only one answer to that. The problem I have with that answer is, that it only states what a good answer has and not how to write an answer so it becomes good ;)

This question is intended to be the counterpart of Checklist for how to write a good Code Review question.

Getting started with Code Review:

New users often seem to have problems to understand, what exactly is expected from a CR-Answer. Many come from Stack Overflow, others maybe from Software Engineering.

These sites favor a different kind of answer than Code Review. I'd suggest providing a guideline or even checklist for new users on how we like our answers best ;)

Some of the most common "mistakes" that new users make:

  1. SO-ish flavoring: alternative code (mostly without explanation)
  2. Software Engineering flavoring: much much explanation, but missing relation to the code at hand.
  3. Trying to go over every Issue in code and then resign over the sheer amount. --> no answer posted
  4. Only "reviewing" the algorithm and not the style (probably also coming from SO), and not posting an answer, because no optimization can be found :(

There already has been a question on what makes a good answer. There was only one answer to that. The problem I have with that answer is, that it only states what a good answer has and not how to write an answer so it becomes good ;)

"Programmers".SE was renamed.
Source Link
Toby Speight
  • 88.7k
  • 16
  • 34

This question is intended to be the counterpart of: Checklist for how to write a good Code Review questionChecklist for how to write a good Code Review question.

###Getting started with Code Review:

New users often seem to have problems to understand, what exactly is expected from a CR-Answer. Many come from Stack Overflow, others maybe from ProgrammersSoftware Engineering.

These sites favor a different kind of answer than Code Review. I'd suggest providing a guideline or even checklist for new users on how we like our answers best ;)

Some of the most common "mistakes" that new users make:

  1. SO-ish flavoring: alternative code (mostly without explanation)
  2. ProgrammersSoftware Engineering flavoring: much much explanation, but missing relation to the code at hand.
  3. Trying to go over every Issue in code and then resignateresign over the sheer amount. --> no answer posted
  4. Only "reviewing" the algorithm and not the style (probably also coming from SO), and not posting an answer, because no optimization can be found :(

There already has been a question on what makes a good answerquestion on what makes a good answer. There was only one answer to that.only one answer to that. The problem I have with that answer is, that it only states what a good answer has and not how to write an answer so it becomes good ;)

This question is intended to be the counterpart of: Checklist for how to write a good Code Review question

###Getting started with Code Review:

New users often seem to have problems to understand, what exactly is expected from a CR-Answer. Many come from Stack Overflow, others maybe from Programmers.

These sites favor a different kind of answer than Code Review. I'd suggest providing a guideline or even checklist for new users on how we like our answers best ;)

Some of the most common "mistakes" that new users make:

  1. SO-ish flavoring: alternative code (mostly without explanation)
  2. Programmers flavoring: much much explanation, but missing relation to the code at hand.
  3. Trying to go over every Issue in code and then resignate over the sheer amount. --> no answer posted
  4. Only "reviewing" the algorithm and not the style (probably also coming from SO), and not posting an answer, because no optimization can be found :(

There already has been a question on what makes a good answer. There was only one answer to that. The problem I have with that answer is, that it only states what a good answer has and not how to write an answer so it becomes good ;)

This question is intended to be the counterpart of Checklist for how to write a good Code Review question.

###Getting started with Code Review:

New users often seem to have problems to understand, what exactly is expected from a CR-Answer. Many come from Stack Overflow, others maybe from Software Engineering.

These sites favor a different kind of answer than Code Review. I'd suggest providing a guideline or even checklist for new users on how we like our answers best ;)

Some of the most common "mistakes" that new users make:

  1. SO-ish flavoring: alternative code (mostly without explanation)
  2. Software Engineering flavoring: much much explanation, but missing relation to the code at hand.
  3. Trying to go over every Issue in code and then resign over the sheer amount. --> no answer posted
  4. Only "reviewing" the algorithm and not the style (probably also coming from SO), and not posting an answer, because no optimization can be found :(

There already has been a question on what makes a good answer. There was only one answer to that. The problem I have with that answer is, that it only states what a good answer has and not how to write an answer so it becomes good ;)

replaced http://meta.codereview.stackexchange.com/ with https://codereview.meta.stackexchange.com/
Source Link
replaced http://meta.codereview.stackexchange.com/ with https://codereview.meta.stackexchange.com/
Source Link
Loading
replaced http://meta.codereview.stackexchange.com/ with https://codereview.meta.stackexchange.com/
Source Link
Loading
added 3 characters in body; edited title
Source Link
Jamal Mod
  • 35.2k
  • 2
  • 54
  • 106
Loading
clarified "mistakes"
Source Link
Vogel612
  • 25.5k
  • 1
  • 38
  • 64
Loading
Source Link
Vogel612
  • 25.5k
  • 1
  • 38
  • 64
Loading