A question that asks:
I don't know how to best solve problem X, can you suggest a way?
... is clearly off-topic on Code Review.
A question that asks:
I have solved problem X, and this is how I did it. Is it a good solution?
... is clearly on-topic on Code Review.
There is a grey area in between that is hard to define. There must be a line somewhere. Where is that line?
For example, questions that ask:
- I have solved problem X this way and here's my code, but I know there must be a better way! How would you do it?I have solved problem X this way and here's my code, but I know there must be a better way! How would you do it?
- I have solved problem X but it runs slowly, and I suspect that I am not using the right tools and APIs. How do I speed it up?I have solved problem X but it runs slowly, and I suspect that I am not using the right tools and APIs. How do I speed it up?
- I want to build a library of utilities, this is my current API and protocol. Is it good?I want to build a library of utilities, this is my current API and protocol. Is it good?
- I am designing an interface for some code. This is what I have. I want it to be able to support functionality X and Y. Will this interface allow that?I am designing an interface for some code. This is what I have. I want it to be able to support functionality X and Y. Will this interface allow that?
... are they on topic, or off topic? Which ones? Why?
Feel free to drop by in this chat room Code Review - Discussion about Help vs. Review if you want to discuss these questions, other questions like this, or just to say "Hi!"
Before answering this question, please read all the above links, and understand some of the background on this problem. Feel free to add comments to the above (and this) questions, and get clarification about other issues in the discussion chat room.
