Skip to main content
replaced http://codereview.stackexchange.com/ with https://codereview.stackexchange.com/
Source Link

A bit of a situation for a review of this answerthis answer where I didn't know what the best action was. The answer has good intentions but could be improved by elaborating what the changes mean and why they are an improvement of the code. This way the OP can understand why this is an improvement.

Thus, I commented this on the answer but afterwards I wanted to click the I'm done button and realised that it doesn't exist there. The other options are not actualy an option:

  • Looks OK: no, because elaboration is needed
  • Edit: no, because I don't know the intention/knowledge of the author
  • Recommend deletion: no, a bit harsh for an answer that could be a good one
  • Skip: no, I took action and thus did not skip it

I now chose Skip as I'm not going to wait for answer that clears this, but what would be the best action in such a situation?

Edit: Seems that someone (a mod?) removed my comment. (Yes, I (rolfl) did). The removed comments are:

Hi, try to elaborate on the way you improved the code. Don't post answers with only a series of changes. This might not help the OP understand why this is better code. – Abbas 3 hours ago

Thanks for the comment. Since most of it is covered in the previous answer, I just simplified the funciton. Have added some comments .Hope it helps. Will provide more if required. – thepace 2 hours ago

A bit of a situation for a review of this answer where I didn't know what the best action was. The answer has good intentions but could be improved by elaborating what the changes mean and why they are an improvement of the code. This way the OP can understand why this is an improvement.

Thus, I commented this on the answer but afterwards I wanted to click the I'm done button and realised that it doesn't exist there. The other options are not actualy an option:

  • Looks OK: no, because elaboration is needed
  • Edit: no, because I don't know the intention/knowledge of the author
  • Recommend deletion: no, a bit harsh for an answer that could be a good one
  • Skip: no, I took action and thus did not skip it

I now chose Skip as I'm not going to wait for answer that clears this, but what would be the best action in such a situation?

Edit: Seems that someone (a mod?) removed my comment. (Yes, I (rolfl) did). The removed comments are:

Hi, try to elaborate on the way you improved the code. Don't post answers with only a series of changes. This might not help the OP understand why this is better code. – Abbas 3 hours ago

Thanks for the comment. Since most of it is covered in the previous answer, I just simplified the funciton. Have added some comments .Hope it helps. Will provide more if required. – thepace 2 hours ago

A bit of a situation for a review of this answer where I didn't know what the best action was. The answer has good intentions but could be improved by elaborating what the changes mean and why they are an improvement of the code. This way the OP can understand why this is an improvement.

Thus, I commented this on the answer but afterwards I wanted to click the I'm done button and realised that it doesn't exist there. The other options are not actualy an option:

  • Looks OK: no, because elaboration is needed
  • Edit: no, because I don't know the intention/knowledge of the author
  • Recommend deletion: no, a bit harsh for an answer that could be a good one
  • Skip: no, I took action and thus did not skip it

I now chose Skip as I'm not going to wait for answer that clears this, but what would be the best action in such a situation?

Edit: Seems that someone (a mod?) removed my comment. (Yes, I (rolfl) did). The removed comments are:

Hi, try to elaborate on the way you improved the code. Don't post answers with only a series of changes. This might not help the OP understand why this is better code. – Abbas 3 hours ago

Thanks for the comment. Since most of it is covered in the previous answer, I just simplified the funciton. Have added some comments .Hope it helps. Will provide more if required. – thepace 2 hours ago

Tweeted twitter.com/#!/StackCodeReview/status/545925052890615809
Copy removed comments.
Source Link
rolfl Mod
  • 98.1k
  • 4
  • 117
  • 238

A bit of a situation for a review of this answer where I didn't know what the best action was. The answer has good intentions but could be improved by elaborating what the changes mean and why they are an improvement of the code. This way the OP can understand why this is an improvement.

Thus, I commented this on the answer but afterwards I wanted to click the I'm done button and realised that it doesn't exist there. The other options are not actualy an option:

  • Looks OK: no, because elaboration is needed
  • Edit: no, because I don't know the intention/knowledge of the author
  • Recommend deletion: no, a bit harsh for an answer that could be a good one
  • Skip: no, I took action and thus did not skip it

I now chose Skip as I'm not going to wait for answer that clears this, but what would be the best action in such a situation?

Edit: Seems that someone (a mod?) removed my comment. (Yes, I (rolfl) did). The removed comments are:

Hi, try to elaborate on the way you improved the code. Don't post answers with only a series of changes. This might not help the OP understand why this is better code. – Abbas 3 hours ago

Thanks for the comment. Since most of it is covered in the previous answer, I just simplified the funciton. Have added some comments .Hope it helps. Will provide more if required. – thepace 2 hours ago

A bit of a situation for a review of this answer where I didn't know what the best action was. The answer has good intentions but could be improved by elaborating what the changes mean and why they are an improvement of the code. This way the OP can understand why this is an improvement.

Thus, I commented this on the answer but afterwards I wanted to click the I'm done button and realised that it doesn't exist there. The other options are not actualy an option:

  • Looks OK: no, because elaboration is needed
  • Edit: no, because I don't know the intention/knowledge of the author
  • Recommend deletion: no, a bit harsh for an answer that could be a good one
  • Skip: no, I took action and thus did not skip it

I now chose Skip as I'm not going to wait for answer that clears this, but what would be the best action in such a situation?

Edit: Seems that someone (a mod?) removed my comment.

A bit of a situation for a review of this answer where I didn't know what the best action was. The answer has good intentions but could be improved by elaborating what the changes mean and why they are an improvement of the code. This way the OP can understand why this is an improvement.

Thus, I commented this on the answer but afterwards I wanted to click the I'm done button and realised that it doesn't exist there. The other options are not actualy an option:

  • Looks OK: no, because elaboration is needed
  • Edit: no, because I don't know the intention/knowledge of the author
  • Recommend deletion: no, a bit harsh for an answer that could be a good one
  • Skip: no, I took action and thus did not skip it

I now chose Skip as I'm not going to wait for answer that clears this, but what would be the best action in such a situation?

Edit: Seems that someone (a mod?) removed my comment. (Yes, I (rolfl) did). The removed comments are:

Hi, try to elaborate on the way you improved the code. Don't post answers with only a series of changes. This might not help the OP understand why this is better code. – Abbas 3 hours ago

Thanks for the comment. Since most of it is covered in the previous answer, I just simplified the funciton. Have added some comments .Hope it helps. Will provide more if required. – thepace 2 hours ago

added 62 characters in body
Source Link
Abbas
  • 5.6k
  • 12
  • 8

A bit of a situation for a review of this answer where I didn't know what the best action was. The answer has good intentions but could be improved by elaborating what the changes mean and why they are an improvement of the code. This way the OP can understand why this is an improvement.

Thus, I commented this on the answer but afterwards I wanted to click the I'm done button and realised that it doesn't exist there. The other options are not actualy an option:

  • Looks OK: no, because elaboration is needed
  • Edit: no, because I don't know the intention/knowledge of the author
  • Recommend deletion: no, a bit harsh for an answer that could be a good one
  • Skip: no, I took action and thus did not skip it

I now chose Skip as I'm not going to wait for answer that clears this, but what would be the best action in such a situation?

Edit: Seems that someone (a mod?) removed my comment.

A bit of a situation for a review of this answer where I didn't know what the best action was. The answer has good intentions but could be improved by elaborating what the changes mean and why they are an improvement of the code. This way the OP can understand why this is an improvement.

Thus, I commented this on the answer but afterwards I wanted to click the I'm done button and realised that it doesn't exist there. The other options are not actualy an option:

  • Looks OK: no, because elaboration is needed
  • Edit: no, because I don't know the intention/knowledge of the author
  • Recommend deletion: no, a bit harsh for an answer that could be a good one
  • Skip: no, I took action and thus did not skip it

I now chose Skip as I'm not going to wait for answer that clears this, but what would be the best action in such a situation?

A bit of a situation for a review of this answer where I didn't know what the best action was. The answer has good intentions but could be improved by elaborating what the changes mean and why they are an improvement of the code. This way the OP can understand why this is an improvement.

Thus, I commented this on the answer but afterwards I wanted to click the I'm done button and realised that it doesn't exist there. The other options are not actualy an option:

  • Looks OK: no, because elaboration is needed
  • Edit: no, because I don't know the intention/knowledge of the author
  • Recommend deletion: no, a bit harsh for an answer that could be a good one
  • Skip: no, I took action and thus did not skip it

I now chose Skip as I'm not going to wait for answer that clears this, but what would be the best action in such a situation?

Edit: Seems that someone (a mod?) removed my comment.

Source Link
Abbas
  • 5.6k
  • 12
  • 8
Loading