Skip to main content
Commonmark migration
Source Link

I'd say:

###Yes, but be careful with how pseudo it is.###

Yes, but be careful with how pseudo it is.

Code snippets which are simplified for the sake of posting to Code Review are generally going to be off-topic. If you simplify elements, you're eliminating aspects which would otherwise be part of the review.

But reviewing an entire application is well out of the question... the scope of the question would just be way too broad.

The better approach would be a complete recreation of the particular tab in question (in iOS we'd be talking about a view controller) and posting that up for review.

If you've developed a sandbox application for the sake of testing this chunk of code and then intend to move this code exactly as is into the full project, then this code might be a good fit for a Code Review question.

But this isn't Stack Overflow. We don't want you to boil your code down to just the area of most specific concern and abstract out all of the other stuff. If it looks like you've done that, we might close your question.

I'd say:

###Yes, but be careful with how pseudo it is.###

Code snippets which are simplified for the sake of posting to Code Review are generally going to be off-topic. If you simplify elements, you're eliminating aspects which would otherwise be part of the review.

But reviewing an entire application is well out of the question... the scope of the question would just be way too broad.

The better approach would be a complete recreation of the particular tab in question (in iOS we'd be talking about a view controller) and posting that up for review.

If you've developed a sandbox application for the sake of testing this chunk of code and then intend to move this code exactly as is into the full project, then this code might be a good fit for a Code Review question.

But this isn't Stack Overflow. We don't want you to boil your code down to just the area of most specific concern and abstract out all of the other stuff. If it looks like you've done that, we might close your question.

I'd say:

Yes, but be careful with how pseudo it is.

Code snippets which are simplified for the sake of posting to Code Review are generally going to be off-topic. If you simplify elements, you're eliminating aspects which would otherwise be part of the review.

But reviewing an entire application is well out of the question... the scope of the question would just be way too broad.

The better approach would be a complete recreation of the particular tab in question (in iOS we'd be talking about a view controller) and posting that up for review.

If you've developed a sandbox application for the sake of testing this chunk of code and then intend to move this code exactly as is into the full project, then this code might be a good fit for a Code Review question.

But this isn't Stack Overflow. We don't want you to boil your code down to just the area of most specific concern and abstract out all of the other stuff. If it looks like you've done that, we might close your question.

Source Link
nhgrif
  • 25.4k
  • 25
  • 72

I'd say:

###Yes, but be careful with how pseudo it is.###

Code snippets which are simplified for the sake of posting to Code Review are generally going to be off-topic. If you simplify elements, you're eliminating aspects which would otherwise be part of the review.

But reviewing an entire application is well out of the question... the scope of the question would just be way too broad.

The better approach would be a complete recreation of the particular tab in question (in iOS we'd be talking about a view controller) and posting that up for review.

If you've developed a sandbox application for the sake of testing this chunk of code and then intend to move this code exactly as is into the full project, then this code might be a good fit for a Code Review question.

But this isn't Stack Overflow. We don't want you to boil your code down to just the area of most specific concern and abstract out all of the other stuff. If it looks like you've done that, we might close your question.