Skip to main content
replaced http://meta.codereview.stackexchange.com/ with https://codereview.meta.stackexchange.com/
Source Link
replaced http://meta.codereview.stackexchange.com/ with https://codereview.meta.stackexchange.com/
Source Link
replaced http://meta.codereview.stackexchange.com/ with https://codereview.meta.stackexchange.com/
Source Link

Don't over-think the formulation of the question.

I believe Donald Mc.Lean's answer says it wellDonald Mc.Lean's answer says it well:

I would say that if the question contains code, and the asker wants the design of that code reviewed, there's absolutely nothing wrong with that, but if the asker wants something that is not code reviewed, it's off topic.

"Design-Only Questions" generally means UML-diagrams or pure English description of the design and no code. As long as there is real (non-examplish) reviewable code, there's nothing wrong with reviewing the design. I mean, how often haven't someone said something like "What you have done here makes no sense, scratch that and start over and do something like this instead...", those kind of answers are, to me, design answers. And there's nothing wrong with that.

Don't over-think the formulation of the question.

I believe Donald Mc.Lean's answer says it well:

I would say that if the question contains code, and the asker wants the design of that code reviewed, there's absolutely nothing wrong with that, but if the asker wants something that is not code reviewed, it's off topic.

"Design-Only Questions" generally means UML-diagrams or pure English description of the design and no code. As long as there is real (non-examplish) reviewable code, there's nothing wrong with reviewing the design. I mean, how often haven't someone said something like "What you have done here makes no sense, scratch that and start over and do something like this instead...", those kind of answers are, to me, design answers. And there's nothing wrong with that.

Don't over-think the formulation of the question.

I believe Donald Mc.Lean's answer says it well:

I would say that if the question contains code, and the asker wants the design of that code reviewed, there's absolutely nothing wrong with that, but if the asker wants something that is not code reviewed, it's off topic.

"Design-Only Questions" generally means UML-diagrams or pure English description of the design and no code. As long as there is real (non-examplish) reviewable code, there's nothing wrong with reviewing the design. I mean, how often haven't someone said something like "What you have done here makes no sense, scratch that and start over and do something like this instead...", those kind of answers are, to me, design answers. And there's nothing wrong with that.

Source Link
Simon Forsberg Mod
  • 59.7k
  • 1
  • 79
  • 174
Loading