Skip to main content
1 of 5
rolfl Mod
  • 98.1k
  • 4
  • 117
  • 238

Can working code be not-working off-topic?

This question here: Shortest possible way of printing a specific board

Summary:

  1. The code requirement is to print out a grid of text.
  2. The code does in fact print the grid
  3. The way it does that, is very broken, and it is only by hacking things that it works.
  4. From a code-review perspective, it does not work 'as designed', but only 'by mistake'

In cases like this, the most significant issue is to get the code to do the right thing, not to make it do the right thing well. The end-result (the output grid), is not the only measure that should be used to calculate 'the right thing'. The 'right thing' should also consider whether the algorithm works in a reasonable way....

As a test, I answered the question in a way that is more suited to Stack Overflow, than to Code Review. The answer received a fair amount of positive votes, and no negative votes.

Is this really a good Question (for Code Review)? Is it a good answer (for Code Review)?

Bottom line: Should the question be closed as "Off topic, code does not work" even though it produces the right result?

rolfl Mod
  • 98.1k
  • 4
  • 117
  • 238