Edit - Software Engineering Stack Exchange

You are not logged in. Your edit will be placed in a queue until it is peer reviewed.

We welcome edits that make the post easier to understand and more valuable for readers. Because community members review edits, please try to make the post substantially better than how you found it, for example, by fixing grammar or adding additional resources and hyperlinks.

Required fields*

Rev

2

You should use same "best practices" for the tests as you use for the application code. Usually having bool as argument for the method - is sign that method can be split in two. In this case you can introduce two test methods with proper name TestForPrimaryNumbers and TestForOtherNumbers which will be more easily to follow

Fabio
– Fabio

2018-03-03 09:49:19 +00:00
Commented Mar 3, 2018 at 9:49
1

@Fabio: what you wrote is fine, but it distracts somewhat from my core point, I tried not to change the original code more than necessary. So for the sake of demonstration, lets imagine the real test data is read from some file.

Doc Brown
– Doc Brown

2018-03-03 09:51:43 +00:00
Commented Mar 3, 2018 at 9:51

Add a comment |

Correct minor typos or mistakes
Clarify meaning without changing it
Add related resources or links
Always respect the author’s intent
Don’t use edits to reply to the author

create code fences with backticks ` or tildes ~
```
like so
```
add language identifier to highlight code
```python
def function(foo):
print(foo)
```
put returns between paragraphs
for linebreak add 2 spaces at end
_italic_ or **bold**
indent code by 4 spaces
backtick escapes `like _so_`
quote by placing > at start of line
to make links (use https whenever possible)

<https://example.com>

[example](https://example.com)

<a href="https://example.com">example</a>

formatting help »
answering help »