Closed Bug 2015657 Opened 5 months ago Closed 1 month ago

WebDriver Bidi does not emulate timezone in dedicated and shared workers

Categories

(Remote Protocol :: WebDriver BiDi, defect, P2)

Product:
Remote Protocol
Component:
WebDriver BiDi
Version:
Firefox 146
Type:
defect
Points:
5

Tracking

(firefox153 fixed)

Status:
RESOLVED FIXED
Milestone:
153 Branch
Tracking Flags:
Tracking Status
firefox153 --- fixed

People

(Reporter: aslushnikov, Assigned: Sasha)

References

(Blocks 1 open bug)

Details

(Whiteboard: [webdriver:m20][wptsync upstream][webdriver:relnote])

Attachments

(2 files)

Bug 2015657 - Override timezone in web and shared workers when "browsingContext.timezoneOverride" is set in related browsing contexts.
48 bytes, text/x-phabricator-request
Details | Review
Bug 2015657 - [wdspec] Add tests for overriding timezone with "emulation.setTimezoneOverride" in workers.
48 bytes, text/x-phabricator-request
Details | Review

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/144.0.0.0 Safari/537.36

Steps to reproduce:

Reproduction:

  1. clone playwright repo: git clone https://github.com/microsoft/playwright
  2. remove the line #120 in tests/library/browsercontext-timezone-id.spec.ts - the it.fail expectation.
  3. Run the test with Firefox Bidi: npm run biditest browsercontext-timezone-id:119 -- --project moz-firefox-nightly-library

Actual results:

The test fails because WebDriver bidi does not emulate timezone in workers.

Expected results:

WebDriver should emulate timezone in workers. The test should pass.

Blocks: 1938046

For timezone emulation to be picked up by the workers, we have to implement the logic of updating the timezone in the realm of the existing and new workers.

Status: UNCONFIRMED → NEW
Component: Untriaged → WebDriver BiDi
Ever confirmed: true
Product: Firefox → Remote Protocol
Severity: -- → S3
Points: --- → 5
Priority: -- → P3
Whiteboard: [webdriver:m20]
Priority: P3 → P2
Priority: P2 → P3

Hi folks,

Are there any plans on fixing this? If not, we'll consider migrating away from BiDi-powered api for timezone emulation back to the Juggler home-grown implementation.

(In reply to Andrey Lushnikov from comment #2)

Hi folks,

Are there any plans on fixing this? If not, we'll consider migrating away from BiDi-powered api for timezone emulation back to the Juggler home-grown implementation.

This bug is in the current milestone, which spans until end of June.
It's only P3, but I think :sasha wanted to pick this up, so there's a good chance that it gets resolved before end of June.

Assignee: nobody → aborovova
Status: NEW → ASSIGNED
Priority: P3 → P2

Hey Andrey,

How critical for you is the support of timezone override in service workers? Since service workers can belong to multiple browsing contexts, it's harder to architect. So I think to speed up things, we could consider moving it to follow-up and introduce in the scope of this bug only the support for dedicated and shared workers. Let me know what you think.

Flags: needinfo?(aslushnikov)

Yes, we only had it in dedicated workers, so this would be enough.

Flags: needinfo?(aslushnikov)
Summary: WebDriver Bidi does not emulate timezone in workers → WebDriver Bidi does not emulate timezone in dedicated and shared workers
Pushed by aborovova@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/293c4aff415a https://hg.mozilla.org/integration/autoland/rev/0c05f1603719 Override timezone in web and shared workers when "browsingContext.timezoneOverride" is set in related browsing contexts. r=edenchuang https://github.com/mozilla-firefox/firefox/commit/489d11925c63 https://hg.mozilla.org/integration/autoland/rev/51f2c32e3536 [wdspec] Add tests for overriding timezone with "emulation.setTimezoneOverride" in workers. r=jdescottes

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/60562 for changes under testing/web-platform/tests

Whiteboard: [webdriver:m20] → [webdriver:m20], [wptsync upstream]

https://hg.mozilla.org/mozilla-central/rev/0c05f1603719
https://hg.mozilla.org/mozilla-central/rev/51f2c32e3536

Status: ASSIGNED → RESOLVED
Closed: 1 month ago
status-firefox153: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 153 Branch

Upstream PR merged by moz-wptsync-bot

Whiteboard: [webdriver:m20], [wptsync upstream] → [webdriver:m20][wptsync upstream][webdriver:relnote]
You need to log in before you can comment on or make changes to this bug.