Timeline for Create mosaic task
Current License: CC BY-SA 4.0
11 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Jun 20, 2019 at 21:08 | comment | added | Plajerity | Let us continue this discussion in chat. | |
| Jun 20, 2019 at 21:07 | comment | added | Peilonrayz♦ | @Plajerity Not forgotten, still doable. | |
| Jun 20, 2019 at 21:06 | comment | added | Plajerity | Don't forget that image positions are random. | |
| Jun 20, 2019 at 21:05 | comment | added | Peilonrayz♦ | @Plajerity I don't see what the problem is. You've literally said it's doable. | |
| Jun 20, 2019 at 21:04 | comment | added | Plajerity | Take a look at given image above. Firstly we need to merge vertically, then horizontally. Otherwise it won't work. If image with the highest ratio was horizontal, we would need to merge 2 smaller images horizontally and then merge them all vertically. There are to many combinations. | |
| Jun 20, 2019 at 21:02 | comment | added | Peilonrayz♦ | @Plajerity I'm not sure this is the case. However I may be wrong. Can you show me an example image that would need these other merge functions, as the one in the OP doesn't. | |
| Jun 20, 2019 at 20:57 | comment | added | Plajerity | I feel I should mention it... It's not possible to use Image.merge (with concatenate) for more than 2 images. Concatenate requires to merge images of the same width/height. We would need to write in which order it merges, and it depends on where is rectangle image - random position. When I was writing it, first I created function to merge 2 images, and then realised that it's not possible with more images. Therefore there are more merging functions, and I decided to leave "the simplest one". | |
| Jun 11, 2019 at 11:18 | comment | added | Peilonrayz♦ |
@Plajerity As your code because too complex for me to reasonably review, I didn't look at the code after where I put the # .... Whilst I havn't looked at the code, you should be able to convert put_image2x2 and put_image3x3 to use Image.merge. Image is for a single image. Image.merge is to merge two images. Mozaika should only position the images, and defer to Image when it needs to merge or resize an image. Try following the above rules, and post another answer, it will surely benefit you.
|
|
| Jun 11, 2019 at 9:50 | comment | added | Plajerity | Thank you! I can see now one more massive problem, where I thought it'll be easier to understand, but no... There are 3 functions merging images, you didn't mention the 2 more important - I should have really deleted function merging 2 images. put_image2x2 and 3x3 are using grids of zeros to put images there. I think they should be in Mozaika class, and Image class will be for operations on single images, right? | |
| Jun 11, 2019 at 6:15 | vote | accept | Plajerity | ||
| Jun 10, 2019 at 13:44 | history | answered | Peilonrayz♦ | CC BY-SA 4.0 |