Skip to main content
Code Review

Return to Answer

deleted 6 characters in body
Source Link
theProgrammer
theProgrammer
  • 1.9k
  • 8
  • 26

The code is fairly okay and readable. Since you highlighted performance, my review would not touch on some areas that are lacking.

Prefer random.random() to generate pseudorandom numbers

import timeit

test1 = '''
import random
random.randint(1,10)
'''

test2= '''
import random
int(10 * random.random())
'''

tt1 = timeit.repeat(stmt=test1, repeat=5, number=1)
print('randint time taken: ', min(tt1))

tt2 = timeit.repeat(stmt=test2, repeat=5, number=1)
print('random.random() time taken: ', min(tt2))

On running the above program, the following results were gotten, note that the. NOTE: The results might vary on your computer, but there is still some difference.

randint time taken = 2.1700000005546375e-06

random.random() time taken = 6.056000074750045e-06

Though the difference is insignificant but, it might mean a lot when the range increases.

The code is fairly okay and readable. Since you highlighted performance, my review would not touch on some areas that are lacking.

Prefer random.random() to generate pseudorandom numbers

import timeit

test1 = '''
import random
random.randint(1,10)
'''

test2= '''
import random
int(10 * random.random())
'''

tt1 = timeit.repeat(stmt=test1, repeat=5, number=1)
print('randint time taken: ', min(tt1))

tt2 = timeit.repeat(stmt=test2, repeat=5, number=1)
print('random.random() time taken: ', min(tt2))

On running the above program, the following results were gotten, note that the results might vary on your computer, but there is still some difference

randint time taken = 2.1700000005546375e-06

random.random() time taken = 6.056000074750045e-06

Though the difference is insignificant but it might mean a lot when the range increases.

The code is fairly okay and readable. Since you highlighted performance, my review would not touch on some areas that are lacking.

Prefer random.random() to generate pseudorandom numbers

import timeit

test1 = '''
import random
random.randint(1,10)
'''

test2= '''
import random
int(10 * random.random())
'''

tt1 = timeit.repeat(stmt=test1, repeat=5, number=1)
print('randint time taken: ', min(tt1))

tt2 = timeit.repeat(stmt=test2, repeat=5, number=1)
print('random.random() time taken: ', min(tt2))

On running the above program, the following results were gotten. NOTE: The results might vary on your computer, but there is still some difference.

randint time taken = 2.1700000005546375e-06

random.random() time taken = 6.056000074750045e-06

Though the difference is insignificant, it might mean a lot when the range increases.

Source Link
theProgrammer
theProgrammer
  • 1.9k
  • 8
  • 26

The code is fairly okay and readable. Since you highlighted performance, my review would not touch on some areas that are lacking.

Prefer random.random() to generate pseudorandom numbers

import timeit

test1 = '''
import random
random.randint(1,10)
'''

test2= '''
import random
int(10 * random.random())
'''

tt1 = timeit.repeat(stmt=test1, repeat=5, number=1)
print('randint time taken: ', min(tt1))

tt2 = timeit.repeat(stmt=test2, repeat=5, number=1)
print('random.random() time taken: ', min(tt2))

On running the above program, the following results were gotten, note that the results might vary on your computer, but there is still some difference

randint time taken = 2.1700000005546375e-06

random.random() time taken = 6.056000074750045e-06

Though the difference is insignificant but it might mean a lot when the range increases.