Timeline for substr() function, not present in standard C library
Current License: CC BY-SA 4.0
Post Revisions
9 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Feb 11, 2022 at 8:23 | history | edited | user245050 | CC BY-SA 4.0 |
added 280 characters in body
|
| Feb 10, 2022 at 15:45 | comment | added | JDługosz | The larger point being: Code Reviews will help you learn (current!) best practices and avoid things that have been found to be pitfalls. It will not teach you how to program like it is still 1981. When people tell you "X doesn't belong here" this is hard-learned wisdom gathered over decades. If your "style" is in conflict with objectively better practices, you might need more up-to-date source code for inspiration on what you consider beautiful. | |
| Feb 8, 2022 at 15:22 | comment | added | JDługosz | @Amit Initializing variables is not a matter of "style" to choose from. It's a serious technique for promoting correct and maintainable code. Any code review will continue to tell you not to declare your variables in advance of the need, for good hard-learned reasons. | |
| Feb 5, 2022 at 7:05 | comment | added | user245050 | @JDługosz, that's fine. I will code according to my style, not someone else's style. About size_t, memmove/memcpy, grouping variables definitions, etc. I have already given comments in my earlier posts. I don't think that I want to repeat those comments for every new person who raises these questions again. | |
| Feb 4, 2022 at 15:30 | comment | added | JDługosz | You've previously been told about grouping all your variable definitions, too! I won't bother with a long detailed reply if OP doesn't pay any heed to it, and posts the same C function with the same issues. | |
| Feb 4, 2022 at 14:08 | comment | added | Martin R | It seems that you did not incorporate feedback to a previous question, such as using size_t and memcpy. | |
| Feb 4, 2022 at 13:52 | answer | added | Lundin | timeline score: 3 | |
| Feb 4, 2022 at 13:01 | comment | added | G. Sliepen |
strndup() is available on almost all platforms for a long time already, and will be in the C23 standard.
|
|
| Feb 4, 2022 at 12:50 | history | asked | user245050 | CC BY-SA 4.0 |