Skip to main content
Code Review

Return to Answer

These are theoretical types, not something in code and 'in progress' would not be valid as a code name.
Source Link
mdfst13
mdfst13
  • 22.4k
  • 6
  • 34
  • 70

A quick review

  • Functionality, as @Mast stated, this should be at least integrated with localStorage so that the data survives closing the browser
  • Practices, Avoid console.log, at least wrap it with some debug mode checking functionality
  • Design, having 'todo''todo', 'in progress''in progress', and 'done''done' as hardcoded arrays, functions, and indexes is a super inflexible design. I don't know what the right React.js approach is to have these items appear in the correct column, but this isn't it
  • Spelling, advancveTo -> advanceTo
  • CSS, font-style: favorit; is not valid CSS

A quick review

  • Functionality, as @Mast stated, this should be at least integrated with localStorage so that the data survives closing the browser
  • Practices, Avoid console.log, at least wrap it with some debug mode checking functionality
  • Design, having 'todo', 'in progress', and 'done' as hardcoded arrays, functions, and indexes is a super inflexible design. I don't know what the right React.js approach is to have these items appear in the correct column, but this isn't it
  • Spelling, advancveTo -> advanceTo
  • CSS, font-style: favorit; is not valid CSS

A quick review

  • Functionality, as @Mast stated, this should be at least integrated with localStorage so that the data survives closing the browser
  • Practices, Avoid console.log, at least wrap it with some debug mode checking functionality
  • Design, having 'todo', 'in progress', and 'done' as hardcoded arrays, functions, and indexes is a super inflexible design. I don't know what the right React.js approach is to have these items appear in the correct column, but this isn't it
  • Spelling, advancveTo -> advanceTo
  • CSS, font-style: favorit; is not valid CSS
improve grammar/formatting
Source Link
edit approved Oct 24, 2024 at 15:51
Michael Mior
edit approved Oct 24, 2024 at 15:51
Michael Mior
  • 103
  • 2

A quick review

  • Functionality, as @Mast stated, this should be at least integrated with localStorage so that the data survives closing the browser
  • Practices, Avoid console.log, at least wrap it with some debug mode checking functionallityfunctionality
  • Design, having 'todo''todo','in progress' 'in progress', and 'done''done' as hardcoded arrays, functions, and indexes is a super inflexible design. I don't know what the right reactReact.js approach is to have these items appear in the correct column, but this ain'tisn't it
  • SpelignSpelling, advancveTo -> advanceTo
  • CSS, font-style: favorit; is not valid CSS

A quick review

  • Functionality, as @Mast stated, this should be at least integrated with localStorage so that the data survives closing the browser
  • Practices, Avoid console.log, at least wrap it with some debug mode checking functionallity
  • Design, having 'todo','in progress', and 'done' as hardcoded arrays, functions, and indexes is a super inflexible design. I don't know what the right react.js approach is to have these items appear in the correct column, but this ain't it
  • Spelign, advancveTo -> advanceTo
  • CSS, font-style: favorit; is not valid CSS

A quick review

  • Functionality, as @Mast stated, this should be at least integrated with localStorage so that the data survives closing the browser
  • Practices, Avoid console.log, at least wrap it with some debug mode checking functionality
  • Design, having 'todo', 'in progress', and 'done' as hardcoded arrays, functions, and indexes is a super inflexible design. I don't know what the right React.js approach is to have these items appear in the correct column, but this isn't it
  • Spelling, advancveTo -> advanceTo
  • CSS, font-style: favorit; is not valid CSS
Source Link
konijn
konijn
  • 34.4k
  • 5
  • 71
  • 267

A quick review

  • Functionality, as @Mast stated, this should be at least integrated with localStorage so that the data survives closing the browser
  • Practices, Avoid console.log, at least wrap it with some debug mode checking functionallity
  • Design, having 'todo','in progress', and 'done' as hardcoded arrays, functions, and indexes is a super inflexible design. I don't know what the right react.js approach is to have these items appear in the correct column, but this ain't it
  • Spelign, advancveTo -> advanceTo
  • CSS, font-style: favorit; is not valid CSS