-
Notifications
You must be signed in to change notification settings - Fork 15.7k
Create a CMake option to control whether or not RTTI is enabled #8347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a CMake option to control whether or not RTTI is enabled #8347
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
���️ Googlers: Go here for more info. |
This is useful for Conan recipes that build Protobuf, in which whatever we want to enable has to be enabled in the initial command line. Without this, the people maintaining the recipe have to patch the CMake setup of Protobuf before building the binaries. Closes #5541
Thanks, @floriansimon1. |
My pleasure! Do we know when the next release is planned? |
We don't have a set release schedule but we seem to average once every quarter or so. If you want to have this in a release version sooner then feel free to send me another PR cherry-picking this to the 3.15.x branch because we are probably going to do a 3.15.4 release this week. |
Will do, thanks!
…-------- Message d'origine --------
Le 2 mars 2021 à 14:13, Adam Cozzette a écrit :
We don't have a set release schedule but we seem to average once every quarter or so. If you want to have this in a release version sooner then feel free to send me another PR cherry-picking this to the 3.15.x branch because we are probably going to do a 3.15.4 release this week.
��
You are receiving this because you were mentioned.
Reply to this email directly, [view it on GitHub](#8347 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/ACWAANV5IST2VGEJLFLK2EDTBU2G7ANCNFSM4YHFTSEA).
|
@acozzette > There! #8361 |
This is useful for Conan recipes that build Protobuf, in which
whatever we want to enable has to be enabled in the initial command line.
Without this, the people maintaining the recipe have to patch the CMake
setup of Protobuf before building the binaries.
Closes #5541