Skip to content

Remove redundant default export from util.ts - #574

Merged
rekmarks merged 1 commit into
mainfrom
remove-redundant-export
Aug 30, 2021
Merged

Remove redundant default export from util.ts#574
rekmarks merged 1 commit into
mainfrom
remove-redundant-export

Conversation

@rekmarks

@rekmarks rekmarks commented Aug 29, 2021

Copy link
Copy Markdown
Member

That which serves no purpose is to be eradicated.

Everything in the export default block was already a named export, so this quite literally serves no purpose. This is probably a breaking change anyway, but ¯\_(ツ)_/¯

@rekmarks
rekmarks requested a review from a team as a code owner August 29, 2021 18:15

@Gudahtt Gudahtt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rekmarks
rekmarks merged commit c8260ae into main Aug 30, 2021
@rekmarks
rekmarks deleted the remove-redundant-export branch August 30, 2021 16:30
@Gudahtt Gudahtt mentioned this pull request Aug 30, 2021
amitabh94 pushed a commit to amitabh94/core that referenced this pull request Jun 16, 2026
…etaMask#574)

* feat: expose SmartTransactionsController methods through messenger

Upgrade TypeScript to ~5.3.3 to align with core. Add method action
type generation script and expose controller methods via messenger.

* docs: add changelog entry for messenger actions and TypeScript upgrade

* docs: mark TypeScript upgrade as breaking change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants