Skip to content

[FIX] OpenSea Collection Name - #628

Merged
gantunesr merged 16 commits into
mainfrom
fix/opensea-collection-name
Nov 25, 2021
Merged

[FIX] OpenSea Collection Name#628
gantunesr merged 16 commits into
mainfrom
fix/opensea-collection-name

Conversation

@gantunesr

@gantunesr gantunesr commented Nov 5, 2021

Copy link
Copy Markdown
Member

Description

Currently the app has a bug that shows a collection name as Unidentified Contract. According to an OpenSea developer, the CollectiblesControllers should be using the property from collectible.name instead of name.

The issue appears to be with OpenSea's API. MetaMask calls /api/v1/asset_contract/0x1234... to fetch data about the contract, and for some contracts, the name parameter is returning "Unidentified Contract".
For example, see Curio Cards here- name is unidentified, but collection->name displays correctly. Perhaps metamask can work around this by accessing collection->name instead of name?

Tasks

  • Access collectible.name instead of name.
  • Update collectibles related objects (CollectibleMetadata and ApiCollectible)
  • Update ERC-1155 module
  • Update tests

References

hellbill
hellbill previously approved these changes Nov 9, 2021

@adonesky1 adonesky1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gantunesr
gantunesr merged commit 3497fa8 into main Nov 25, 2021
@gantunesr
gantunesr deleted the fix/opensea-collection-name branch November 25, 2021 02:25
@adonesky1 adonesky1 mentioned this pull request Nov 30, 2021

@hellbill hellbill left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Access

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants