add checkAndUpdateSingleCollectibleOwnershipStatus method - #669
Merged
adonesky1 merged 2 commits intoDec 27, 2021
Merged
Conversation
adonesky1
force-pushed
the
add-checkAndUpdateSingleCollectibleOwnershipStatus-method
branch
from
December 22, 2021 17:54
bab81eb to
f29574c
Compare
adonesky1
commented
Dec 22, 2021
| }); | ||
|
|
||
| describe('checkAndUpdateCollectiblesOwnershipStatus', () => { | ||
| it('should check whether collectibles for the current selectedAddress/chainId combination are still owned by the selectedAddress and update the isCurrentlyOwned value to false when collectible is not still owned', async () => { |
Contributor
Author
There was a problem hiding this comment.
The diff on this file got a bit screwed up again because I added a new layer of describes (one for each of checkAndUpdateAllCollectiblesOwnershipStatus and checkAndUpdateSingleCollectibleOwnershipStatus
adonesky1
deleted the
add-checkAndUpdateSingleCollectibleOwnershipStatus-method
branch
December 27, 2021 19:15
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ADDED:
checkAndUpdateAllCollectiblesOwnershipStatusthat can both be used as a helper method for batched updates to the isCurrentlyOwned value of allCollectibles for current selectedAddress/chainId combination, and for ownership status checks and state updates for single collectibles.