HTTP/3: ValueTask pooling

Author: JamesNK

src/Servers/Kestrel/Core/src/Internal/Http3/Http3Stream.cs

@@ -963,9 +963,9 @@ private bool TryValidatePseudoHeaders()
         }
 
         // CONNECT - :scheme and :path must be excluded=
-        if (Method == Http.HttpMethod.Connect && HttpRequestHeaders.HeaderProtocol.Count == 0)
+        if (Method == HttpMethod.Connect && HttpRequestHeaders.HeaderProtocol.Count == 0)
         {
-            if (!string.IsNullOrEmpty(RequestHeaders[PseudoHeaderNames.Scheme]) || !string.IsNullOrEmpty(RequestHeaders[PseudoHeaderNames.Path]))
+            if (!string.IsNullOrEmpty(HttpRequestHeaders.HeaderScheme) || !string.IsNullOrEmpty(HttpRequestHeaders.HeaderPath))
             {
                 Abort(new ConnectionAbortedException(CoreStrings.Http3ErrorConnectMustNotSendSchemeOrPath), Http3ErrorCode.ProtocolError);
                 return false;
@@ -1006,7 +1006,7 @@ private bool TryValidatePseudoHeaders()
         // OPTIONS request for an "http" or "https" URI that does not include
         // a path component; these MUST include a ":path" pseudo-header field
         // with a value of '*'.
-        if (Method == Http.HttpMethod.Options && path.Length == 1 && path[0] == '*')
+        if (Method == HttpMethod.Options && path.Length == 1 && path[0] == '*')
         {
             // * is stored in RawTarget only since HttpRequest expects Path to be empty or start with a /.
             Path = string.Empty;
@@ -1036,13 +1036,13 @@ private bool TryValidateMethod()
         _methodText = HttpRequestHeaders.HeaderMethod.ToString();
         Method = HttpUtilities.GetKnownMethod(_methodText);
 
-        if (Method == Http.HttpMethod.None)
+        if (Method == HttpMethod.None)
         {
             Abort(new ConnectionAbortedException(CoreStrings.FormatHttp3ErrorMethodInvalid(_methodText)), Http3ErrorCode.ProtocolError);
             return false;
         }
 
-        if (Method == Http.HttpMethod.Custom)
+        if (Method == HttpMethod.Custom)
         {
             if (HttpCharacters.IndexOfInvalidTokenChar(_methodText) >= 0)
             {

src/Servers/Kestrel/Transport.Quic/src/Internal/QuicStreamContext.cs

@@ -5,6 +5,7 @@
 using System.Diagnostics;
 using System.IO.Pipelines;
 using System.Net.Quic;
+using System.Runtime.CompilerServices;
 using System.Runtime.ExceptionServices;
 using Microsoft.AspNetCore.Connections;
 using Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Infrastructure;
@@ -145,17 +146,17 @@ private async Task StartAsync()
         {
             // Spawn send and receive logic
             // Streams may or may not have reading/writing, so only start tasks accordingly
-            var receiveTask = Task.CompletedTask;
-            var sendTask = Task.CompletedTask;
+            var receiveTask = ValueTask.CompletedTask;
+            var sendTask = ValueTask.CompletedTask;
 
             if (_stream.CanRead)
             {
-                receiveTask = DoReceive();
+                receiveTask = DoReceiveAsync();
             }
 
             if (_stream.CanWrite)
             {
-                sendTask = DoSend();
+                sendTask = DoSendAsync();
             }
 
             // Now wait for both to complete
@@ -189,7 +190,8 @@ private async Task WaitForWritesCompleted()
         }
     }
 
-    private async Task DoReceive()
+    [AsyncMethodBuilder(typeof(PoolingAsyncValueTaskMethodBuilder))]
+    private async ValueTask DoReceiveAsync()
     {
         Debug.Assert(_stream != null);
 
@@ -345,7 +347,8 @@ private void CancelConnectionClosedToken()
         }
     }
 
-    private async Task DoSend()
+    [AsyncMethodBuilder(typeof(PoolingAsyncValueTaskMethodBuilder))]
+    private async ValueTask DoSendAsync()
     {
         Debug.Assert(_stream != null);
 
@@ -514,6 +517,7 @@ private void ShutdownWrite(Exception? shutdownReason)
         }
     }
 
+    [AsyncMethodBuilder(typeof(PoolingAsyncValueTaskMethodBuilder))]
     public override async ValueTask DisposeAsync()
     {
         if (_stream == null)