Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Commit f32ae4a

Browse files
committed
Experiment: don't set CURLOPT_SSL_VERIFYHOST to 0
See what happens.
1 parent af4a1ab commit f32ae4a

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

‎src/System.Net.Http/src/System/Net/Http/OSX/CurlHandler.SslProvider.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ internal static void SetSslOptions(EasyRequest easy, ClientCertificateOption cli
7878
{
7979
EventSourceTrace("Disabling peer and host verification per {0}", nameof(HttpClientHandler.DangerousAcceptAnyServerCertificateValidator), easy: easy);
8080
easy.SetCurlOption(Interop.Http.CURLoption.CURLOPT_SSL_VERIFYPEER, 0); // don't verify the peer
81-
easy.SetCurlOption(Interop.Http.CURLoption.CURLOPT_SSL_VERIFYHOST, 0); // don't verify the peer cert's hostname
81+
// TODO: Experimenting with commenting this out: easy.SetCurlOption(Interop.Http.CURLoption.CURLOPT_SSL_VERIFYHOST, 0); // don't verify the peer cert's hostname
8282
}
8383
else
8484
{

‎src/System.Net.Http/src/System/Net/Http/Unix/CurlHandler.SslProvider.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ private static void SetSslOptionsForUnsupportedBackend(EasyRequest easy, ClientC
114114
{
115115
EventSourceTrace("Disabling peer and host verification per {0}", nameof(HttpClientHandler.DangerousAcceptAnyServerCertificateValidator), easy: easy);
116116
easy.SetCurlOption(Interop.Http.CURLoption.CURLOPT_SSL_VERIFYPEER, 0); // don't verify the peer
117-
easy.SetCurlOption(Interop.Http.CURLoption.CURLOPT_SSL_VERIFYHOST, 0); // don't verify the peer's host name
117+
// TODO: Experimenting with commenting this out: easy.SetCurlOption(Interop.Http.CURLoption.CURLOPT_SSL_VERIFYHOST, 0); // don't verify the peer's host name
118118
}
119119
else
120120
{

0 commit comments

Comments
 (0)