Skip to content

Commit 0de2c9b

Browse files
GoldenBugfacebook-github-bot
authored andcommitted
Remove Null Pointer Access in msg
Summary: Some functions attempt to set the completion code of an ipmi message if it's null. Remove those lines. Reviewed By: zhdaniel12 Differential Revision: D37153996 fbshipit-source-id: a54e72ed9b5fb5b072ec80ead42942afb772f230
1 parent 108bf01 commit 0de2c9b

1 file changed

Lines changed: 0 additions & 2 deletions

File tree

‎common/service/ipmi/oem_1s_handler.c‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -968,7 +968,6 @@ __weak void OEM_1S_READ_BIC_REGISTER(ipmi_msg *msg)
968968
***********************************/
969969
if (!msg) {
970970
printf("pal_OEM_1S_READ_BIC_REGISTER: parameter msg is NULL\n");
971-
msg->completion_code = CC_UNSPECIFIED_ERROR;
972971
return;
973972
}
974973
if (msg->data_len != 5) {
@@ -996,7 +995,6 @@ __weak void OEM_1S_WRITE_BIC_REGISTER(ipmi_msg *msg)
996995
***********************************/
997996
if (!msg) {
998997
printf("pal_OEM_1S_WRITE_BIC_REGISTER: parameter msg is NULL\n");
999-
msg->completion_code = CC_UNSPECIFIED_ERROR;
1000998
return;
1001999
}
10021000
if (msg->data[4] < 1 || msg->data[4] > 4 || (msg->data_len != 5 + msg->data[4])) {

0 commit comments

Comments
 (0)