Commit ee8f7cb
Increase client timeout and disable queue timeout for conformance tests
Summary:
Fix flaky Erlang Thrift conformance tests (`fbcode//thrift/conformance/test/rpc/erlang:rpc-client-test`) which have 75-95% flakiness rates due to two issues:
1. Client timeout too short: The Erlang BEAM VM, started via a dotslash/MSDK binary, takes longer than 10 seconds to boot in Sandcastle CI. This causes the test harness to give up before the client connects. Increase the non-sanitizer kClientTimeout from 10s to 30s. Passing tests complete in 1.5-3s, so 30s gives plenty of margin.
2. Queue timeout triggering load shedding: The conformance test server default 100ms queue timeout rejects the Erlang client RPC with a load shedding error (QUEUE_TIMEOUT). Disable queue timeout in the test server by calling server.setQueueTimeout(std::chrono::milliseconds(0)) - test environments should never reject clients due to load shedding.
Reviewed By: iahs
Differential Revision: D109872927
fbshipit-source-id: 9020e2934edfbe427ae29a763c685b2dd43cd1471 parent 3751dd9 commit ee8f7cb
1 file changed
Lines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
29 | | - | |
| 29 | + | |
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
| |||
588 | 588 | | |
589 | 589 | | |
590 | 590 | | |
| 591 | + | |
| 592 | + | |
| 593 | + | |
| 594 | + | |
591 | 595 | | |
592 | 596 | | |
593 | 597 | | |
| |||
0 commit comments