Skip to content

Commit 423fd7f

Browse files
Shitanshu Shahmeta-codesync[bot]
authored andcommitted
Bump getdeps Linux CI timeout to 120 minutes for 4-core runner
Summary: D109390010 switched the openr `getdeps_linux.yml` GitHub Actions workflow from the (non-existent) `8-core-ubuntu-24.04` runner to the available `4-core-ubuntu-24.04` pool by changing `--cpu-cores 8` to `--cpu-cores 4`. Halving the core count roughly doubles build wall-clock, but the workflow's `timeout-minutes` was left at the default `60`, so the 4-core build can now time out before it finishes. The `timeout-minutes` value is not a CLI flag and is unrelated to `--cpu-cores`. It is read by the getdeps workflow generator from the manifest's `[github.actions] timeout_minutes` key (`workflow_generator.py`), falling back to a hardcoded `60` when unset. openr's manifest had no `[github.actions]` section, so it inherited the `60` default. This adds `[github.actions] timeout_minutes = 120` to the openr getdeps manifest and regenerates `getdeps_linux.yml` via the same generator invocation used by `update-all-github-actions.sh`, bumping `timeout-minutes: 60` to `120`. The `runs-on: 4-core-ubuntu-24.04` label is unchanged. Differential Revision: D109903208 fbshipit-source-id: c1a8fd3be939766afdaf0b3d67f468808955a307
1 parent 02b810a commit 423fd7f

2 files changed

Lines changed: 5 additions & 1 deletion

File tree

‎build/fbcode_builder/getdeps/test/fixtures/expected/openr/getdeps_linux.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ permissions:
1616
jobs:
1717
build:
1818
runs-on: 8-core-ubuntu-24.04
19-
timeout-minutes: 60
19+
timeout-minutes: 120
2020
env:
2121
SCCACHE_GHA_ENABLED: "on"
2222
steps:

‎build/fbcode_builder/manifests/openr‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,10 @@ job_weight_mib = 3072
1616
# boost.fiber is required and that is not available on macos.
1717
builder = nop
1818

19+
[github.actions]
20+
# openr uses a 4-core runner, so allow extra build time.
21+
timeout_minutes = 120
22+
1923
[dependencies]
2024
boost
2125
fb303

0 commit comments

Comments
 (0)