Bug#34824457 logs missing on unclean process exit

If the router's integration tests fail with a unexpected exit-code,
they should dump logs on failure, but instead no logs are dumped.

That is caused by:

1. if the test failed, dump logs
2. check for clean exit.

That works as expected for normal-test failures, but not if the
monitored executable crashes after the test itself passed.

Change
------

- flip the order: first, check for clean exit, then dump logs on
  failure.
- removed not-needed .dump_logs()

Change-Id: Iaa0cc56e64446444df789008a98d7c8e62e4e607

Author: weigon

router/tests/helpers/procs.h

@@ -50,23 +50,20 @@ class Procs : public ProcessManager {
    * shutdown and stop monitoring of processes.
    */
   void clear() {
+    shutdown_all();
+    ensure_clean_exit();
+
     if (::testing::Test::HasFatalFailure() || dump_logs_) {
       dump_all();
     }
 
+    // it will call shutdown again ...
     ProcessManager::clear();
   }
 
   void shutdown_all() { ProcessManager::shutdown_all(); }
 
-  ~Procs() override {
-    shutdown_all();
-    ensure_clean_exit();
-
-    if (::testing::Test::HasFatalFailure() || dump_logs_) {
-      dump_all();
-    }
-  }
+  ~Procs() override { clear(); }
 
   void dump_logs() { dump_logs_ = true; }
 

router/tests/integration/test_routing_sharing_restart.cc

@@ -1225,10 +1225,6 @@ class ShareConnectionTestWithRestartedServer
   void TearDown() override {
     for (auto &inter : intermediate_routers_) {
       if (!inter->is_running()) {
-        if (::testing::Test::HasFatalFailure()) {
-          inter->process_manager().dump_logs();
-        }
-
         inter->process_manager().clear();
       }
     }