Bug #34114909 Fix compiler warnings from clang on Windows [noclose]

There are lots of compiler warnings when building with clang on Windows.
Fix the code, or silence the warnings.

With this patch the targets mysqld, plugin_all and component_all build
with no warnings with clang 12.0.1 in RelWithDebInfo mode.

Silence warnings in 3rd party code:
extra/libfido2
test/spb_test_mms.c
SunRPC library and generated sources.

Several source files (e.g. autorejoin.cc) have functions tagged with
[[noreturn]], based on the last thing they do is my_thread_exit().
Ignore the warning in mysys/my_thread.cc rather than changing the
signatures of all the [[noreturn]] functions.

Fix warnings in our own code:

poll.cc                             -Wsign-compare
plugin.cc                           -Wunused-parameter -Wcast-qual
                                    -Wmissing-field-initializers
user_map.cc                         -Wreorder-ctor
sspi_authentication_client.cc       -Wmissing-braces -Wcast-qual
                                    -Wunused-variable
xcom_network_provider_native_lib.cc -Wunused-value
sock_probe_win32.h                  -Wunused-parameter -Wshadow
                                    -Wunused-variable
task.cc                             -Wunused-parameter -Wsign-compare
xcom_base.cc                        -Wunused-parameter
my_xp_mutex.cc                      -Wunused-parameter
recovery_endpoints.cc               -Wunused-variable

Change-Id: I136d7138eb34e298690f535442d1ad073e45ebee

Author: Tor Didriksen

extra/libfido2/libfido2-1.8.0/CMakeLists.txt

@@ -53,7 +53,13 @@ if(CYGWIN OR MSYS)
 endif()
 
 if(WIN32)
+  IF(WIN32_CLANG)
+    add_definitions(-DWIN32_LEAN_AND_MEAN)
+    STRING_APPEND(CMAKE_C_FLAGS
+      " -Wno-tautological-constant-out-of-range-compare")
+  ELSE()
 	add_definitions(-DWIN32_LEAN_AND_MEAN -D_WIN32_WINNT=0x0600)
+  ENDIF()
 endif()
 
 if(APPLE)

include/my_thread.h

@@ -163,11 +163,7 @@ int my_thread_create(my_thread_handle *thread, const my_thread_attr_t *attr,
 int my_thread_join(my_thread_handle *thread, void **value_ptr);
 int my_thread_cancel(my_thread_handle *thread);
 
-// _endthreadex(_ReturnCode) is not tagged with noreturn.
-#ifndef _WIN32
-[[noreturn]]
-#endif
-void my_thread_exit(void *value_ptr);
+[[noreturn]] void my_thread_exit(void *value_ptr);
 
 /** Sets the name of the thread for system and debugger, if possible.
 @param name Name to set, must be shorter than SETNAME_MAX_LENGTH, including NULL

libmysql/authentication_kerberos/sspi_authentication_client.cc

@@ -46,8 +46,7 @@ Sspi_client::Sspi_client(const std::string &spn, MYSQL_PLUGIN_VIO *vio,
       m_kdc_host{kdc_host} {}
 
 bool Sspi_client::obtain_store_credentials() {
-  bool ret_val{false};
-  TimeStamp ticket_validy_time{0, 0};
+  TimeStamp ticket_validy_time{{0, 0}};
   SECURITY_STATUS sspi_status{0};
   /*
     Package name as described in:
@@ -72,24 +71,28 @@ bool Sspi_client::obtain_store_credentials() {
         "Sspi obtain and store TGT: Plug-in is trying to obtain tickets using "
         "user name and password.");
     if (!m_kdc_host.empty()) {
-      identity.Domain = (unsigned char *)(m_kdc_host.c_str());
+      identity.Domain = reinterpret_cast<unsigned char *>(
+          const_cast<char *>(m_kdc_host.c_str()));
       identity.DomainLength = m_kdc_host.length();
     }
     if (!m_upn.empty()) {
-      identity.User = (unsigned char *)(m_upn.c_str());
+      identity.User =
+          reinterpret_cast<unsigned char *>(const_cast<char *>(m_upn.c_str()));
       identity.UserLength = m_upn.length();
     }
     if (!m_password.empty()) {
-      identity.Password = (unsigned char *)(m_password.c_str());
+      identity.Password = reinterpret_cast<unsigned char *>(
+          const_cast<char *>(m_password.c_str()));
       identity.PasswordLength = m_password.length();
     }
     identity.Flags = SEC_WINNT_AUTH_IDENTITY_ANSI;
   }
 
   sspi_status = AcquireCredentialsHandle(
-      m_password.empty() ? nullptr : (LPSTR)m_upn.c_str(), mechanism,
-      SECPKG_CRED_BOTH, nullptr, m_password.empty() ? nullptr : &identity,
-      nullptr, nullptr, &m_cred, &ticket_validy_time);
+      m_password.empty() ? nullptr : const_cast<char *>(m_upn.c_str()),
+      mechanism, SECPKG_CRED_BOTH, nullptr,
+      m_password.empty() ? nullptr : &identity, nullptr, nullptr, &m_cred,
+      &ticket_validy_time);
 
   /*
     If the AcquireCredentialsHandle succeeds, the AcquireCredentialsHandle
@@ -134,7 +137,7 @@ bool Sspi_client::authenticate() {
   Kerberos_client_io client_io{m_vio};
   CtxtHandle context;
   ULONG attribs{0};
-  TimeStamp ticket_validy_time{0, 0};
+  TimeStamp ticket_validy_time{{0, 0}};
   SECURITY_STATUS sspi_status{SEC_E_LOGON_DENIED};
   SecBufferDesc input_buf_desc;
   SecBuffer input_buf;
@@ -171,9 +174,10 @@ bool Sspi_client::authenticate() {
     */
     sspi_status = InitializeSecurityContext(
         &m_cred, SecIsValidHandle(&context) ? &context : nullptr,
-        (SEC_CHAR *)m_service_principal.c_str(), ISC_REQ_ALLOCATE_MEMORY, 0,
-        SECURITY_NATIVE_DREP, input_buf.cbBuffer ? &input_buf_desc : nullptr, 0,
-        &context, &output_buf_desc, &attribs, &ticket_validy_time);
+        const_cast<char *>(m_service_principal.c_str()),
+        ISC_REQ_ALLOCATE_MEMORY, 0, SECURITY_NATIVE_DREP,
+        input_buf.cbBuffer ? &input_buf_desc : nullptr, 0, &context,
+        &output_buf_desc, &attribs, &ticket_validy_time);
 
     if (!succeeded(sspi_status)) {
       log_client_sspi_error(sspi_status,
@@ -240,4 +244,4 @@ I_Kerberos_client *I_Kerberos_client::create(const std::string &spn,
                                              const std::string &kdc_host) {
   Sspi_client *client = new Sspi_client(spn, vio, upn, password, kdc_host);
   return static_cast<I_Kerberos_client *>(client);
-}
+}

mysys/my_thread.cc

@@ -154,13 +154,21 @@ int my_thread_cancel(my_thread_handle *thread) {
 #endif
 }
 
+// _endthreadex(_ReturnCode) is not tagged with noreturn.
+#ifdef _WIN32
+MY_COMPILER_DIAGNOSTIC_PUSH()
+MY_COMPILER_CLANG_DIAGNOSTIC_IGNORE("-Winvalid-noreturn")
+#endif
 void my_thread_exit(void *value_ptr [[maybe_unused]]) {
 #ifndef _WIN32
   pthread_exit(value_ptr);
 #else
   _endthreadex(0);
 #endif
 }
+#ifdef _WIN32
+MY_COMPILER_DIAGNOSTIC_POP()
+#endif
 
 /**
   Maximum name length used for my_thread_self_setname(),

plugin/group_replication/libmysqlgcs/CMakeLists.txt

@@ -161,7 +161,19 @@ IF(MSVC)
   # Compiler warning C4018.
   IF(WIN32_CLANG)
     ADD_COMPILE_FLAGS(${XCOM_SUNRPC_SOURCES} ${XCOM_RPCGEN_SOURCES}
-      COMPILE_FLAGS "-Wno-sign-compare")
+      COMPILE_FLAGS
+      "-Wno-int-to-void-pointer-cast"
+      "-Wno-pointer-to-int-cast"
+      "-Wno-sign-compare"
+      "-Wno-unused-parameter"
+      "-Wno-unused-variable"
+      )
+    ADD_COMPILE_FLAGS(
+      src/bindings/xcom/xcom/xcom_base.cc
+      src/bindings/xcom/xcom/sock_probe.cc
+      COMPILE_FLAGS
+      "-Wno-unused-function"
+      )
   ELSE()
     ADD_COMPILE_FLAGS(${XCOM_SUNRPC_SOURCES} ${XCOM_RPCGEN_SOURCES}
       COMPILE_FLAGS "/wd4018")

plugin/group_replication/libmysqlgcs/src/bindings/xcom/xcom/network/xcom_network_provider_native_lib.cc

@@ -299,9 +299,7 @@ void Xcom_network_provider_library::gcs_shutdown_socket(int *sock) {
              &dwBytesReturned, nullptr, nullptr);
   }
   if (DisconnectEx != nullptr) {
-    (DisconnectEx(*sock, (LPOVERLAPPED) nullptr, (DWORD)0, (DWORD)0) == TRUE)
-        ? 0
-        : -1;
+    DisconnectEx(*sock, (LPOVERLAPPED) nullptr, (DWORD)0, (DWORD)0);
   } else {
     shutdown(*sock, SOCK_SHUT_RDWR);
   }

plugin/group_replication/libmysqlgcs/src/bindings/xcom/xcom/sock_probe_win32.h

@@ -135,7 +135,7 @@ static int number_of_interfaces(sock_probe *s) {
 }
 
 /* Return TRUE if interface #count is running. */
-static bool_t is_if_running(sock_probe *s, int count) {
+static bool_t is_if_running(sock_probe *s, int /* count */) {
   if (s == NULL) {
     return 0;
   }
@@ -194,7 +194,6 @@ static interface_info get_interface(sock_probe *s, int count) {
  */
 static void get_sockaddr(sock_probe *s, int count, struct sockaddr **out,
                          SockaddrOp addr_operation) {
-  int i = 0;
   interface_info interface_info;
 
   if (s == NULL) {

plugin/group_replication/libmysqlgcs/src/bindings/xcom/xcom/task.cc

@@ -322,7 +322,7 @@ double task_now() {
 }
 
 #ifdef _WIN32
-int gettimeofday(struct timeval *tp, struct timezone *tzp) {
+int gettimeofday(struct timeval *tp, struct timezone *) {
   static uint64_t const EPOCH = ((uint64_t)116444736000000000ULL);
 
   SYSTEMTIME system_time;
@@ -864,7 +864,7 @@ void remove_and_wakeup(int fd) {
   u_int i = 0;
   IFDBG(D_NONE, FN; NDBG(fd, d));
   while (i < iot.nwait) {
-    if (get_pollfd(&iot.fd, i).fd == fd) {
+    if (static_cast<int>(get_pollfd(&iot.fd, i).fd) == fd) {
       poll_wakeup(i);
     } else {
       i++;

plugin/group_replication/libmysqlgcs/src/bindings/xcom/xcom/xcom_base.cc

@@ -714,7 +714,7 @@ static int ignoresig(int signum) {
 }
 #else
 #define SIGPIPE 0
-static int ignoresig(int signum) { return 0; }
+static int ignoresig(int) { return 0; }
 #endif
 
 static int recently_active(pax_machine *p) {

plugin/group_replication/libmysqlgcs/src/interface/xplatform/my_xp_mutex.cc

@@ -46,7 +46,7 @@ int My_xp_mutex_server::trylock() { return mysql_mutex_trylock(m_mutex); }
 int My_xp_mutex_server::unlock() { return mysql_mutex_unlock(m_mutex); }
 #endif
 
-int My_xp_mutex_util::attr_init(native_mutexattr_t *attr) {
+int My_xp_mutex_util::attr_init(native_mutexattr_t *attr [[maybe_unused]]) {
 /*
   On Windows there is no initialization of mutex attributes.
   Therefore, we simply return 0.
@@ -58,7 +58,7 @@ int My_xp_mutex_util::attr_init(native_mutexattr_t *attr) {
 #endif
 }
 
-int My_xp_mutex_util::attr_destroy(native_mutexattr_t *attr) {
+int My_xp_mutex_util::attr_destroy(native_mutexattr_t *attr [[maybe_unused]]) {
 /*
   On Windows there is no destruction of mutex attributes.
   Therefore, we simply return 0.