[upstream] Remove multifactor flag from the default client flags

Summary:
The MFA client flag in 8.0.28 conflicts with the lz4_stream compression
flag in 8.0.23. While 8.0.28 removed the lz4_stream flag, it will fail
when connecting to 8.0.23 unless the compression_lib is set. But not
all applications set compression_lib.

Removing this flag from the default client flag will allow these
application to connect to 8.0.23. Once everything is on 8.0.28, this
patch can be dropped.

Squash with null

Reviewed By: lth

Differential Revision: D37718979

Author: Herman Lee

���include/mysql_com.h

@@ -789,8 +789,7 @@
    CLIENT_PLUGIN_AUTH_LENENC_CLIENT_DATA |                                     \
    CLIENT_CAN_HANDLE_EXPIRED_PASSWORDS | CLIENT_SESSION_TRACK |                \
    CLIENT_DEPRECATE_EOF | CLIENT_OPTIONAL_RESULTSET_METADATA |                 \
-   CLIENT_ZSTD_COMPRESSION_ALGORITHM | CLIENT_QUERY_ATTRIBUTES |               \
-   MULTI_FACTOR_AUTHENTICATION)
+   CLIENT_ZSTD_COMPRESSION_ALGORITHM | CLIENT_QUERY_ATTRIBUTES)
 
 /**
   Switch off from ::CLIENT_ALL_FLAGS the flags that are optional and

libmysql/client_settings.h

@@ -42,8 +42,7 @@ extern char *mysql_unix_port;
    CLIENT_PROTOCOL_41 | CLIENT_RESERVED2 | CLIENT_MULTI_RESULTS |          \
    CLIENT_PS_MULTI_RESULTS | CLIENT_PLUGIN_AUTH |                          \
    CLIENT_PLUGIN_AUTH_LENENC_CLIENT_DATA | CLIENT_CONNECT_ATTRS |          \
-   CLIENT_SESSION_TRACK | CLIENT_DEPRECATE_EOF | CLIENT_QUERY_ATTRIBUTES | \
-   MULTI_FACTOR_AUTHENTICATION)
+   CLIENT_SESSION_TRACK | CLIENT_DEPRECATE_EOF | CLIENT_QUERY_ATTRIBUTES)
 
 void read_user_name(char *name);
 bool handle_local_infile(MYSQL *mysql, const char *net_filename);

sql/client_settings.h

@@ -37,8 +37,7 @@
   (CLIENT_LONG_PASSWORD | CLIENT_LONG_FLAG | CLIENT_TRANSACTIONS |         \
    CLIENT_PROTOCOL_41 | CLIENT_RESERVED2 | CLIENT_PLUGIN_AUTH |            \
    CLIENT_PLUGIN_AUTH_LENENC_CLIENT_DATA | CLIENT_CONNECT_ATTRS |          \
-   CLIENT_SESSION_TRACK | CLIENT_DEPRECATE_EOF | CLIENT_QUERY_ATTRIBUTES | \
-   MULTI_FACTOR_AUTHENTICATION)
+   CLIENT_SESSION_TRACK | CLIENT_DEPRECATE_EOF | CLIENT_QUERY_ATTRIBUTES)
 
 #define read_user_name(A) \
   {}