Skip to content

Sync fork with chromium/7103#172

Merged
hoxyq merged 4072 commits into
mainfrom
repo-sync-7103
Jun 10, 2025
Merged

Sync fork with chromium/7103#172
hoxyq merged 4072 commits into
mainfrom
repo-sync-7103

Conversation

@hoxyq

@hoxyq hoxyq commented Jun 10, 2025

Copy link
Copy Markdown

Re-land of #170, because I've accidentally squashed commits.

Summary

Upgrades the react-native-devtools-frontend fork from chromium/6613 to the upstream chromium/7103 branch.

There were a total of ~51 conflicts, resolved as below:

File conflicts

  • .gitignore — Merge changes
  • README.md — Keep ours
  • CONTRIBUTING.md — Both added, keep ours
  • config/gni/devtools_grd_files.gni — Merge changes
  • front_end/BUILD.gn — Merge changes
  • front_end/core/root/Runtime.ts — Merge changes
  • front_end/core/sdk/Connections.ts — Merge changes
  • front_end/core/sdk/PageResourceLoader.ts — Merge changes
    • Use upstream renamed enum keys.
  • front_end/core/sdk/sdk-meta.ts — Merge changes
  • front_end/core/sdk/sdk.ts — Keep both
  • front_end/entrypoints/inspector_main/BUILD.gn — Keep both
  • front_end/entrypoints/main/BUILD.gn — Keep both
  • front_end/entrypoints/main/MainImpl.ts — merge
  • front_end/entrypoints/shell/BUILD.gn — Keep both
  • front_end/models/source_map_scopes/NamesResolver.test.ts — Use upstream, then reapply Performance: hide more unsupported features #150
  • front_end/models/source_map_scopes/NamesResolver.ts — Use upstream, then reapply Performance: hide more unsupported features #150
  • front_end/models/trace/handlers/RendererHandler.ts — Merge
  • front_end/models/trace/handlers/WarningsHandler.test.ts — Use upstream, then reapply Performance: hide more unsupported features #150
  • front_end/models/trace/helpers/SyntheticEvents.test.ts — Use upstream, then reapply Performance: hide more unsupported features #150
  • front_end/models/trace/insights/DocumentLatency.test.ts — Use upstream, then reapply Performance: hide more unsupported features #150
  • front_end/models/trace/insights/InteractionToNextPaint.test.ts — Use upstream, then reapply Performance: hide more unsupported features #150
  • front_end/models/trace/lantern/core/NetworkAnalyzer.test.ts — Use upstream, then reapply Performance: hide more unsupported features #150
  • front_end/panels/console/ConsolePrompt.ts - Use upstream, then reapply Disable console-eager-eval and Live Expressions panel #164
  • front_end/panels/console/ConsoleView.ts - Use upstream, then reapply Disable console-eager-eval and Live Expressions panel #164
  • front_end/panels/console/console-meta.ts - Use upstream, then reapply Disable console-eager-eval and Live Expressions panel #164
  • front_end/panels/console/consoleView.css — Keep both CSS additions
  • front_end/panels/console/ErrorStackParser.test.ts — Use upstream, then reapply Performance: hide more unsupported features #150
  • front_end/panels/network/network-meta.ts — Keep ours
  • front_end/panels/network/NetworkLogView.ts — Keep our customisations
  • front_end/panels/network/NetworkPanel.ts — Keep our customisations
  • front_end/panels/profiler/HeapSnapshotView.ts — Merge
    • Preserve our rnPerfMetrics calls.
  • front_end/panels/sources/SourcesView.ts — Use upstream
    • Conditionally hidden UI no longer present.
  • front_end/panels/sources/UISourceCodeFrame.ts — Keep our customisations
  • front_end/panels/timeline/EntriesFilter.test.ts — Use upstream, then reapply Performance: hide more unsupported features #150
  • front_end/panels/timeline/Initiators.test.ts — Use upstream, then reapply Performance: hide more unsupported features #150
  • front_end/panels/timeline/ModificationsManager.test.ts — Use upstream, then reapply Performance: hide more unsupported features #150
  • front_end/panels/timeline/TimelineFlameChartDataProvider.ts — Keep our customisations
  • front_end/panels/timeline/TimelinePanel.ts — Merge
    • Preserve our disabled Performance features.
  • front_end/panels/timeline/TimelineLandingPage.ts — Deleted upstream
  • front_end/panels/timeline/TimingsTrackAppender.ts — Use upstream
  • front_end/testing/EnvironmentHelpers.ts — Keep both (experiment keys)
  • front_end/third_party/additional_readme_paths.json — Keep both (manifest file)
  • front_end/ui/components/input/checkbox.css — Use upstream
  • front_end/ui/legacy/ActionRegistration.ts — Keep our extra icons
  • front_end/ui/legacy/BUILD.gn — Merge
  • front_end/ui/legacy/components/utils/TargetDetachedDialog.ts — Merge changes
  • front_end/ui/legacy/inspectorCommon.css — Use upstream (not modified by us)
  • front_end/ui/legacy/remoteDebuggingTerminatedScreen.css — Keep ours
  • front_end/ui/legacy/RemoteDebuggingTerminatedScreen.ts — Merged
    • Keep our dialog design, lit-html -> lit.
  • front_end/ui/legacy/theme_support/ThemeSupport.ts — Merge
    • Preserve our baseline-greyscale override.
  • third_party/node/node.py — Use upstream (includes our fix)

Linter

  • 42 errors fixed.
  • 20 CSS linter error fixed.
  • npm run lint now succeeds.

Tests

  • Disabled 3 screenshot tests:

Test plan

Smoke testing

  • Welcome
    • All links are clickable ✅
    • [Internal-only] Session ID is displayed ✅
  • Console
    • Evaluation from the Console works ✅
    • Ignore lists are respected ✅
    • Eager evaluation is disabled ✅
    • Error stack symbolication works ✅
  • Sources
    • Loaded sources are displayed in the tree ✅
    • VM is paused when breakpoint is hit ✅
    • Stepping in / out / over works ✅
    • "Deactivate breakpoints" works ✅
  • React DevTools Components
    • The React Tree is loaded ✅
    • Components are highlighted on the screen when hovered over ✅
    • Can click on a component from the Tree and see its attributes ✅
    • Select-to-inspect works - ❌
      • Also broken on main.
  • Profiler
    • Can record a session ✅
    • Reload-to-profile works ✅
    • Can download profile ✅
    • Can upload profile ✅
  • Performance
    • Can record a session ✅
    • JavaScript Samples displayed correctly and grouped ✅
    • Custom Track integration works ✅
    • In DEV mode, sources of the call frames are symbolicated ✅
  • Memory
    • Live metrics are displayed ✅
    • Snapshot recorded successfully ✅
    • Could record allocations on a timeline successfully ✅
    • Allocation sampling works - ❌
      • Also broken on main.
    • Detached elements - ❌ (New feature, new CDP request, unsupported)
      • Will hide in a separate PR
  • Other
    • [FB-only] Send feedback button is visible on the panel toolbar ✅
    • When disconnected, Reconnect button is displayed ✅
    • Reloading via Cmd + R works - ✅

Upstreaming plan

  • This commit should be sent as a patch to the upstream devtools-frontend repo. I've reviewed the contribution guide.
  • This commit is React Native-specific and cannot be upstreamed.
masnoble and others added 30 commits March 20, 2025 05:33
…lsView"

This is a reland of commit 1ac4ec6

Original change's description:
> Have InspectorView remove the Infobar instead of CookieControlsView
>
> If CookieControlsView was responsible for listening for a
> PrimaryPageChanged event and then removing the Infobar, the infobar
> would not be removed if CookieControlsView was never created to
> listen in the first place. This is a problem because the Infobar
> might be created by the InspectorMain entrypoint which does not
> guarantee that a CookieControlsView will be created as well.
>
> By moving the listener to the InspectorView, we guarantee that the
> Infobar is removed when the user reloads the page without needing
> to open the Privacy and security panel.
>
> Bug: 400962121
> Change-Id: I612c4899e218e094fd31a3eda154ec69c20e8035
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6346989
> Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
> Reviewed-by: Danil Somsikov <dsv@chromium.org>
> Commit-Queue: Joshua Thomas <masnoble@chromium.org>

Bug: 400962121
Change-Id: Id4b4c5a1e46e84877642978c3763af784ff751b6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6367775
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Commit-Queue: Joshua Thomas <masnoble@chromium.org>
Chromium pin updated to 136.0.7079.0

Roll created at https://cr-buildbucket.appspot.com/build/8719879389676520017

Bug: none
Change-Id: Icf799ed3d6f0359472a841a0190dd08e291539c3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6375025
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Before: https://i.imgur.com/aVWAr49.png
After: https://i.imgur.com/p3UWBUC.png
Bug: 325443308
Change-Id: I603e8271493508855fabe33a45e08a36de35fbea
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6375503
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
Fixed: 405049967
Change-Id: I4c254f2787a367d4dba8d96ae07c462a98f6f622
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6375523
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
…eouts on bots

Bug: 345556266
Change-Id: I8b1f95389bfb22d388747f6251a7959b44d1e294
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6375263
Auto-Submit: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
…ed diff view

Bug: none
Change-Id: I4aa03ebf9a89794d4ad36b029233ab44be59dadf
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6376067
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Auto-Submit: Ergün Erdoğmuş <ergunsh@chromium.org>
Fixed: 404535134
Change-Id: Id1930b7023938154a1b46348b6c2170eab89d66c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6368838
Reviewed-by: Eric Leese <leese@chromium.org>
Commit-Queue: Eric Leese <leese@chromium.org>
Auto-Submit: Philip Pfaffe <pfaffe@chromium.org>
includes `SyntheticNetworkRequests`

Because tree views only consider events on the Main thread, we need to
make an exception for when considering 3P (as this includes network requests). So on hover/click we should include network requests for
completion using the entity mapper.

https://screencast.googleplex.com/cast/NjIyNjk4NzE1OTkxMjQ0OHxjYzJhYjc2MS05Nw

Bug: 394651390
Change-Id: I5d127a6dce58bd54a7fbbfeabd4401753b8f3bf8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6374483
Commit-Queue: Adriana Ixba <aixba@chromium.org>
Reviewed-by: Paul Irish <paulirish@chromium.org>
Bug: 394651390
Change-Id: I05d15ba3f0e2ff2e6a7b3fb9414f4cc5bba27557
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6373790
Commit-Queue: Adriana Ixba <aixba@chromium.org>
Auto-Submit: Paul Irish <paulirish@chromium.org>
Reviewed-by: Adriana Ixba <aixba@chromium.org>
Specifically document the Linux specific limits for `inotify` which
one can easily run into when combining `npm run build -- --watch`
and VS code.

Bug: 404192426
Change-Id: Idf301cb2e773325b2d299e61e879f85541551aa4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6376063
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
After dropping the `adoptedStyleSheets` the styles went missing for
the interest group tab's empty state. This CL moves the rendering
of the empty state into the main `render` method, under which we also
include the correct styles.

Before: https://i.imgur.com/N3xS6DM.png
After: https://i.imgur.com/3W26pvn.png
Bug: none
Change-Id: If8eed04ec054e199d08053337cd3e6b2d3112c5e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6376103
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Kim-Anh Tran <kimanh@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Every call to `add` a new overlay would iterate over all existing
overlays to manage singletons specially. For an extreme case of ~70k
overlays, this resulted in ~22s of extra processing time on my M1 Mac.

This CL reduces it down to 5ms by simply storing singleton overlays in
a map for constant time lookup.

Example trace w/ many overlays on 3p insight:  https://trace.cafe/t/V7sS5bz7F0

Bug: 40278532
Change-Id: Ia8b76892e4f22f1a60215fffcc999fb4862121a0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6376737
Commit-Queue: Connor Clark <cjamcl@chromium.org>
Auto-Submit: Connor Clark <cjamcl@chromium.org>
Reviewed-by: Paul Irish <paulirish@chromium.org>
Chromium pin updated to 136.0.7080.0

Roll created at https://cr-buildbucket.appspot.com/build/8719822769335182177

Bug: none
Change-Id: Ie9c412cdf016ba0316c50e4e2fd9e4a1f2276bc3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6377848
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
See bug for context, we sometimes see the LLM wrap its response in 5
backticks for no apparent reason. We're going to sync with the Aida
folks to see if we can understand why or fix this on their side, but for
now a fix is also to strip the 5 backticks if they are found in the
response.

Bug: 405054694
Change-Id: Ieb7499af142f7f7cba9ffea999729f49e1fbe536
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6375525
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
Fixed: 405095525
Change-Id: I547dc6bb01c06a77147c2967fae1230dcb42a2eb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6376066
Reviewed-by: Simon Zünd <szuend@chromium.org>
Auto-Submit: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Fixed: 405061222
Change-Id: I3a7bc85e40512e3f9de244a0258377b9e3da2077
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6375726
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
This has flaked a few times. Trying to see if this retry function will
improve its stability, as we have quite a few rAFs to try to make this
test work.

Bug: 405356930
No-Presubmit: True
No-Tree-Checks: True
No-Try: True
Change-Id: Ib9864aef67413ef1d3fa36d99359e8756b6626cb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6381858
Reviewed-by: Andres Olivares <andoli@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
This roll requires a manual review. See http://go/reviewed-rolls for guidance.

In case of failures or errors, reach out to someone from config/owner/COMMON_OWNERS.

Roll created at https://cr-buildbucket.appspot.com/build/8719788792218476385

R=devtools-waterfall-sheriff-onduty@rotations.google.com

Bug: none
Change-Id: Ic9b4442aecfc18ffaf55966d2737fe4ff870395b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6381836
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Fixed: 405061899
Change-Id: Idf06927221664dfa45a1ba3215fb5f2a6ad99084
Also-by: alinavarkki@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6381853
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Bug: none
Change-Id: I819e3671f84eade93c5e3014a08b8b208cf4e5a6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6382413
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
Bug: none
Change-Id: I88792c9561ab7950063335c9b949a7d10e6a5ae9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6330113
Reviewed-by: Nancy Li <nancyly@chromium.org>
Commit-Queue: Nancy Li <nancyly@chromium.org>
Auto-Submit: Danil Somsikov <dsv@chromium.org>
Bug: none
Change-Id: I44314f07516a6444b18bfc877efb1e0c0488fac8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6383675
Reviewed-by: Andres Olivares <andoli@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Andres Olivares <andoli@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Chromium pin updated to 136.0.7082.2

Roll created at https://cr-buildbucket.appspot.com/build/8719732170690310641

Bug: none
Change-Id: I20016dec784528efaf22d90184e369d3bd1d1c7b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6383277
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Chromium pin updated to 136.0.7083.0

Roll created at https://cr-buildbucket.appspot.com/build/8719698197868596177

Bug: none
Change-Id: I8c8977764f4698385a6df7b8a76034681273a06f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6383824
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Chromium pin updated to 136.0.7084.0

Roll created at https://cr-buildbucket.appspot.com/build/8719641573921810753

Bug: none
Change-Id: Ia627446634cb4cd1d0e27aed2c8b1d5604f621dc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6381661
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
… SWEs

Change-Id: If356c1c17c13741ea8571a2ee47936aaa50e2bd7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6367394
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Meysam Sarabadani <meysarabadani@google.com>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Fixed: 404535428
Change-Id: Ib6059ea7d278a172dc1e0880582a1a94bd255859
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6372801
Reviewed-by: Eric Leese <leese@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Chromium pin updated to 136.0.7086.0

Roll created at https://cr-buildbucket.appspot.com/build/8719550977847411953

Bug: none
Change-Id: I5e61d37fff280905844083c08c8306cb3a61876e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6383222
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Rolling third_party/siso: git_revision:3a38836e06344016dce6092148a07a114807f9f0..git_revision:ae99e5f46d1fbc718ad9c28bb82c16883d7de99b

Roll created at https://cr-buildbucket.appspot.com/build/8719550977847411953

Bug: none
Change-Id: I91f43bb20ce1371651cf60f1f3cecd1ebb9e7102
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6383221
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bug: 388730998
Change-Id: Ida1c4b447a6086c5c0cad08dfc4f2c32e8323fb3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6382155
Auto-Submit: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Kateryna Prokopenko and others added 19 commits April 7, 2025 05:09
Fix shadow and remove arrow Margin behaviour as a drive-by

Bug: 406466030
Change-Id: Iaaf6abde4f255e11d9056f89f1b8cfa448148805
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6425299
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
Auto-Submit: Kateryna Prokopenko <kprokopenko@chromium.org>
(cherry picked from commit 773da36)
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6437729
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
Bug: 408275043
Fixed: 408368319
Change-Id: I966155b37e08f32f2640823f46b0c214095775f1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6431348
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Connor Clark <cjamcl@chromium.org>
(cherry picked from commit 59e1ee7)
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6438912
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Before: https://i.imgur.com/lOcJJw8.png
After: https://i.imgur.com/QYs8Ug8.png
Bug: 408940901
Fixed: 409179188
Change-Id: I8deb54cc5d2ec1724211ec372ad15323738ee67f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6434119
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
(cherry picked from commit 2e5bee2)
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6438996
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Kim-Anh Tran <kimanh@chromium.org>
Partial revert of https://crrev.com/c/6293325

Bug: 409086863
Fixed: 410040501
Change-Id: I1b9f58ef3ee364af2c919df3162f2be1f7dcb143
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6448573
Auto-Submit: Connor Clark <cjamcl@chromium.org>
Reviewed-by: Paul Irish <paulirish@chromium.org>
Commit-Queue: Connor Clark <cjamcl@chromium.org>
(cherry picked from commit 5e20990)
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6455510
Commit-Queue: Paul Irish <paulirish@chromium.org>
Bug: 409033193
Fixed: 409199516
Change-Id: I621d7ef22c8a63305e3b41bafc2106e59c33e9a7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6432956
Auto-Submit: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
(cherry picked from commit 31fc845)
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6455745
Bug: 408244902
Fixed: 409200069
Change-Id: I796e53b62a01219c84742373bf6e00c027f32560
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6436657
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Auto-Submit: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
(cherry picked from commit e8b639c)
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6456264
Bug: 408225523, 409188467
Change-Id: I371728da766b9a12393a925b0c54508bf3392d57
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6440816
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
Auto-Submit: Kim-Anh Tran <kimanh@chromium.org>
(cherry picked from commit 2816e66)
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6456625
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bug: 409325196
Fixed: 409341424
Change-Id: I1a51b5ed045b5a334a6407b693709c3cd12af67a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6439041
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
(cherry picked from commit 93ebef8)
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6456626
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bug: 408225523
Fixed: 409188467
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6439159
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
Auto-Submit: Kim-Anh Tran <kimanh@chromium.org>
(cherry picked from commit a1dabaf)
Change-Id: Ifd851a4507c2e34de36338a1b0bb538f24554ba6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6456627
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Note: This does not fix the behavior that the text of a tooltip is being selected if the anchor had an active text selection before hovering.

Change-Id: I15135dfbb040ef60af83b00ac14df38c59d522f8
Bug: 409988275
Fixed: 410486388
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6448276
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
(cherry picked from commit e265def)
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6458418
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
Bug: 408145209, 411315974
Change-Id: I25bc8902ea54c3dc994b9e00dce11351dc7221b7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6430184
Auto-Submit: Eric Leese <leese@chromium.org>
Reviewed-by: Liviu Rau <liviurau@chromium.org>
Commit-Queue: Liviu Rau <liviurau@chromium.org>
Commit-Queue: Eric Leese <leese@chromium.org>
(cherry picked from commit e4c5ad5)
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6468181
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bug: 408145209
Fixed: 411315974
Change-Id: I7246d08a8ff033c081a141b49ded7070f977ddd6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6429854
Commit-Queue: Eric Leese <leese@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Liviu Rau <liviurau@chromium.org>
(cherry picked from commit 9876f54)
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6468182
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bug: 409985196
Fixed: 410515701
Change-Id: Ie7d1cd7bd470faf8814689840c9436cdd64ef09f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6450702
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Auto-Submit: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
(cherry picked from commit 5378490)
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6461929
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bug: 411728380
Fixed: 412378555
Change-Id: Ibf062a17e1a6ba30d53dab9d7530dcf88b141917
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6472150
Reviewed-by: Paul Irish <paulirish@chromium.org>
Commit-Queue: Connor Clark <cjamcl@chromium.org>
Auto-Submit: Connor Clark <cjamcl@chromium.org>
(cherry picked from commit 4ef47f3)
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6476926
Commit-Queue: Paul Irish <paulirish@chromium.org>
Bug: 411285104
Fixed: 411310102
Change-Id: Icf309edf064a05a650b5d45754b58dfb7485347e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6468177
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Auto-Submit: Danil Somsikov <dsv@chromium.org>
(cherry picked from commit 0b33e61)
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6476907
Auto-Submit: Connor Clark <cjamcl@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Paul Irish <paulirish@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
The UI was previously freezing when the user tries to render large values.

We are now truncating the value to 4096 chars.

Bug: 408976043
Fixed: 410744529
Change-Id: I75fec294ae474b6cc5871fc5c9c6e722561b122a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6455747
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
(cherry picked from commit b75904f)
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6476906
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Paul Irish <paulirish@chromium.org>
Auto-Submit: Connor Clark <cjamcl@google.com>
Bug: 410511500
Fixed: 412033240
Change-Id: I78c45a79d7a26ca0bd838a7c25352934e8e38ae0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6454343
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
(cherry picked from commit 272fb83)
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6475146
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Commit-Queue: Paul Irish <paulirish@chromium.org>
Reviewed-by: Paul Irish <paulirish@chromium.org>
Auto-Submit: Changhao Han <changhaohan@chromium.org>
Bug: 409771454
Change-Id: I19e9840d78ee245c1a15b5d8e65485eb227d4aa1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6459230
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
Auto-Submit: Kateryna Prokopenko <kprokopenko@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
(cherry picked from commit 199588f)
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6513135
Fixed: 418963209,419207279
Change-Id: Ia8324256fb116150d0d4cb093f0889cea293f58c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6563376
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
(cherry picked from commit 01f70bb)
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6606035
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>

@huntie huntie left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, sorry about the merge buttons 🙏🏻

This should either work with:

  • A merge commit (very sure)
  • A rebase merge (should pick the head merge commit only, I think)
@hoxyq hoxyq force-pushed the repo-sync-7103 branch 3 times, most recently from 73da131 to da46353 Compare June 10, 2025 17:45
@hoxyq hoxyq merged commit d449be9 into main Jun 10, 2025
2 checks passed
@huntie huntie mentioned this pull request Jun 4, 2026
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment