Tags: facebook/rocksdb
Tags
set ignore_unknown_options when parsing options (#13443) Summary: In case the primary host has a new option added which isn't available in the remote worker yet, the remote compaction currently fails. In most cases, these new options are not relevant to the remote compaction and the worker should be able to move on by ignoring it. Pull Request resolved: #13443 Test Plan: Verified internally in Meta Infra. Reviewed By: anand1976 Differential Revision: D70744359 Pulled By: jaykorean fbshipit-source-id: eb6a388c2358a7f8089f2e35a378b7017b9e03f3
Introduce kAborted Status (#13438) Summary: If compaction job needs to be aborted inside `Schedule()` or `Wait()` today (e.g. Primary host is shutting down), the only two options are the following - Handle it as failure by returning `CompactionServiceJobStatus::kFailure` - Return `CompactionServiceJobStatus::kUseLocal` and let the compaction move on locally and eventually succeed or fail depending on the timing In this PR, we are introducing a new status, `CompactionServiceJobStatus::kAborted`, so that the implementation of `Schedule()` and `Wait()` can return it. Just like how `CompactionServiceJobStatus::kFailure` is handled, compaction will not move on and fail, but the status will be returned as `Status::Aborted()` instead of `Status::Incomplete()` Pull Request resolved: #13438 Test Plan: Unit Test added ``` ./compaction_service_test --gtest_filter="*CompactionServiceTest.AbortedWhileWait*" ``` Reviewed By: anand1976, hx235 Differential Revision: D70655355 Pulled By: jaykorean fbshipit-source-id: 22614ce9c7455cda649b15465625edc93978fe11