restricted_paths: rename test builder to with_path_restriction_metadata

Summary:
## This stack
Decouple restricted_paths config from the manifest_id store (T277178795). Replace `path_acls` (path -> ACL) with per-path `PathRestrictionMetadata` carrying the REPO_REGION ACL and optional permission-request group, so a future `read_only` flag can freeze manifest-id-store growth without dropping enforcement. Thrift `path_acls` is retained as a parser fallback. The configerator thrift source is the separately-published D109697491.

## This diff (no-op)
Rename `RestrictedPathsConfigBuilder::with_path_acl_str` to `with_path_restriction_metadata` and update all callsites. Pure rename — no behaviour change.

Reviewed By: lmvasquezg

Differential Revision: D109827028

fbshipit-source-id: 15f4f263c87fb3f9eb5f768a3ed8893571f5ba87

Author: gustavoavena

eden/mononoke/repo_attributes/restricted_paths/src/lib.rs

@@ -1030,8 +1030,8 @@ mod tests {
     #[mononoke::fbinit_test]
     async fn test_with_config(fb: FacebookInit) -> Result<()> {
         let config = RestrictedPathsConfigBuilder::new()
-            .with_path_acl_str("restricted/dir", "SERVICE_IDENTITY:restricted_acl")?
-            .with_path_acl_str("other/restricted", "SERVICE_IDENTITY:other_acl")?
+            .with_path_restriction_metadata("restricted/dir", "SERVICE_IDENTITY:restricted_acl")?
+            .with_path_restriction_metadata("other/restricted", "SERVICE_IDENTITY:other_acl")?
             .build();
 
         let repo_restricted_paths = build_test_restricted_paths(fb, config).await?;
@@ -1044,7 +1044,7 @@ mod tests {
     async fn test_path_matching(fb: FacebookInit) -> Result<()> {
         let restricted_acl = MononokeIdentity::from_str("SERVICE_IDENTITY:restricted_acl")?;
         let config = RestrictedPathsConfigBuilder::new()
-            .with_path_acl_str("restricted/dir", &restricted_acl.to_string())?
+            .with_path_restriction_metadata("restricted/dir", &restricted_acl.to_string())?
             .build();
 
         let repo_restricted_paths = build_test_restricted_paths(fb, config).await?;
@@ -1191,7 +1191,7 @@ mod tests {
     #[mononoke::fbinit_test]
     async fn test_disabled_mode_keeps_config_authoritative_lookup(fb: FacebookInit) -> Result<()> {
         let config = RestrictedPathsConfigBuilder::new()
-            .with_path_acl_str("restricted/dir", "SERVICE_IDENTITY:restricted_acl")?
+            .with_path_restriction_metadata("restricted/dir", "SERVICE_IDENTITY:restricted_acl")?
             .build();
         let restricted_paths =
             build_test_restricted_paths_with_options(fb, config, DummyAclProvider::new(fb)?, false)

eden/mononoke/repo_attributes/restricted_paths/src/test_utils.rs

@@ -53,7 +53,11 @@ impl RestrictedPathsConfigBuilder {
         }
     }
 
-    pub(crate) fn with_path_acl_str(mut self, path: &str, identity: &str) -> Result<Self> {
+    pub(crate) fn with_path_restriction_metadata(
+        mut self,
+        path: &str,
+        identity: &str,
+    ) -> Result<Self> {
         self.config.path_restriction_metadata.insert(
             NonRootMPath::new(path)?,
             PathRestrictionMetadata {
@@ -150,7 +154,7 @@ mod tests {
     #[mononoke::test]
     fn test_restricted_paths_config_builder_sets_common_fields() -> Result<()> {
         let config = RestrictedPathsConfigBuilder::new()
-            .with_path_acl_str("restricted", "REPO_REGION:restricted_acl")?
+            .with_path_restriction_metadata("restricted", "REPO_REGION:restricted_acl")?
             .build();
 
         assert!(config.use_manifest_id_cache);