Skip to content

Commit b6f28f6

Browse files
gustavoavenameta-codesync[bot]
authored andcommitted
path_acls: Log ACL check exceptions
Summary: As title. ___ Differential Revision: D110153520 fbshipit-source-id: d65558c4c97d65dc61afd4106eef7b1b2cb6b36f
1 parent 9990781 commit b6f28f6

1 file changed

Lines changed: 13 additions & 1 deletion

File tree

‎eden/mononoke/repo_attributes/restricted_paths/src/restriction_check.rs‎

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -659,6 +659,12 @@ async fn has_repo_region_acls_for_action(
659659
.buffer_unordered(acls.len())
660660
.try_all(futures::future::ready)
661661
.await
662+
.inspect_err(|err| {
663+
ctx.scuba().clone().log_with_msg(
664+
"Failed repo region ACL check",
665+
format!("ACLs: {acls:?}. Action {action}. Exception: {err:#?}"),
666+
);
667+
})
662668
}
663669

664670
/// Check whether the caller is a member of the admin bypass group, if one is
@@ -683,7 +689,13 @@ pub(crate) async fn is_part_of_group(
683689
let membership_checker = acl_provider
684690
.group(group_name)
685691
.await
686-
.with_context(|| format!("Failed to get membership checker for group {group_name}"))?;
692+
.with_context(|| format!("Failed to get membership checker for group {group_name}"))
693+
.inspect_err(|err| {
694+
ctx.scuba().clone().log_with_msg(
695+
"Failed to get membership checker for group",
696+
format!("Group: {group_name}. Exception: {err:#?}"),
697+
);
698+
})?;
687699

688700
Ok(membership_checker
689701
.is_member(ctx.metadata().identities())

0 commit comments

Comments
 (0)