mononoke: remove stale #[allow(dead_code)] silencers on live code

Summary: Remove stale `#[allow(dead_code)]` attributes that mask unused code warnings, as confirmed by `arc rust-check`. These silencers can hide handler-registration bugs, like the one in D90503346 where `StreamingCloneHandler` was never registered. By removing them, the compiler can catch future regressions. This cleanup affects various modules, ensuring the compiler checks for dead code correctly.

Reviewed By: lmvasquezg

Differential Revision: D110174839

fbshipit-source-id: fdee189134ae88d7cf1e1323a521ce0bafee00ab

Author: Clara Rull

eden/mononoke/clients/scsc/src/library/commit.rs

@@ -131,7 +131,6 @@ fn render_date(
     Ok(())
 }
 
-#[allow(dead_code)]
 pub(crate) fn render_commit_summary(
     commit: &CommitInfo,
     requested: &str,

eden/mononoke/clients/scsc/src/util.rs

@@ -47,7 +47,6 @@ pub(crate) fn byte_count_iec(size: i64) -> String {
 
 /// Convert a byte count to a human-readable representation of the byte count
 /// using short suffixes.
-#[allow(dead_code)]
 pub(crate) fn byte_count_short(size: i64) -> String {
     byte_count(size, "", "", &["K", "M", "G", "T", "P", "E", "Z", "Y"])
 }

eden/mononoke/common/reloader/src/lib.rs

@@ -49,7 +49,6 @@ impl<R> Reloader<R> {
     }
 
     // Only used in tests
-    #[allow(dead_code)]
     pub async fn wait_for_update(&self) {
         self.notify.notified().await;
     }

eden/mononoke/common/time_measuring/src/speed_sliding_window.rs

@@ -137,7 +137,6 @@ impl BasicSpeedTracker {
         }
     }
 
-    #[allow(dead_code)]
     pub fn add_entry(&mut self) {
         self.add_entries(1)
     }

eden/mononoke/features/hooks/src/implementations/limit_users_directory_size.rs

@@ -50,7 +50,6 @@ const MAX_CONCURRENCY: usize = 100;
 /// This prevents individual user directories from growing too large due
 /// to RADAR rollout, which creates per-user working directories under
 /// this path.
-#[allow(dead_code)]
 #[derive(Deserialize, Clone, Debug)]
 pub struct LimitUsersDirectorySizeConfig {
     /// Max allowed recursive size in bytes for any directory at depth 2
@@ -63,13 +62,11 @@ pub struct LimitUsersDirectorySizeConfig {
     path_prefix: String,
 }
 
-#[allow(dead_code)]
 #[derive(Clone, Debug)]
 pub struct LimitUsersDirectorySizeHook {
     config: LimitUsersDirectorySizeConfig,
 }
 
-#[allow(dead_code)]
 impl LimitUsersDirectorySizeHook {
     pub fn new(config: &HookConfig) -> Result<Self> {
         Self::with_config(config.parse_options()?)

eden/mononoke/features/hooks/src/lua_pattern.rs

@@ -154,7 +154,6 @@ impl LuaPattern {
         self.regex.is_match(s).unwrap_or(false)
     }
 
-    #[allow(dead_code)]
     pub fn get_regex(&self) -> &Regex {
         &self.regex
     }

eden/mononoke/jobs/cas_sync/src/errors.rs

@@ -29,7 +29,6 @@ pub enum PipelineError {
         cause: Error,
     },
 
-    #[allow(dead_code)]
     #[error("error without tracking entry")]
     AnonymousError {
         #[source]

eden/mononoke/repo_attributes/bonsai_tag_mapping/src/cache.rs

@@ -44,7 +44,6 @@ pub struct CachedBonsaiTagMapping {
     updater_task: JoinHandle<()>,
 }
 
-#[allow(dead_code)]
 impl CachedBonsaiTagMapping {
     pub async fn new(
         ctx: &CoreContext,

eden/mononoke/repo_attributes/git_ref_content_mapping/src/cache.rs

@@ -40,7 +40,6 @@ pub struct CachedGitRefContentMapping {
     updater_task: JoinHandle<()>,
 }
 
-#[allow(dead_code)]
 impl CachedGitRefContentMapping {
     pub async fn new(
         ctx: &CoreContext,

eden/mononoke/tools/admin/src/commands/blobstore_bulk_unlink.rs

@@ -147,7 +147,6 @@ async fn unlink_the_key_from_blobstore(
     Ok(())
 }
 
-#[allow(dead_code)]
 struct BlobstoreBulkUnlinker {
     app: MononokeApp,
     keys_dir: String,