Skip to content

fix: pinning commons-codec dependency in google-api-client#2201

Merged
gcf-merge-on-green[bot] merged 4 commits intogoogleapis:mainfrom
alicejli:updatePom
Dec 2, 2022
Merged

fix: pinning commons-codec dependency in google-api-client#2201
gcf-merge-on-green[bot] merged 4 commits intogoogleapis:mainfrom
alicejli:updatePom

Conversation

@alicejli
Copy link
Copy Markdown
Contributor

@alicejli alicejli commented Dec 2, 2022

Turns out #2195 only fixed half the issue. commons-codec needs to be declared as a dependency within the google-api-client's pom.xml as well.
@alicejli alicejli requested a review from a team December 2, 2022 19:51
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Dec 2, 2022
@suztomo
Copy link
Copy Markdown
Member

suztomo commented Dec 2, 2022 

[INFO] --- maven-dependency-plugin:3.3.0:analyze (default-cli) @ google-api-client ---
Warning:  Unused declared dependencies found:
Warning:     commons-codec:commons-codec:jar:1.15:compile
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Dec 2, 2022
@suztomo
Copy link
Copy Markdown
Member

suztomo commented Dec 2, 2022

"ci / dependencies (8) (pull_request) Successful in 1m"
@suztomo suztomo added the automerge Merge the pull request once unit tests and other checks pass. label Dec 2, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit 27e94c0 into googleapis:main Dec 2, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 2, 2022
@release-please release-please bot mentioned this pull request Dec 2, 2022
Merged
blakeli0 pushed a commit that referenced this pull request Dec 16, 2022
@alicejli @blakeli0
fix: pinning commons-codec dependency in google-api-client (#2201)
7d99b98 
Turns out https://togithub.com/googleapis/google-api-java-client/pull/2195 only fixed half the issue. `commons-codec` needs to be declared as a dependency within the `google-api-client`'s `pom.xml` as well.
blakeli0 pushed a commit that referenced this pull request Dec 16, 2022
@alicejli @blakeli0
fix: pinning commons-codec dependency in google-api-client (#2201)
1d627dd 
Turns out https://togithub.com/googleapis/google-api-java-client/pull/2195 only fixed half the issue. `commons-codec` needs to be declared as a dependency within the `google-api-client`'s `pom.xml` as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: s Pull request size is small.

2 participants

@alicejli @suztomo