Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: facebookincubator/SocketRocket
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: lisb/SocketRocket
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: lisb-direct
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 20 commits
  • 20 files changed
  • 9 contributors

Commits on Oct 3, 2022

  1. Move shared thread to NSQualityOfServiceUserInitiated

    @ssiner-ninja
    ssiner-ninja committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    7ad331e View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2022

  1. Add support for a not-utf-8 encoded PAC file.

    @nnabeyang
    nnabeyang committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    b2c8a41 View commit details
    Browse the repository at this point in the history

  2. Make converting NSData to NSString more safer in _fetchPAC.

    @nnabeyang
    nnabeyang committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    59eaa05 View commit details
    Browse the repository at this point in the history

  3. Remove Support for PAC in Shift-JIS without any configuration.

    @nnabeyang
    nnabeyang committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    c023150 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'fix-qos-thread' into lisb-direct

    @nnabeyang
    nnabeyang committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    e8d2a3d View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2023

  1. Merge pull request #2 from facebookincubator/main 

    Merge latest original repo(ver 0.7.0) to lisb/SocketRocket
    @shuheyheyhey
    shuheyheyhey authored Jun 29, 2023
    Configuration menu
    Copy the full SHA
    31b6048 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. Add visionOS support

    @gabrieldonadel @nnabeyang
    gabrieldonadel authored and nnabeyang committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    d9a2980 View commit details
    Browse the repository at this point in the history

  2. Replace usage of deprecate OSSpinLock with os_unfair_lock.

    @nlutsenko @nnabeyang
    nlutsenko authored and nnabeyang committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    b0cfb7e View commit details
    Browse the repository at this point in the history

  3. Fix a set of nullable to nonnull implicit conversions.

    @nlutsenko @nnabeyang
    nlutsenko authored and nnabeyang committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    a1edec2 View commit details
    Browse the repository at this point in the history

  4. fbshipit-source-id: 659c6cd3b3a8a4d15ed017b696aaffb98a2fb5cf

    @facebook-github-bot @nnabeyang
    facebook-github-bot authored and nnabeyang committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    1b1493a View commit details
    Browse the repository at this point in the history

  5. SocketRocket | Add line break to submodule.txt file. 

    Summary: Adding line breaks to see if this fixes the infra.

Reviewed By: richardjrossiii

Differential Revision: D62052882

fbshipit-source-id: 7ff4d7247a9538b90420bb5cc4ff97e9739aab7c
    @nlutsenko @nnabeyang
    nlutsenko authored and nnabeyang committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    b72dd82 View commit details
    Browse the repository at this point in the history

  6. Prepare for 0.7.1 release. (#688) 

    Summary: Pull Request resolved: #688

Test Plan: `pod lib lint` passes

Reviewed By: richardjrossiii

Differential Revision: D61995551

Pulled By: nlutsenko

fbshipit-source-id: 9cb88c8e8b6afb1ebbfd0821e7f426ffe45998e0
    @nlutsenko @nnabeyang
    nlutsenko authored and nnabeyang committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    75a6503 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. Merge pull request #3 from lisb/lisb-direct_0.7.1 

    v0.7.1
    @nnabeyang
    nnabeyang authored Oct 9, 2024
    Configuration menu
    Copy the full SHA
    90af9b8 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. Add info about visionOS support in README (#689) 

    Summary: Pull Request resolved: #689

Reviewed By: nlutsenko

Differential Revision: D62575033

Pulled By: cipolleschi

fbshipit-source-id: 492b8c722b19ea5a9ee22dd9bec7654a388dff7b
    @tomekzaw @nnabeyang
    tomekzaw authored and nnabeyang committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    b6b05b8 View commit details
    Browse the repository at this point in the history

  2. Ensure readyState is set to SR_CLOSED on successful WebSocket closure (… 

    …#693)

Summary:
This PR fixes an issue where the `readyState` was not properly set to `SR_CLOSED` when the WebSocket closed successfully.

### Changes:
- Previously, during a successful WebSocket closure, the `readyState` remained at `SR_CLOSING` and was not updated to `SR_CLOSED`.
- With this fix, the `readyState` is now set to `SR_CLOSED` before the delegate method responsible for handling the WebSocket closure is called.

Pull Request resolved: #693

Reviewed By: nlutsenko

Differential Revision: D64108852

Pulled By: cipolleschi

fbshipit-source-id: d683d951e3b0069f1e909c091e8bc4e5d5066dab
    @nnabeyang
    nnabeyang committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    fddaadd View commit details
    Browse the repository at this point in the history

  3. v0.7.2(lisb)

    @nnabeyang
    nnabeyang committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    64a6f8d View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2025

  1. Add Swift Package Manager support

    @nnabeyang
    nnabeyang committed Sep 5, 2025
    Configuration menu
    Copy the full SHA
    0507b55 View commit details
    Browse the repository at this point in the history

  2. Update .gitignore to exclude SwiftPM .build directory

    @nnabeyang
    nnabeyang committed Sep 5, 2025
    Configuration menu
    Copy the full SHA
    932a630 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2025

  1. Merge pull request #4 from lisb/feature/support-spm 

    Add Swift Package Manager support
    @nnabeyang
    nnabeyang authored Sep 18, 2025
    Configuration menu
    Copy the full SHA
    4334a0d View commit details
    Browse the repository at this point in the history

  2. v0.7.3(lisb)

    @nnabeyang
    nnabeyang committed Sep 18, 2025
    Configuration menu
    Copy the full SHA
    1669d8c View commit details
    Browse the repository at this point in the history
Loading