Reword misleading Merging is blocked
#186005
Replies: 2 comments
-
|
💬 Your Product Feedback Has Been Submitted 🎉 Thank you for taking the time to share your insights with us! Your feedback is invaluable as we build a better GitHub experience for all our users. Here's what you can expect moving forward ⏩
Where to look to see what's shipping 👀
What you can do in the meantime 💻
As a member of the GitHub community, your participation is essential. While we can't promise that every suggestion will be implemented, we want to emphasize that your feedback is instrumental in guiding our decisions and priorities. Thank you once again for your contribution to making GitHub even better! We're grateful for your ongoing support and collaboration in shaping the future of our platform. ⭐ |
Beta Was this translation helpful? Give feedback.
-
|
The “Merging is blocked” message is misleading in this situation. In my case, the pull request is not blocked by any rules (such as required reviews, failing checks, or branch protection). The only reason it cannot be merged is because I do not have write access to the target branch, and only a maintainer can merge it. However, the current section title “Merging is blocked” incorrectly suggests that there is an actual restriction or failure preventing the merge. Expected Behavior When no rules are blocking a pull request and the PR is only awaiting a maintainer with write access, the section title should be changed to something clearer, such as: Pending merge Awaiting merge Waiting to be merged The explanation text below the section already correctly states that only users with write access can merge, so updating the title would improve clarity and avoid confusion for contributors. Actual Behavior The UI shows “Merging is blocked”, even though the PR is mergeable and only requires a maintainer to perform the merge. Impact This wording can confuse contributors and make them think there is a problem with their pull request when there isn’t one. |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Select Topic Area
Bug
Body
Actually not. The PR is not blocked by anything; it's just I can't do that on my own. The text is misleading.
Expected: When there's no rules blocking PR merging, but only awaiting a maintainer to merge it manually, change the section title to
"Pending mergeAwaiting mergeorWaiting to be merged. The explaination under the section title already said that only users with write access can merge it.Beta Was this translation helpful? Give feedback.
All reactions