"Questions" option for reviews?

[slushman]

Select Topic Area

Product Feedback

Body

In addition to the current "Comment", "Approve", and "Request Changes", I often find I need a "Discussion Needed" option needed when code reviewing. I don't necessarily want to request changes, but its more than just a comment. I need feedback from the dev before I could choose to approve or request changes.

I would think this prevents a merge because the outcome of the discussion determines which path the reveiwer would take.

[github-actions[bot]]

💬 Your Product Feedback Has Been Submitted 🎉

Thank you for taking the time to share your insights with us! Your feedback is invaluable as we build a better GitHub experience for all our users.

Here's what you can expect moving forward ⏩

• Your input will be carefully reviewed and cataloged by members of our product teams. 
  • Due to the high volume of submissions, we may not always be able to provide individual responses.
  • Rest assured, your feedback will help chart our course for product improvements.
• Other users may engage with your post, sharing their own perspectives or experiences. 
• GitHub staff may reach out for further clarification or insight. 
  • We may 'Answer' your discussion if there is a current solution, workaround, or roadmap/changelog post related to the feedback.

Where to look to see what's shipping 👀

• Read the Changelog for real-time updates on the latest GitHub features, enhancements, and calls for feedback.
• Explore our Product Roadmap, which details upcoming major releases and initiatives.

What you can do in the meantime 💻

• Upvote and comment on other user feedback Discussions that resonate with you.
• Add more information at any point! Useful details include: use cases, relevant labels, desired outcomes, and any accompanying screenshots.

As a member of the GitHub community, your participation is essential. While we can't promise that every suggestion will be implemented, we want to emphasize that your feedback is instrumental in guiding our decisions and priorities.

Thank you once again for your contribution to making GitHub even better! We're grateful for your ongoing support and collaboration in shaping the future of our platform. ⭐

[parthhanda]

I think i get what you’re saying. There are definitely times during a review where you’re not ready to approve or request changes, but you also feel that a simple comment doesn’t fully capture that you’re waiting for clarification before making a decision.

From what I’ve seen though, GitHub’s intended workflow for this is basically to use “Comment” for that situation. You leave your feedback or questions there, the author responds or updates the PR, and then you come back later and submit either Approve or Request changes once things are clearer.

If the repo has required approvals or branch protection, the PR won’t merge until someone approves anyway, so the discussion naturally happens before that step.

I do agree that a “Discussion needed” option could make that state clearer in the review process, especially in bigger teams. But right now it seems like comments + a follow-up review is the closest thing to that workflow.

[ma-rajan]

Yeah I get what you mean bro. Sometimes “Comment” feels too light and “Request Changes” feels too harsh 😅

Your idea of a “Discussion Needed” option actually makes sense — like a middle ground where you’re basically saying “let’s talk first before deciding.”

For now though, what I usually do is just use “Request Changes” but mention in the comment that it’s for discussion/clarification, not a strict rejection. Or just leave detailed comments and hold off on approving.

But yeah, having that extra option would make things way clearer and cleaner in reviews.