fix: progress indicator#5557
Merged
alexander-akait merged 1 commit intoAug 9, 2025
Merged
Conversation
sets the pointer events to none on the progress indicator
calebdwilliams
requested review from
alexander-akait,
anshumanv,
hiroppy and
snitin315
as code owners
The committers listed above are authorized under a signed CLA. |
alexander-akait
approved these changes
Aug 9, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5557 +/- ##
==========================================
+ Coverage 83.31% 83.41% +0.09%
==========================================
Files 13 13
Lines 2038 2038
Branches 750 750
==========================================
+ Hits 1698 1700 +2
+ Misses 306 304 -2
Partials 34 34 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
👋 @alexander-akait Is there any chance you could cut a new release with this change included? Thanks! |
Member
|
@prichey Yeah, we will need to do it, ping me at the end of week, I want to finish a couple more things |
|
Great, thanks! |
|
@alexander-akait bump! 🙂 |
Contributor
Author
|
Could we get this released? |
Contributor
Author
|
Bump |
Member
|
Already released - https://github.com/webpack/webpack-dev-server/releases/tag/v5.2.3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
No, this is only a CSS addition to the progress indicator setting
pointer-events: none;this prevents the element from sitting on top of the DOM and blocking users from being able to click on that region of their screen.Motivation / Use-Case
With the progress indicator enabled, the
HTMLElementpersists in the DOM and is overlaying a large portion preventing users from clicking that region even if the element is invisible.Breaking Changes
N/A
Additional Info