MediaWiki-Page-diffsComponent
ActivePublic
Watch Project

Members (2)

Watchers

This project does not have any watchers.
View All

Details

Source Repo: https://gerrit.wikimedia.org/g/mediawiki/core/

Description

The Page diff system deals with rendering of differences between two versions of page content. This includes the DifferenceEngine, and the frontend routing logic for it such as the diff= query parameter, and the Special:Diff redirect.

This project is part of the core MediaWiki software itself.

The below are not part of this system:

For the algorithm itself to create diffs, see wikidiff2.
For viewing the history of revisions via the action=history view or Special:History page, see MediaWiki-Page-history
For the storage of comments (e.g. edit summaries), see MediaWiki-Comment-store.
For the abstraction layers for revisions and pages, including their storage interfaces, and their database schemas, see MediaWiki-Core-Revision-backend
For the management of data derived from pages, see MediaWiki-Page-derived-data.
For the user interface and API for creating and editing pages, see MediaWiki-Page-editing.
For the interpretation and rendering of wiki content, see MediaWiki-ContentHandler.

Recent Activity
View All

Yesterday

PatchDemoBot added a comment to T357352: Thanks button is obscured on mobile diffs in visual diff mode.

Test wiki on Patch demo by SCardenas (WMF) using patch(es) linked to this task was deleted:

Sun, Oct 5, 4:29 PM · Patch-For-Review, MW-1.45-notes (1.45.0-wmf.21; 2025-09-30), Moderator-Tools-Team (Kanban), VisualEditor, MediaWiki-Page-diffs, VisualEditor-VisualDiffs

PatchDemoBot added a comment to T402297: It should be possible to undo edits on mobile.

Test wiki on Patch demo by SCardenas (WMF) using patch(es) linked to this task was deleted:

Sun, Oct 5, 4:29 PM · Patch-For-Review, Moderator-Tools-Team (Kanban), Mobile, MediaWiki-Page-diffs

Sat, Oct 4

Aklapper added a comment to T402489: Weird behavior when replying in diffs.

Which exact version and branch of the DiscussionTools extension is installed?

Sat, Oct 4, 5:17 PM · DiscussionTools, MediaWiki-Page-diffs

Scardenasmolinar added a comment to T402297: It should be possible to undo edits on mobile.

Thanks for pointing those errors out!

Sat, Oct 4, 12:25 AM · Patch-For-Review, Moderator-Tools-Team (Kanban), Mobile, MediaWiki-Page-diffs

Fri, Oct 3

Jdlrobson-WMF added a comment to T402297: It should be possible to undo edits on mobile.

Hey @Scardenasmolinar its quite common for users to have lots of groups and large edit counts. Here's some examples of overlap I noted on the ticket:

Screenshot 2025-10-03 at 3.43.56 PM.png (161×495 px, 15 KB)

Screenshot 2025-10-03 at 3.42.48 PM.png (173×492 px, 16 KB)

Screenshot 2025-10-03 at 3.45.04 PM.png (169×370 px, 20 KB)

Fri, Oct 3, 10:45 PM · Patch-For-Review, Moderator-Tools-Team (Kanban), Mobile, MediaWiki-Page-diffs

Scardenasmolinar added a comment to T357352: Thanks button is obscured on mobile diffs in visual diff mode.

I checked on enwiki in Firefox Desktop, and the thanks button is showing up, but it's not showing up in Safari.

Fri, Oct 3, 7:45 PM · Patch-For-Review, MW-1.45-notes (1.45.0-wmf.21; 2025-09-30), Moderator-Tools-Team (Kanban), VisualEditor, MediaWiki-Page-diffs, VisualEditor-VisualDiffs

PatchDemoBot added a comment to T357352: Thanks button is obscured on mobile diffs in visual diff mode.

Test wiki created on Patch demo by SCardenas (WMF) using patch(es) linked to this task:
https://4659f97b59.catalyst.wmcloud.org/w/

Fri, Oct 3, 7:18 PM · Patch-For-Review, MW-1.45-notes (1.45.0-wmf.21; 2025-09-30), Moderator-Tools-Team (Kanban), VisualEditor, MediaWiki-Page-diffs, VisualEditor-VisualDiffs

Scardenasmolinar added a comment to T357352: Thanks button is obscured on mobile diffs in visual diff mode.

In T357352#11240415, @Samwalton9-WMF wrote:

In T357352#11234670, @jsn.sherman wrote:

We noticed this on an iPhone SE 2020
, but haven't been able to reproduce elsewhere; looking into it

Where was this happening, test.wiki, or in a patch demo?

Can't reproduce on an iPhone 11 in Safari, for users with short or long usernames, in Visual or Wikitext diffs, on test.wikipedia.org.

Fri, Oct 3, 5:41 PM · Patch-For-Review, MW-1.45-notes (1.45.0-wmf.21; 2025-09-30), Moderator-Tools-Team (Kanban), VisualEditor, MediaWiki-Page-diffs, VisualEditor-VisualDiffs

Samwalton9-WMF added a comment to T357352: Thanks button is obscured on mobile diffs in visual diff mode.

In T357352#11234670, @jsn.sherman wrote:

We noticed this on an iPhone SE 2020
, but haven't been able to reproduce elsewhere; looking into it

Fri, Oct 3, 10:09 AM · Patch-For-Review, MW-1.45-notes (1.45.0-wmf.21; 2025-09-30), Moderator-Tools-Team (Kanban), VisualEditor, MediaWiki-Page-diffs, VisualEditor-VisualDiffs

gerritbot added a project to T357352: Thanks button is obscured on mobile diffs in visual diff mode: Patch-For-Review.

Fri, Oct 3, 4:39 AM · Patch-For-Review, MW-1.45-notes (1.45.0-wmf.21; 2025-09-30), Moderator-Tools-Team (Kanban), VisualEditor, MediaWiki-Page-diffs, VisualEditor-VisualDiffs

gerritbot added a comment to T357352: Thanks button is obscured on mobile diffs in visual diff mode.

Change #1191558 restored by Scardenasmolinar:

[mediawiki/skins/MinervaNeue@master] Minerva VE Diff: Add z-index to mw-diff-ntitle1

https://gerrit.wikimedia.org/r/1191558

Fri, Oct 3, 4:39 AM · Patch-For-Review, MW-1.45-notes (1.45.0-wmf.21; 2025-09-30), Moderator-Tools-Team (Kanban), VisualEditor, MediaWiki-Page-diffs, VisualEditor-VisualDiffs

Thu, Oct 2

Scardenasmolinar moved T357352: Thanks button is obscured on mobile diffs in visual diff mode from Ready (Maintenance) to In Progress on the Moderator-Tools-Team (Kanban) board.

Thu, Oct 2, 4:43 PM · Patch-For-Review, MW-1.45-notes (1.45.0-wmf.21; 2025-09-30), Moderator-Tools-Team (Kanban), VisualEditor, MediaWiki-Page-diffs, VisualEditor-VisualDiffs

Kgraessle moved T357352: Thanks button is obscured on mobile diffs in visual diff mode from QA to Ready (Maintenance) on the Moderator-Tools-Team (Kanban) board.

Thu, Oct 2, 4:38 PM · Patch-For-Review, MW-1.45-notes (1.45.0-wmf.21; 2025-09-30), Moderator-Tools-Team (Kanban), VisualEditor, MediaWiki-Page-diffs, VisualEditor-VisualDiffs

Wed, Oct 1

jsn.sherman added a comment to T357352: Thanks button is obscured on mobile diffs in visual diff mode.

We noticed this on an iPhone SE 2020

, but haven't been able to reproduce elsewhere; looking into it

Wed, Oct 1, 6:35 PM · Patch-For-Review, MW-1.45-notes (1.45.0-wmf.21; 2025-09-30), Moderator-Tools-Team (Kanban), VisualEditor, MediaWiki-Page-diffs, VisualEditor-VisualDiffs

PatchDemoBot added a comment to T402297: It should be possible to undo edits on mobile.

Test wiki created on Patch demo by SCardenas (WMF) using patch(es) linked to this task:
https://2f174c3d9a.catalyst.wmcloud.org/w/

Wed, Oct 1, 2:55 AM · Patch-For-Review, Moderator-Tools-Team (Kanban), Mobile, MediaWiki-Page-diffs

PatchDemoBot added a comment to T357352: Thanks button is obscured on mobile diffs in visual diff mode.

Test wiki on Patch demo by SCardenas (WMF) using patch(es) linked to this task was deleted:

Wed, Oct 1, 2:52 AM · Patch-For-Review, MW-1.45-notes (1.45.0-wmf.21; 2025-09-30), Moderator-Tools-Team (Kanban), VisualEditor, MediaWiki-Page-diffs, VisualEditor-VisualDiffs

gerritbot added a comment to T402297: It should be possible to undo edits on mobile.

Change #1192651 had a related patch set uploaded (by Scardenasmolinar; author: Scardenasmolinar):

[mediawiki/core@master] WIP: Change undo link to fake button

https://gerrit.wikimedia.org/r/1192651

Wed, Oct 1, 12:35 AM · Patch-For-Review, Moderator-Tools-Team (Kanban), Mobile, MediaWiki-Page-diffs

gerritbot added a comment to T402297: It should be possible to undo edits on mobile.

Change #1192650 had a related patch set uploaded (by Scardenasmolinar; author: Scardenasmolinar):

[mediawiki/extensions/Thanks@master] Change thanks button style for Minerva

https://gerrit.wikimedia.org/r/1192650

Wed, Oct 1, 12:22 AM · Patch-For-Review, Moderator-Tools-Team (Kanban), Mobile, MediaWiki-Page-diffs

Tue, Sep 30

Scardenasmolinar added a comment to T402297: It should be possible to undo edits on mobile.

In T402297#11221166, @OTichonova wrote:

Hi @Scardenasmolinar!

Here are the designs:
They are a little bit different to the ones we discussed in RTL . Since having the buttons side by side might be tricky for languages that have really long names for the actions (ml wiki example below).

Card en Card ml Mobile en Mobile ml

cc @Samwalton9-WMF

Tue, Sep 30, 4:05 AM · Patch-For-Review, Moderator-Tools-Team (Kanban), Mobile, MediaWiki-Page-diffs

Mon, Sep 29

Kgraessle moved T357352: Thanks button is obscured on mobile diffs in visual diff mode from Reviewed (waiting for changes) to QA on the Moderator-Tools-Team (Kanban) board.

Mon, Sep 29, 4:57 PM · Patch-For-Review, MW-1.45-notes (1.45.0-wmf.21; 2025-09-30), Moderator-Tools-Team (Kanban), VisualEditor, MediaWiki-Page-diffs, VisualEditor-VisualDiffs

Kgraessle moved T357352: Thanks button is obscured on mobile diffs in visual diff mode from In Progress to Reviewed (waiting for changes) on the Moderator-Tools-Team (Kanban) board.

Mon, Sep 29, 4:57 PM · Patch-For-Review, MW-1.45-notes (1.45.0-wmf.21; 2025-09-30), Moderator-Tools-Team (Kanban), VisualEditor, MediaWiki-Page-diffs, VisualEditor-VisualDiffs

Kgraessle moved T357352: Thanks button is obscured on mobile diffs in visual diff mode from QA to In Progress on the Moderator-Tools-Team (Kanban) board.

Mon, Sep 29, 4:56 PM · Patch-For-Review, MW-1.45-notes (1.45.0-wmf.21; 2025-09-30), Moderator-Tools-Team (Kanban), VisualEditor, MediaWiki-Page-diffs, VisualEditor-VisualDiffs

Fri, Sep 26

ReleaseTaggerBot added a project to T357352: Thanks button is obscured on mobile diffs in visual diff mode: MW-1.45-notes (1.45.0-wmf.21; 2025-09-30).

Fri, Sep 26, 10:00 PM · Patch-For-Review, MW-1.45-notes (1.45.0-wmf.21; 2025-09-30), Moderator-Tools-Team (Kanban), VisualEditor, MediaWiki-Page-diffs, VisualEditor-VisualDiffs

Maintenance_bot removed a project from T357352: Thanks button is obscured on mobile diffs in visual diff mode: Patch-For-Review.

Fri, Sep 26, 9:32 PM · Patch-For-Review, MW-1.45-notes (1.45.0-wmf.21; 2025-09-30), Moderator-Tools-Team (Kanban), VisualEditor, MediaWiki-Page-diffs, VisualEditor-VisualDiffs

jsn.sherman moved T357352: Thanks button is obscured on mobile diffs in visual diff mode from Eng review to QA on the Moderator-Tools-Team (Kanban) board.

Fri, Sep 26, 9:28 PM · Patch-For-Review, MW-1.45-notes (1.45.0-wmf.21; 2025-09-30), Moderator-Tools-Team (Kanban), VisualEditor, MediaWiki-Page-diffs, VisualEditor-VisualDiffs

gerritbot added a comment to T357352: Thanks button is obscured on mobile diffs in visual diff mode.

Change #1191749 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] VE Diff: Add z-index to div to fix Thank button disappearing

https://gerrit.wikimedia.org/r/1191749

Fri, Sep 26, 9:06 PM · Patch-For-Review, MW-1.45-notes (1.45.0-wmf.21; 2025-09-30), Moderator-Tools-Team (Kanban), VisualEditor, MediaWiki-Page-diffs, VisualEditor-VisualDiffs

OTichonova added a comment to T402297: It should be possible to undo edits on mobile.

Here are the designs:
They are a little bit different to the ones we discussed in RTL . Since having the buttons side by side might be tricky for languages that have really long names for the actions (ml wiki example below).

Fri, Sep 26, 7:41 PM · Patch-For-Review, Moderator-Tools-Team (Kanban), Mobile, MediaWiki-Page-diffs

PatchDemoBot added a comment to T357352: Thanks button is obscured on mobile diffs in visual diff mode.

Test wiki created on Patch demo by SCardenas (WMF) using patch(es) linked to this task:
https://7bc4ad5d82.catalyst.wmcloud.org/w/

Fri, Sep 26, 7:35 PM · Patch-For-Review, MW-1.45-notes (1.45.0-wmf.21; 2025-09-30), Moderator-Tools-Team (Kanban), VisualEditor, MediaWiki-Page-diffs, VisualEditor-VisualDiffs

PatchDemoBot added a comment to T402297: It should be possible to undo edits on mobile.

Test wiki on Patch demo by SCardenas (WMF) using patch(es) linked to this task was deleted:

Fri, Sep 26, 7:34 PM · Patch-For-Review, Moderator-Tools-Team (Kanban), Mobile, MediaWiki-Page-diffs

PatchDemoBot added a comment to T357352: Thanks button is obscured on mobile diffs in visual diff mode.

Test wiki on Patch demo by SCardenas (WMF) using patch(es) linked to this task was deleted:

Fri, Sep 26, 7:33 PM · Patch-For-Review, MW-1.45-notes (1.45.0-wmf.21; 2025-09-30), Moderator-Tools-Team (Kanban), VisualEditor, MediaWiki-Page-diffs, VisualEditor-VisualDiffs

gerritbot added a comment to T357352: Thanks button is obscured on mobile diffs in visual diff mode.

Change #1191558 abandoned by Scardenasmolinar:

[mediawiki/skins/MinervaNeue@master] Minerva VE Diff: Add z-index to mw-diff-ntitle1

Reason:

Abandoned in favor of Ie59eec8739315e076644a4630444e87b99ca482b

https://gerrit.wikimedia.org/r/1191558

Fri, Sep 26, 7:31 PM · Patch-For-Review, MW-1.45-notes (1.45.0-wmf.21; 2025-09-30), Moderator-Tools-Team (Kanban), VisualEditor, MediaWiki-Page-diffs, VisualEditor-VisualDiffs

gerritbot added a comment to T357352: Thanks button is obscured on mobile diffs in visual diff mode.

Change #1191749 had a related patch set uploaded (by Scardenasmolinar; author: Scardenasmolinar):

[mediawiki/extensions/VisualEditor@master] VE Diff: Add z-index to div to fix Thank button disappearing

https://gerrit.wikimedia.org/r/1191749

Fri, Sep 26, 6:49 PM · Patch-For-Review, MW-1.45-notes (1.45.0-wmf.21; 2025-09-30), Moderator-Tools-Team (Kanban), VisualEditor, MediaWiki-Page-diffs, VisualEditor-VisualDiffs

Scardenasmolinar moved T402297: It should be possible to undo edits on mobile from Design review to In Progress on the Moderator-Tools-Team (Kanban) board.

Moving this back to in progress to reflect that I am working on showing the undo button to registered users and waiting on final designs to move this forward. This task is also no longer dependent on the Thank button fix (which is ready for engineering review).

Fri, Sep 26, 4:39 AM · Patch-For-Review, Moderator-Tools-Team (Kanban), Mobile, MediaWiki-Page-diffs

Scardenasmolinar moved T357352: Thanks button is obscured on mobile diffs in visual diff mode from Design review to Eng review on the Moderator-Tools-Team (Kanban) board.

Fri, Sep 26, 4:37 AM · Patch-For-Review, MW-1.45-notes (1.45.0-wmf.21; 2025-09-30), Moderator-Tools-Team (Kanban), VisualEditor, MediaWiki-Page-diffs, VisualEditor-VisualDiffs

PatchDemoBot added a comment to T357352: Thanks button is obscured on mobile diffs in visual diff mode.

Test wiki created on Patch demo by SCardenas (WMF) using patch(es) linked to this task:
https://5a7f313575.catalyst.wmcloud.org/w/

Fri, Sep 26, 4:30 AM · Patch-For-Review, MW-1.45-notes (1.45.0-wmf.21; 2025-09-30), Moderator-Tools-Team (Kanban), VisualEditor, MediaWiki-Page-diffs, VisualEditor-VisualDiffs

gerritbot added a comment to T357352: Thanks button is obscured on mobile diffs in visual diff mode.

Change #1190740 abandoned by Scardenasmolinar:

[mediawiki/extensions/VisualEditor@master] Change thank and undo button's containers depending on Diff type

Reason:

Abandoned in favor of I78aa8faef203dcdd5a2ac2b9aa718aa4b57e2741

https://gerrit.wikimedia.org/r/1190740

Fri, Sep 26, 4:27 AM · Patch-For-Review, MW-1.45-notes (1.45.0-wmf.21; 2025-09-30), Moderator-Tools-Team (Kanban), VisualEditor, MediaWiki-Page-diffs, VisualEditor-VisualDiffs

gerritbot added a comment to T402297: It should be possible to undo edits on mobile.

Change #1190740 abandoned by Scardenasmolinar:

[mediawiki/extensions/VisualEditor@master] Change thank and undo button's containers depending on Diff type

Reason:

Abandoned in favor of I78aa8faef203dcdd5a2ac2b9aa718aa4b57e2741

https://gerrit.wikimedia.org/r/1190740

Fri, Sep 26, 4:27 AM · Patch-For-Review, Moderator-Tools-Team (Kanban), Mobile, MediaWiki-Page-diffs

gerritbot added a comment to T357352: Thanks button is obscured on mobile diffs in visual diff mode.

Change #1191558 had a related patch set uploaded (by Scardenasmolinar; author: Scardenasmolinar):

[mediawiki/skins/MinervaNeue@master] Minerva VE Diff: Add z-index to mw-diff-ntitle1

https://gerrit.wikimedia.org/r/1191558

Fri, Sep 26, 2:22 AM · Patch-For-Review, MW-1.45-notes (1.45.0-wmf.21; 2025-09-30), Moderator-Tools-Team (Kanban), VisualEditor, MediaWiki-Page-diffs, VisualEditor-VisualDiffs

Thu, Sep 25

Samwalton9-WMF added a comment to T402297: It should be possible to undo edits on mobile.

The Undo button is only visible to registered users

Thu, Sep 25, 4:44 PM · Patch-For-Review, Moderator-Tools-Team (Kanban), Mobile, MediaWiki-Page-diffs

Samwalton9-WMF updated the task description for T402297: It should be possible to undo edits on mobile.

Thu, Sep 25, 4:39 PM · Patch-For-Review, Moderator-Tools-Team (Kanban), Mobile, MediaWiki-Page-diffs

Samwalton9-WMF renamed T402297: It should be possible to undo edits on mobile from [SPIKE] It should be possible to undo edits on mobile to It should be possible to undo edits on mobile.

Thu, Sep 25, 4:38 PM · Patch-For-Review, Moderator-Tools-Team (Kanban), Mobile, MediaWiki-Page-diffs

PatchDemoBot added a comment to T357352: Thanks button is obscured on mobile diffs in visual diff mode.

Test wiki on Patch demo by KGraessle-WMF using patch(es) linked to this task was deleted:

Thu, Sep 25, 12:57 PM · Patch-For-Review, MW-1.45-notes (1.45.0-wmf.21; 2025-09-30), Moderator-Tools-Team (Kanban), VisualEditor, MediaWiki-Page-diffs, VisualEditor-VisualDiffs

PatchDemoBot added a comment to T402297: It should be possible to undo edits on mobile.

Test wiki on Patch demo by KGraessle-WMF using patch(es) linked to this task was deleted:

Thu, Sep 25, 12:57 PM · Patch-For-Review, Moderator-Tools-Team (Kanban), Mobile, MediaWiki-Page-diffs

Samwalton9-WMF added a comment to T357352: Thanks button is obscured on mobile diffs in visual diff mode.

Looks good from my testing too.

Thu, Sep 25, 12:52 PM · Patch-For-Review, MW-1.45-notes (1.45.0-wmf.21; 2025-09-30), Moderator-Tools-Team (Kanban), VisualEditor, MediaWiki-Page-diffs, VisualEditor-VisualDiffs