Patch-For-ReviewAutomation Metadata
ActivePublic

Details

Description

A tag automatically added by @gerritbot (patches in Gerrit) or @CodeReviewBot (patches in GitLab).

See wikitech:Gerrit Notification Bot and wikitech:GitLab/Phabricator for more information.

This tag is removed automatically by @Maintenance_bot when all patches attached to the ticket are merged or abandoned.

Recent Activity

Yesterday

Tgr added a comment to T402808: Deploy separate anonymous session backend to Wikimedia production, in log-only mode.

We have the opposite as well, Anonymous data should not be in the authenticated store, although another magnitude less: https://logstash.wikimedia.org/goto/eaf7ca64cd616f3ff220d029b62effec

Sun, Oct 5, 9:40 PM · MW-1.45-notes (1.45.0-wmf.20; 2025-09-23), Patch-For-Review, OKR-Work, MediaWiki-Platform-Team, MediaWiki-Core-AuthManager
Tgr added a comment to T402808: Deploy separate anonymous session backend to Wikimedia production, in log-only mode.

There's 20K Authenticated data should not be in the anonymous store log entries in the last 7 days: https://logstash.wikimedia.org/goto/201c27467af11091c6ce70064ec2b682
This is the same error condition as T405633: Session data is authenticated, should not be an anonymous user (we use the authenticated store but the user ID in the data is 0) except it happens during get() rather than set(). So maybe the same issue? Maybe it happens when we are reading back those set()s? It happens about 10x less often though.

Sun, Oct 5, 9:34 PM · MW-1.45-notes (1.45.0-wmf.20; 2025-09-23), Patch-For-Review, OKR-Work, MediaWiki-Platform-Team, MediaWiki-Core-AuthManager
Tgr added a subtask for T402808: Deploy separate anonymous session backend to Wikimedia production, in log-only mode: T405633: Session data is authenticated, should not be an anonymous user.
Sun, Oct 5, 9:15 PM · MW-1.45-notes (1.45.0-wmf.20; 2025-09-23), Patch-For-Review, OKR-Work, MediaWiki-Platform-Team, MediaWiki-Core-AuthManager
kostajh moved T404204: Investigate options for automatic fallback to FancyCAPTCHA from In progress to Needs review on the Product Safety and Integrity (Sprint Apfel Strudel (Sep 29 - Oct 17)) board.
Sun, Oct 5, 8:25 PM · MW-1.45-notes (1.45.0-wmf.20; 2025-09-23), Product Safety and Integrity (Sprint Apfel Strudel (Sep 29 - Oct 17)), SRE, Patch-For-Review, WE4.2 Bot detection (WE4.2 hCaptcha account creation trial)
gerritbot added a project to T405410: Phase III Short Survey: Patch-For-Review.
Sun, Oct 5, 8:24 PM · Patch-For-Review, Research
Func updated the task description for T406391: Ampersand (&) in raw-text tags output by extensions should not be encoded during OutputTransform.
Sun, Oct 5, 5:56 PM · Content-Transform-Team, Patch-For-Review, MediaWiki-Parser
Maintenance_bot edited projects for T365303: Move update of category members count to CategoryMembershipChangeJob, added: User-notice-archive; removed User-notice.
Sun, Oct 5, 4:31 PM · User-notice-archive, MW-1.45-notes (1.45.0-wmf.16; 2025-08-26), MediaWiki-Platform-Team, DBA, Patch-For-Review, Wikimedia-production-error, Unstewarded-production-error, MediaWiki-Categories, Sustainability (Incident Followup), Wikimedia-Performance-recommendation
PatchDemoBot added a comment to T357352: Thanks button is obscured on mobile diffs in visual diff mode.

Test wiki on Patch demo by SCardenas (WMF) using patch(es) linked to this task was deleted:

Sun, Oct 5, 4:29 PM · Patch-For-Review, MW-1.45-notes (1.45.0-wmf.21; 2025-09-30), Moderator-Tools-Team (Kanban), VisualEditor, MediaWiki-Page-diffs, VisualEditor-VisualDiffs
PatchDemoBot added a comment to T402297: It should be possible to undo edits on mobile.

Test wiki on Patch demo by SCardenas (WMF) using patch(es) linked to this task was deleted:

Sun, Oct 5, 4:29 PM · Patch-For-Review, Moderator-Tools-Team (Kanban), Mobile, MediaWiki-Page-diffs
Yug added a comment to T375653: Add Lingua Libre Django to translatewiki.net.
  1. > B🔸Oauth 2.0 on Commons : yes, I first focus on UI/i18n fixes, I will come back to those config.ini edit later this week, but before publishing the app. See T405919
  2. > A ✅ batches-view-titles: implemented, pushing it soon.
Sun, Oct 5, 4:23 PM · Patch-For-Review, LPL Essential (2025 Jul-Sep), Lingua-Libre, translatewiki.net
gerritbot added a project to T405146: UploadWizard should handle the case of inheriting copyright: Patch-For-Review.
Sun, Oct 5, 4:18 PM · Patch-For-Review, UploadWizard
Pppery added a comment to T406197: localize the mediawiki languages messages for Pashto.

Well, okay, I decided to do what shouldn't have been my responsibility and put the patch on Gerrit, and it turned out it had a PHP syntax error. Ridiculous that one would propose such a thing without even testing it.

Sun, Oct 5, 3:48 PM · Patch-For-Review, MediaWiki-Internationalization
gerritbot added a project to T406197: localize the mediawiki languages messages for Pashto: Patch-For-Review.
Sun, Oct 5, 3:44 PM · Patch-For-Review, MediaWiki-Internationalization
gerritbot added a comment to T406428: Ensure deprecation messages are always reset in DeprecationTestCase.assertOneDeprecation.

Change #1193568 merged by jenkins-bot:

[pywikibot/core@master] [bugfix] finally reset messages in DeprecationTestCase.assertOneDeprecation

https://gerrit.wikimedia.org/r/1193568

Sun, Oct 5, 3:36 PM · Pywikibot-tests, Pywikibot
gerritbot added a project to T406428: Ensure deprecation messages are always reset in DeprecationTestCase.assertOneDeprecation: Patch-For-Review.
Sun, Oct 5, 3:21 PM · Pywikibot-tests, Pywikibot
gerritbot added a comment to T405812: Migrate categorylinks to virtual domain.

Change #1193430 merged by jenkins-bot:

[mediawiki/core@master] Migrate categorylinks to virtual domain

https://gerrit.wikimedia.org/r/1193430

Sun, Oct 5, 2:07 PM · MW-1.45-notes (1.45.0-wmf.22; 2025-10-07), MediaWiki-Categories, MediaWiki-Page-derived-data, Data-Persistence
ReleaseTaggerBot added a project to T406098: Wikimedia's EmailAuth hook implementation: Don't block on IPoid response: MW-1.45-notes (1.45.0-wmf.22; 2025-10-07).
Sun, Oct 5, 2:00 PM · MW-1.45-notes (1.45.0-wmf.22; 2025-10-07), Essential-Work, MediaWiki-extensions-WikimediaEvents, Product Safety and Integrity (Sprint Apfel Strudel (Sep 29 - Oct 17)), MediaWiki-extensions-EmailAuth
Tacsipacsi added a comment to T375653: Add Lingua Libre Django to translatewiki.net.
  1. 🔸Oauth 2.0 on Commons :
  2. > A ✅ Get new creadentials : 1790f6a39f53cadf7ce2ac7d82b961f8
Sun, Oct 5, 1:46 PM · Patch-For-Review, LPL Essential (2025 Jul-Sep), Lingua-Libre, translatewiki.net
gerritbot added a comment to T406098: Wikimedia's EmailAuth hook implementation: Don't block on IPoid response.

Change #1193403 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] Log using a DeferredUpdate in onEmailAuthRequireToken

https://gerrit.wikimedia.org/r/1193403

Sun, Oct 5, 1:45 PM · MW-1.45-notes (1.45.0-wmf.22; 2025-10-07), Essential-Work, MediaWiki-extensions-WikimediaEvents, Product Safety and Integrity (Sprint Apfel Strudel (Sep 29 - Oct 17)), MediaWiki-extensions-EmailAuth
gerritbot added a project to T406424: Removed the FlaggedRevs extension on la.ws: Patch-For-Review.
Sun, Oct 5, 1:43 PM · Patch-For-Review, Wikimedia-Site-requests, FlaggedRevs
cmassaro moved T405130: Abandon Avro serialization; use the raw JSON request format and, optionally, compression from Incoming to In Engineering on the Abstract Wikipedia team (26Q2 (Oct–Dec)) board.
Sun, Oct 5, 11:59 AM · Abstract Wikipedia team (26Q2 (Oct–Dec)), Patch-For-Review, function-schemata, function-evaluator, function-orchestrator
gerritbot added a project to T406142: Error 1091: Can't DROP INDEX `cl_timestamp`; check that it exists: Patch-For-Review.
Sun, Oct 5, 11:38 AM · Patch-For-Review, MediaWiki-Installer
cmassaro moved T405130: Abandon Avro serialization; use the raw JSON request format and, optionally, compression from Engineering Backlog to 26Q2 (Oct–Dec) on the Abstract Wikipedia team board.
Sun, Oct 5, 10:25 AM · Abstract Wikipedia team (26Q2 (Oct–Dec)), Patch-For-Review, function-schemata, function-evaluator, function-orchestrator
Aklapper added a comment to T405596: Disable IO for diffusion repositories.

This ticket is getting harder to follow and by now covers numerous things. We may want to move some items into subtasks.

Sun, Oct 5, 10:23 AM · Patch-For-Review, collaboration-services, Diffusion, Phabricator
CodeReviewBot added a project to T405596: Disable IO for diffusion repositories: Patch-For-Review.

aklapper opened https://gitlab.wikimedia.org/repos/phabricator/phabricator/-/merge_requests/103

Sun, Oct 5, 10:21 AM · Patch-For-Review, collaboration-services, Diffusion, Phabricator
hubaishan claimed T384501: ForeignDBRepo does not support Postgresql.
Sun, Oct 5, 10:03 AM · Patch-For-Review, Commons, PostgreSQL, MediaWiki-File-management
gerritbot added a project to T384501: ForeignDBRepo does not support Postgresql: Patch-For-Review.
Sun, Oct 5, 10:01 AM · Patch-For-Review, Commons, PostgreSQL, MediaWiki-File-management
gerritbot added a comment to T371232: Investigate subref RTL behavior.

Change #1193558 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] [POC] Use localized digits for sub-ref counters

https://gerrit.wikimedia.org/r/1193558

Sun, Oct 5, 9:58 AM · Patch-For-Review, Cite (Sub-referencing), WMDE-TechWish-Sprint-2024-07-24
gerritbot added a project to T371232: Investigate subref RTL behavior: Patch-For-Review.
Sun, Oct 5, 9:58 AM · Patch-For-Review, Cite (Sub-referencing), WMDE-TechWish-Sprint-2024-07-24
ReleaseTaggerBot added a project to T405400: "Cancel" button in Special:WishlistIntake and Special:EditFocusArea should be the previous page the user was on (if it was a Wishlist page): MW-1.45-notes (1.45.0-wmf.22; 2025-10-07).
Sun, Oct 5, 5:00 AM · MW-1.45-notes (1.45.0-wmf.22; 2025-10-07), MediaWiki-extensions-CommunityRequests, Community-Tech (Sea Lion Squad)
ReleaseTaggerBot added a project to T404101: Deleted Focus Area still appears as assigned in Wish instead of reverting to 'Unassigned': MW-1.45-notes (1.45.0-wmf.22; 2025-10-07).
Sun, Oct 5, 5:00 AM · MW-1.45-notes (1.45.0-wmf.22; 2025-10-07), Community-Tech (Sea Lion Squad), MediaWiki-extensions-CommunityRequests
gerritbot added a comment to T404101: Deleted Focus Area still appears as assigned in Wish instead of reverting to 'Unassigned'.

Change #1192892 merged by jenkins-bot:

[mediawiki/extensions/CommunityRequests@master] Display Unassigned focus area when focus area is invalid

https://gerrit.wikimedia.org/r/1192892

Sun, Oct 5, 4:46 AM · MW-1.45-notes (1.45.0-wmf.22; 2025-10-07), Community-Tech (Sea Lion Squad), MediaWiki-extensions-CommunityRequests
gerritbot added a comment to T405400: "Cancel" button in Special:WishlistIntake and Special:EditFocusArea should be the previous page the user was on (if it was a Wishlist page).

Change #1192630 merged by jenkins-bot:

[mediawiki/extensions/CommunityRequests@master] Cancel button should return to previous page when using "returnto"

https://gerrit.wikimedia.org/r/1192630

Sun, Oct 5, 4:45 AM · MW-1.45-notes (1.45.0-wmf.22; 2025-10-07), MediaWiki-extensions-CommunityRequests, Community-Tech (Sea Lion Squad)
MusikAnimal closed T366194: Migrate Community Wishlist to CommunityRequests extension as Resolved.
Sun, Oct 5, 3:30 AM · Community-Tech (Sea Lion Squad), MW-1.44-notes (1.44.0-wmf.2; 2024-11-05), Patch-For-Review, MW-1.43-notes (1.43.0-wmf.24; 2024-09-24), Epic, MediaWiki-extensions-CommunityRequests, Wishlist intake gadget
MusikAnimal updated the task description for T366194: Migrate Community Wishlist to CommunityRequests extension.
Sun, Oct 5, 3:29 AM · Community-Tech (Sea Lion Squad), MW-1.44-notes (1.44.0-wmf.2; 2024-11-05), Patch-For-Review, MW-1.43-notes (1.43.0-wmf.24; 2024-09-24), Epic, MediaWiki-extensions-CommunityRequests, Wishlist intake gadget
MusikAnimal moved T406194: InvalidArgumentException: Wishes must have a proposer! from Backlog to v1 on the MediaWiki-extensions-CommunityRequests board.
Sun, Oct 5, 12:16 AM · Patch-For-Review, Community-Tech (Sea Lion Squad), MediaWiki-extensions-CommunityRequests, Wikimedia-production-error

Sat, Oct 4

gerritbot added a comment to T394059: Post-cache output transforms are expensive on large pages.

Change #1148324 merged by jenkins-bot:

[mediawiki/core@REL1_43] DeduplicateStyles: Only transform possible style nodes

https://gerrit.wikimedia.org/r/1148324

Sat, Oct 4, 8:21 PM · MW-1.43-notes, MW-1.45-notes (1.45.0-wmf.4; 2025-06-03), MW-1.44-notes, Content-Transform-Team (Work In Progress), MediaWiki-Platform-Team (Radar), Wikimedia-Performance-recommendation, Performance Issue, MediaWiki-Parser
gerritbot added a comment to T398402: Remaining feature parity issues between the two Cite parsers.

Change #1193545 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Fix misplaced (underlined) space in backlinks

https://gerrit.wikimedia.org/r/1193545

Sat, Oct 4, 8:08 PM · MW-1.45-notes (1.45.0-wmf.21; 2025-09-30), Patch-For-Review, Content-Transform-Team, Epic, Cite
dancy added a comment to T328254: Parser function for content model {{#contentmodel:}}.

Perhaps this isn't the best place for this conversation...

Yes that error message means there is something wrong with your localization cache. If you're running install.php, I would expect it is not using WMF style localization cache since that's non-default and install.php would only be using defaults, so its not surprising rebuildLocalisationCache.php didn't do anything - its rebuilding a different localization cache than the one in use.

Sat, Oct 4, 7:21 PM · MW-1.45-notes (1.45.0-wmf.21; 2025-09-30), Patch-For-Review, User-notice, MediaWiki-Parser
gerritbot added a comment to T328207: Change Namespace Aliases on diq.wikipedia.

Change #1193544 had a related patch set uploaded (by Cappybaraa; author: Cappybaraa):

[mediawiki/extensions/Scribunto@master] Change Modul talk namespace name for diqwiki

https://gerrit.wikimedia.org/r/1193544

Sat, Oct 4, 7:05 PM · Patch-For-Review, good first task, Wikimania-Hackathon-2024, Scribunto, MediaWiki-Internationalization, Wikimedia-Site-requests
MusikAnimal moved T406194: InvalidArgumentException: Wishes must have a proposer! from In Development to Feedback and Review on the Community-Tech (Sea Lion Squad) board.
Sat, Oct 4, 7:04 PM · Patch-For-Review, Community-Tech (Sea Lion Squad), MediaWiki-extensions-CommunityRequests, Wikimedia-production-error
MusikAnimal triaged T406194: InvalidArgumentException: Wishes must have a proposer! as High priority.

r1193543 will surface any existing wishes with invalid proposers (there are likely a few that were renamed since they created their wish), while r1193542 offers a way to update the wikitext when a user is renamed. The former is I think a must-have, the latter is debatable.

Sat, Oct 4, 7:03 PM · Patch-For-Review, Community-Tech (Sea Lion Squad), MediaWiki-extensions-CommunityRequests, Wikimedia-production-error
Adarsh2406 added a comment to T406412: The Refreshed-this-wiki-wordmark message is ignored, if $wgLogos['wordmark'] is set.

Sorry @Aklapper I'll be careful next time !

Sat, Oct 4, 6:59 PM · Patch-For-Review, Refreshed
Aklapper added a comment to T406412: The Refreshed-this-wiki-wordmark message is ignored, if $wgLogos['wordmark'] is set.

@Adarsh2406: Again: You are in the wrong task. The only patch associated with this task is https://gerrit.wikimedia.org/r/c/1193537 by ashley and this task is assigned to ashley. Please keep discussion on-topic. This is not a forum. Thanks.

Sat, Oct 4, 6:45 PM · Patch-For-Review, Refreshed
gerritbot added a comment to T406194: InvalidArgumentException: Wishes must have a proposer!.

Change #1193543 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/CommunityRequests@master] WishRenderer: short-circuit and show error if proposer is invalid

https://gerrit.wikimedia.org/r/1193543

Sat, Oct 4, 6:36 PM · Patch-For-Review, Community-Tech (Sea Lion Squad), MediaWiki-extensions-CommunityRequests, Wikimedia-production-error
Reedy added a comment to T396302: Remove old symfony/polyfill-php* replace directives.

ruflin/elastica 8.0 onwards do drop the symfony/polyfill-php73..

Sat, Oct 4, 6:30 PM · Patch-For-Review, MediaWiki-Vendor
Reedy closed T347809: Upgrade ElasticSearch related composer libraries, a subtask of T396302: Remove old symfony/polyfill-php* replace directives, as Resolved.
Sat, Oct 4, 6:30 PM · Patch-For-Review, MediaWiki-Vendor
Adarsh2406 added a comment to T406412: The Refreshed-this-wiki-wordmark message is ignored, if $wgLogos['wordmark'] is set.

Hi — Verified +2 is green. Could someone with Code-Review/Submit rights please give Code-Review +2 and submit this change?
Bug: T406412. Thanks!

Sat, Oct 4, 5:51 PM · Patch-For-Review, Refreshed
gerritbot added a project to T406194: InvalidArgumentException: Wishes must have a proposer!: Patch-For-Review.
Sat, Oct 4, 5:43 PM · Patch-For-Review, Community-Tech (Sea Lion Squad), MediaWiki-extensions-CommunityRequests, Wikimedia-production-error
Adarsh2406 added a comment to T406407: MediaWiki\Title\Title::getPageViewLanguage was deprecated in MediaWiki 1.42.

Hi — Verified +2 is green. Could someone with Code-Review/Submit rights please give Code-Review +2 and submit this change?
Also please backport to REL1_43 if accepted.
Bug: T406407. Thanks!

Sat, Oct 4, 5:41 PM · RoadToWiki, Patch-For-Review, Metrolook