Skip to content

deps: update Truth and JUnit - #6754

Merged
creamsoup merged 3 commits into
grpc:masterfrom
elharo:test
Feb 26, 2020
Merged

creamsoup merged 3 commits into
grpc:masterfrom
elharo:test

Conversation

@elharo

@elharo elharo commented Feb 25, 2020

Copy link
Copy Markdown
Contributor

@ejona86 ejona86 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Truth upgrade is fine, but we generally want junit to stay in sync with internal junit version, which is on 4.12 at the moment.

@elharo elharo left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted JUnit

Comment thread repositories.bzl Resolved
@dapengzhang0 dapengzhang0 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Feb 26, 2020
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Feb 26, 2020
@creamsoup
creamsoup merged commit 159632c into grpc:master Feb 26, 2020
@creamsoup

Copy link
Copy Markdown
Contributor

merged thanks @elharo!

dfawley pushed a commit to dfawley/grpc-java that referenced this pull request Jan 15, 2021
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

5 participants