The Wayback Machine - https://web.archive.org/web/20110514000613/http://www.mediawiki.org/wiki/Special:Code/MediaWiki/comments

Code Review

From MediaWiki.org
Jump to: navigation, search
First page
First page
Previous page
Previous page
Last page
Last page
Date Commenter Rev. Status Commit summary Note
23:34, 13 May 2011 Hashar 87992 new Support abstraction for 'NOT IN' SQL structure... dankeschön!
23:33, 13 May 2011 Catrope 87992 new Support abstraction for 'NOT IN' SQL structure... I ran the tests and they're fine.
22:47, 13 May 2011 Platonides 88019 new

* fixed as per comment on r88008

I don't think people like Domas would enjoy getting a SQL comment in Chinese (wh...

22:36, 13 May 2011 Freakolowsky 88019 new

* fixed as per comment on r88008

Yeah ... if i manage to do that Siebrand will be out of job :D
21:54, 13 May 2011 DieBuche 88021 ok

Follow-up r88014: Removing tablesorter from mw.util test loader, no longer being...

A late nite ok
21:37, 13 May 2011 Nikerabbit 88019 new

* fixed as per comment on r88008

Translating SQL comments?
21:35, 13 May 2011 Reedy 88007 ok

(bug 24781) Define XML namespace for API output. Also created the referenced URL...

Probably worth doing a mailing list post to go with this, as if per the bug, if ...

20:58, 13 May 2011 Freakolowsky 88008 new

* bug 24037

on it ...
17:59, 13 May 2011 Raymond 88008 new

* bug 24037

This needs better i18n support. Maybe ChangesList::showCharacterDifference() can...

...
17:35, 13 May 2011 NeilK 87984 fixme

Bug 26090 : Ignore unlikely EXIF dates in UploadWizard

This doesn't really fix the problem. Maybe checkdate() ? http://www.php.net/manu...

17:32, 13 May 2011 Platonides 88010 ok

removed max line size for a sql dump file. This optional since PHP 4.2.0. Larger...

Until PHP 4.3.0 removing the 1024 would have done nothing (it defaulted to 1024)...

17:19, 13 May 2011 Platonides 87930 ok tests for XmlSelect::GetAttributes() The [http://noc.wikimedia.org/~hashar/pres/mwtesting/ most documented] test!
16:54, 13 May 2011 Brion VIBBER 87992 new Support abstraction for 'NOT IN' SQL structure...

I'm not sure I'm a fan of this; it's not very clear or obvious syntax, and we've...

...
16:42, 13 May 2011 Hashar 87992 new Support abstraction for 'NOT IN' SQL structure... Maybe we can hack it together this evening ? :p
16:24, 13 May 2011 ^demon 88004 new

(bug 10154) Don't allow user to specify days beyond $wgRCMaxAge

No, we can't kill it. Dozens of users in /trunk/extensions :(
16:22, 13 May 2011 IAlex 88004 new

(bug 10154) Don't allow user to specify days beyond $wgRCMaxAge

I am not sure that is the correct commit summary <code>;)</code>
16:22, 13 May 2011 ^demon 88004 new

(bug 10154) Don't allow user to specify days beyond $wgRCMaxAge

Didn't press save. Summary was:...
16:18, 13 May 2011 IAlex 87860 resolved adding icon for cc-by license svn:mime-type property is incorrect.
16:18, 13 May 2011 Nikerabbit 87584 new More versions added to @deprecated tags... Someone fixed that.
16:14, 13 May 2011 Reedy 87584 new More versions added to @deprecated tags... Can't replicate...
16:05, 13 May 2011 Nikerabbit 87992 new Support abstraction for 'NOT IN' SQL structure... Can this be extended to other operations and non-array values?
15:59, 13 May 2011 Nikerabbit 87985 reverted

Gerenalized code used in 2 places for adding scripts to the body, and switched f...

Got a good laugh :)
15:57, 13 May 2011 ^demon 87982 deferred  

Yes. I was doing some general tests to both the "syntax checker" and "empty comm...

15:57, 13 May 2011 Nikerabbit 87982 deferred   Testing pre-commit hook? :)
15:27, 13 May 2011 Krinkle 87970 new

comparing colors cross-browser is Aweful. Turns out Opera normalizes to hexideci...

This is a follow-up ro r87938.

15:23, 13 May 2011 Trevor Parscal 87985 reverted

Gerenalized code used in 2 places for adding scripts to the body, and switched f...

Don't judge me!
12:44, 13 May 2011 RussNelson 87942 new First checkin

Don't worry about that last class -- I just brought it in for reference purposes...

12:18, 13 May 2011 IAlex 87948 fixme fix backtrace on SQL error... Addendum: only happens when Exception::useOutputPage() returns false.
11:32, 13 May 2011 Jeroen De Dauw 87951 fixme

moved stubbing features of SMWSemanticData container to a new subclass, since th...

I'm getting this error when refreshing the semantic data and then running runJob...

...
11:26, 13 May 2011 IAlex 87948 fixme fix backtrace on SQL error...

Now the backtrace is displayed twice. It's added by <code>DBError::getText()</co...

05:00, 13 May 2011 Bawolff 87942 new First checkin

I don't really know what this extension actually does/how it works, so this comm...

04:21, 13 May 2011 Bawolff 87305 new

fix issues from r86927, user language and years over 9999

Perhaps should use the result $parser->getOptions()->getUserLang(); to get the l...

03:54, 13 May 2011 Mdale 86577 resolved

Added generic bucketing feature to the user object, which handles bucketing user...

I don't think anyone is against having it available at all times within mediaWik...

02:12, 13 May 2011 Kaldari 86927 fixme

adding language support to #time parser function, per bug 28655

Hey Bawolff, can you take a look at the follow-up diffs and let me know if anyth...

01:57, 13 May 2011 Peachey88 87942 new First checkin localsettings.php?!?!
23:48, 12 May 2011 Hashar 87555 ok Remove functions marked for removal in 1.19 Checked extensions by running:...
23:22, 12 May 2011 Trevor Parscal 86577 resolved

Added generic bucketing feature to the user object, which handles bucketing user...

It's certainly possible to break it out for cleanliness, and possibly load it on...

23:06, 12 May 2011 MarkAHershberger 87897 fixme

* (bug 28842) Fix userrights issue on 1.16.5 with the Lockdown extension (check ...

to support 1.16.5 this needs to be ported to the REL_1_16 branch
23:03, 12 May 2011 Bawolff 87936 new Corrects a small bug causing <math>\sin</math> to return an unknown...

<nowiki><math>\sin foo32</math> still seems to fail. However I can confirm both ...

21:54, 12 May 2011 JanPaul123 87921 new remove jquery.json from InlineEditor (dupe)... Sweet, thanks, was just about to do this. :D
20:02, 12 May 2011 TheDJ 87923 new

Add support for the Height parameter for OggHandler. Fixes bug 28886

...
Some parts of this probably need to be ported over to TimedMediaHandler_body.php
20:01, 12 May 2011 Jack Phoenix 87884 deferred new extension

Good catch, thanks! I've fixed that in r87928.

19:43, 12 May 2011 TheDJ 87923 new

Add support for the Height parameter for OggHandler. Fixes bug 28886

...

Also fixes bug 28885

19:30, 12 May 2011 IAlex 87884 deferred new extension <code>Article::insertNewArticle()</code> doesn't exist anymore.
12:02, 12 May 2011 Jeroen De Dauw 87894 fixme some changes of 2 days back that I apparently did not commit correctly s/and/or?...
11:30, 12 May 2011 Jack Phoenix 80435 ok Add new Hooks class, because $wgHooks globals are evil. ...

I say we keep this class and deprecate $wgHooks and wfRunHooks() and remove them...

...
10:01, 12 May 2011 Faure.thomas 87537 resolved new Categorize extension

fixed in r87707

06:26, 12 May 2011 Skizzerz 87897 fixme

* (bug 28842) Fix userrights issue on 1.16.5 with the Lockdown extension (check ...

I used uppercase NULL because uppercase NULL was used later on in the function, ...

05:41, 12 May 2011 Bawolff 87897 fixme

* (bug 28842) Fix userrights issue on 1.16.5 with the Lockdown extension (check ...

The comment is slightly confusing, given that null !== false.
05:37, 12 May 2011 Nikerabbit 87897 fixme

* (bug 28842) Fix userrights issue on 1.16.5 with the Lockdown extension (check ...

Lower case <tt>null</tt> is preferred.
First page
First page
Previous page
Previous page
Last page
Last page
Personal tools
Namespaces
Variants
Views
Actions
Site
Support
Download
Development
Communication
Toolbox