Code Review
For MediaWiki (recent comments | status changes | tags | authors | states | release notes | statistics)
 First page |
 Previous page |
 Next page |
 Last page |
| Date | Commenter | Rev. | Status | Commit summary | Note |
|---|---|---|---|---|---|
| 23:16, 3 June 2011 | Tim Starling | 85288 | fixme | The get functions in this revision call half the codebase: User, Language, Title... |
|
| 22:28, 3 June 2011 | Brion VIBBER | 89230 | reverted | Thanks for starting on that! I've provisionally reverted this change in r89447 u... |
|
| 22:20, 3 June 2011 | Brion VIBBER | 89408 | fixme | This has changed a number of hook parameter calls from pass-by-reference to pass... ... |
|
| 22:15, 3 June 2011 | Brion VIBBER | 89407 | fixme | If refactoring, can you go ahead and add some unit test cases? This always helps... |
|
| 22:08, 3 June 2011 | Brion VIBBER | 89419 | fixme | This comes immediately after another super-specific rule that it doesn't allow r... ... |
|
| 21:58, 3 June 2011 | Platonides | 89230 | reverted | Thanks Hashar. As I first wanted to prove that studied regex were faster than no... ... |
|
| 21:22, 3 June 2011 | Catrope | 89284 | new | Believe it or not, all of their stuff is stored in the DB escaped for HTML. I al... |
|
| 21:14, 3 June 2011 | Platonides | 89166 | fixme | That looks better. Sigh, all these hiphop directories are a nightmare. Why can't... |
|
| 21:07, 3 June 2011 | Platonides | 89220 | new | clearState() passes the $parser by copy, checkRefsNoReferences() passes it by re... |
|
| 21:02, 3 June 2011 | Brion VIBBER | 89263 | new | Can't extensions already add themselves to the DatabaseUpdater list through a ho... |
|
| 21:00, 3 June 2011 | Brion VIBBER | 89273 | ok | Looks ok and doesn't seem to cause any new phpunit failures in API tests. | |
| 20:58, 3 June 2011 | Brion VIBBER | 89294 | ok | Actually it might work to do a single query with different grouping.... but it p... |
|
| 20:57, 3 June 2011 | Brion VIBBER | 89294 | ok | Excellent. :D Looks like it should work fine with the current selection algorith... |
|
| 20:44, 3 June 2011 | Brion VIBBER | 89258 | ok | Confirmed working ok with TimedMediaHandler. | |
| 20:41, 3 June 2011 | Brion VIBBER | 89278 | new | Adding protocols increases the security attack surface and doesn't have an obvio... ... |
|
| 20:09, 3 June 2011 | MarkAHershberger | 89278 | new | I'm willing to change the Request class name to URI (or what have... | |
| 20:04, 3 June 2011 | Kaldari | 89294 | ok | Exactly. The reason for this change is that the fundraising people want each ban... |
|
| 19:41, 3 June 2011 | Brion VIBBER | 89278 | new | Hmm should we actually deliberately support ftp in the Http request class? We ma... |
|
| 19:40, 3 June 2011 | Brion VIBBER | 89284 | new | This looks pretty wrong:... | |
| 19:31, 3 June 2011 | Brion VIBBER | 89294 | ok | Hmm.. if a banner is in multiple campaigns does this mean we end up with multipl... |
|
| 19:30, 3 June 2011 | Brion VIBBER | 89294 | ok | Why run multiple queries rather than selecting not_id along with the other field... |
|
| 19:23, 3 June 2011 | Brion VIBBER | 89431 | new | Somebody needs to set up the updated language names and redirects then before it... |
|
| 19:21, 3 June 2011 | Brion VIBBER | 89315 | new | I like the animated sprite trick!... | |
| 19:17, 3 June 2011 | SPQRobin | 89431 | new | I don't think this should be changed here, since the actual wiki is not renamed.... ... |
|
| 19:03, 3 June 2011 | Brion VIBBER | 89317 | new | Well that's a start I guess. :) But is there a minimum actually *required* versi... ... |
|
| 19:00, 3 June 2011 | Brion VIBBER | 89318 | new | Awesome! Definitely good to get a better idea what the performance characteristi... |
|
| 18:49, 3 June 2011 | Brion VIBBER | 89414 | reverted | Provisionally reverted in r89430 along with problematic parent commit r89406. |
|
| 18:49, 3 June 2011 | Brion VIBBER | 89406 | reverted | Ewwww... reference problems. I've reverted this for now in r89430; some notes on... |
|
| 18:40, 3 June 2011 | Brion VIBBER | 89409 | reverted | Reverted in r89429; this implementation isn't compatible with DatabaseMySQL's im... ... |
|
| 18:16, 3 June 2011 | Nikerabbit | 74035 | fixme | Translate extension is broken for 1.16. | |
| 17:54, 3 June 2011 | Krinkle | 89365 | ok | Solves bug 28927. |
|
| 16:46, 3 June 2011 | Nikerabbit | 89406 | reverted | Here is a third one: Strict Standards: Only variables should be passed by refere... |
|
| 16:40, 3 June 2011 | Nikerabbit | 89406 | reverted | Here is another one: Notice: Use of RequestContext::__get() is deprecated; use $... |
|
| 16:20, 3 June 2011 | Huji | 89419 | fixme | Because only DIVs and SPANs are going to be used in the MediaWiki messages to co... ... |
|
| 16:17, 3 June 2011 | Nikerabbit | 89419 | fixme | I mean ";RE". Why are the two blocks not equivalent? | |
| 16:17, 3 June 2011 | Nikerabbit | 89419 | fixme | ;RE? Why is it restricted to divs? Are you sure the div.ltr part is not flipped? | |
| 16:01, 3 June 2011 | ^demon | 89400 | new | Yeah, there's something weird going on in Block that I'm just not getting. nextS... |
|
| 15:44, 3 June 2011 | ^demon | 89409 | reverted | Don't see why we need a new hook, we should be able to make use of LoadExtension... ... |
|
| 15:35, 3 June 2011 | Freakolowsky | 89409 | reverted | erm ... all extensions that have custom tables an use unit test ... do not gener... |
|
| 15:21, 3 June 2011 | MaxSem | 89409 | reverted | Yes, current soultion does not require extensions to do extra stuff, your requir... |
|
| 15:07, 3 June 2011 | Freakolowsky | 89409 | reverted | reading a file and triggering hook run is such an overcomplication ... you mean,... |
|
| 14:53, 3 June 2011 | MaxSem | 89409 | reverted | This is a huge overcomplication for a superficial reason. For databases shared b... |
|
| 14:37, 3 June 2011 | Freakolowsky | 89409 | reverted | TRUE, but those tables could "register" their tables trough a hook like with Ext... ... |
|
| 14:28, 3 June 2011 | MaxSem | 89409 | reverted | I disagree, there may be extension tables that we might want to duplicate. | |
| 13:43, 3 June 2011 | Hashar | 88250 | new | Sounds like a step toward fixing bug 19919 "Article count in Special:Statistics ... |
|
| 12:20, 3 June 2011 | Freakolowsky | 89409 | reverted | Well i was thinking more in the direction of <code>protected</code> ... always b... ... |
|
| 12:08, 3 June 2011 | Hashar | 89376 | new | marking for 1.18. | |
| 12:05, 3 June 2011 | Hashar | 89409 | reverted | Maybe the method should be marked <code>final</code>? | |
| 11:58, 3 June 2011 | Nikerabbit | 89406 | reverted | Here is one: Notice: Use of RequestContext::__get() is deprecated; use $context-... |
|
| 11:45, 3 June 2011 | Freakolowsky | 89409 | reverted | Keep in mind that db-specific overloads have to be fixed too. |
First page |
Previous page |
Next page |
Last page |
